From patchwork Fri Oct 18 12:03:04 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Hsin-Te Yuan X-Patchwork-Id: 13841684 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 23F84D2FFFD for ; Fri, 18 Oct 2024 12:04:46 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Cc:To:In-Reply-To:References :Message-Id:Content-Transfer-Encoding:Content-Type:MIME-Version:Subject:Date: From:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=EYlu7kUyVVFvizFrzeSTtKVIpspDxNh9CaA9Lpt1VR8=; b=OJO/NCMQ6+FmAsC2FXCS/HfCod 41pUE+1HCX8b9WWSZZNYV8o2/3DWczobNiYLqy86bm+XnYJjWOfEWKZzcD1wuUFyNnfFRGsUf0/wC bUX6U2TQmxmBg0TdDNqZsT8YaoF8tHgWciEUpxP4CaS9WE2e6S72h7RroTIrjIzo1HubK3zBSxWuo iPT9IkLG+dszi8/b7tQUsfUC0RbrmALb036pZ0uP9IcW4MAyxyuLF4G+Tbop9/NUd4Ni7eH+awVLF HSfk+YitjvsFILpBzJ5fIfYb0oyt6jDA4v1ZEmy+ern1+lXA+bL6YWXDMIgePwElDJaWjdl65qm2A +IiNDGxw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98 #2 (Red Hat Linux)) id 1t1lim-00000000hwO-0hyl; Fri, 18 Oct 2024 12:04:44 +0000 Received: from mail-pf1-x42d.google.com ([2607:f8b0:4864:20::42d]) by bombadil.infradead.org with esmtps (Exim 4.98 #2 (Red Hat Linux)) id 1t1lhJ-00000000heM-3zDQ for linux-mediatek@lists.infradead.org; Fri, 18 Oct 2024 12:03:15 +0000 Received: by mail-pf1-x42d.google.com with SMTP id d2e1a72fcca58-71e4c2e36daso2286369b3a.0 for ; Fri, 18 Oct 2024 05:03:13 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; t=1729252993; x=1729857793; darn=lists.infradead.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=EYlu7kUyVVFvizFrzeSTtKVIpspDxNh9CaA9Lpt1VR8=; b=iLYzuMxGPJDQzqNqx+geVVqAvMljU5ozn9JgmKGMvkvjagCdsSw/co/AdcefJek/ay 7DhEFKASL5hG/IYyUxjFovmHI3af/M+hPV4GR2XXqebbRXRIBZcUWYUXMpUZyO7lRen/ CTYsm9Us0/Ei9kf1W7ol7w2xEi03X97t3Alfs= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1729252993; x=1729857793; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=EYlu7kUyVVFvizFrzeSTtKVIpspDxNh9CaA9Lpt1VR8=; b=mJhyWvZQb5HIgkluJSbes3WiEMi9EA+SzYL+dmCK2PTas9gjMh64b8S2qcNgB4sqph eHm8qUWzMXbeKEC6kNfEvtNn4vzw6+g6WuSABFIpFfpxckF/jAzqVxFDopAtBb5Tipgk 5pDLe1oEdSfqs/cqwWvFuhOLEaHU4VvrQjspeekvSVKDFdUyIjBx0kQaQqf4N7SAoH17 oPYZvhOHYS2e9qpOmLejst54PWIaoF5l35+fqOs8mYlooE9XXRvvyHXpnQnzo0NqCufQ 0j/4R1+eZEnaY/5cfKzgTB1+GKcoEnKOMf1tERZe9BO5jjb4bIhGBteFGSDZ3Wbfae4+ 7Tfg== X-Forwarded-Encrypted: i=1; AJvYcCV3aCVXFFn4sPPhX9yRWpPe54LfkqxV3oG6mGW+xcEA74zjsLLeeHzhbmgzETzgtLphDT4zADQcWE31MDi+mg==@lists.infradead.org X-Gm-Message-State: AOJu0YydJaTXQ80XKREmaL2nN+tMDTrYstAkboPbsUyxsMIRh07SlFx/ a+3T674elAObbZiXe1ZPSogu4gjiQORMGHFLmLgNCeLYaZdCGD4RrFHHEwx4jQ== X-Google-Smtp-Source: AGHT+IEGcDG3wlVNeyTnkESm9SQYHh/INABqC103bGWJJBZMyFepMcJaZpMON7AKaGrz5XrQO641SA== X-Received: by 2002:a05:6a00:2c5:b0:71e:674b:474 with SMTP id d2e1a72fcca58-71e8fd72e7amr9523466b3a.8.1729252992874; Fri, 18 Oct 2024 05:03:12 -0700 (PDT) Received: from yuanhsinte.c.googlers.com (176.220.194.35.bc.googleusercontent.com. [35.194.220.176]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-71ea34ae672sm1274014b3a.204.2024.10.18.05.03.10 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 18 Oct 2024 05:03:12 -0700 (PDT) From: Hsin-Te Yuan Date: Fri, 18 Oct 2024 12:03:04 +0000 Subject: [PATCH 1/2] arm64: dts: mediatek: mt8183: Fix race condition of pinctrl MIME-Version: 1.0 Message-Id: <20241018-post-reset-v1-1-5aadb7550037@chromium.org> References: <20241018-post-reset-v1-0-5aadb7550037@chromium.org> In-Reply-To: <20241018-post-reset-v1-0-5aadb7550037@chromium.org> To: Rob Herring , Krzysztof Kozlowski , Conor Dooley , Matthias Brugger , AngeloGioacchino Del Regno , Enric Balletbo i Serra , Hsin-Yi Wang , Benjamin Tissoires , Hans de Goede Cc: devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org, Hsin-Te Yuan X-Mailer: b4 0.15-dev-7be4f X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20241018_050314_039227_673F86CE X-CRM114-Status: GOOD ( 11.31 ) X-BeenThere: linux-mediatek@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "Linux-mediatek" Errors-To: linux-mediatek-bounces+linux-mediatek=archiver.kernel.org@lists.infradead.org Some mt8183 devices use second source touchscreen/trackpad and share the same pinctrl property with the original touchscreen/trackpad. Currently, multiple touchscreen/trackpad drivers might probe simultaneously, causing a race condition of getting the same pin. Move the pinctrl property to the i2c node to workaround this issue. Fixes: dd6e3b06214f ("arm64: dts: mt8183: Add kukui-jacuzzi-burnet board") Fixes: 52e84f233459 ("arm64: dts: mt8183: Add kukui-jacuzzi-cozmo board") Fixes: 6cd7fdc8c530 ("arm64: dts: mt8183: Add kukui-jacuzzi-fennel board") Fixes: 124d64392de2 ("arm64: dts: mt8183: Add kukui-jacuzzi-juniper board") Fixes: f006bcf1c972 ("arm64: dts: mt8183: Add kukui-jacuzzi-willow board") Fixes: 055ef10ccdd4 ("arm64: dts: mt8183: Add jacuzzi pico/pico6 board") Signed-off-by: Hsin-Te Yuan --- arch/arm64/boot/dts/mediatek/mt8183-kukui-jacuzzi-burnet.dts | 2 -- arch/arm64/boot/dts/mediatek/mt8183-kukui-jacuzzi-cozmo.dts | 3 --- arch/arm64/boot/dts/mediatek/mt8183-kukui-jacuzzi-damu.dts | 2 -- .../boot/dts/mediatek/mt8183-kukui-jacuzzi-fennel-sku1.dts | 2 -- .../boot/dts/mediatek/mt8183-kukui-jacuzzi-fennel-sku6.dts | 2 -- .../boot/dts/mediatek/mt8183-kukui-jacuzzi-fennel-sku7.dts | 2 -- arch/arm64/boot/dts/mediatek/mt8183-kukui-jacuzzi-fennel.dtsi | 3 --- arch/arm64/boot/dts/mediatek/mt8183-kukui-jacuzzi-juniper.dtsi | 3 --- arch/arm64/boot/dts/mediatek/mt8183-kukui-jacuzzi-pico.dts | 3 --- arch/arm64/boot/dts/mediatek/mt8183-kukui-jacuzzi-pico6.dts | 3 --- arch/arm64/boot/dts/mediatek/mt8183-kukui-jacuzzi-willow.dtsi | 3 --- arch/arm64/boot/dts/mediatek/mt8183-kukui-jacuzzi.dtsi | 10 +++------- 12 files changed, 3 insertions(+), 35 deletions(-) diff --git a/arch/arm64/boot/dts/mediatek/mt8183-kukui-jacuzzi-burnet.dts b/arch/arm64/boot/dts/mediatek/mt8183-kukui-jacuzzi-burnet.dts index 19c1e2bee494c98c0db87308494713a26e304cd2..32ec6fd30fdb7449e9e606f69d16556bcdecc369 100644 --- a/arch/arm64/boot/dts/mediatek/mt8183-kukui-jacuzzi-burnet.dts +++ b/arch/arm64/boot/dts/mediatek/mt8183-kukui-jacuzzi-burnet.dts @@ -21,8 +21,6 @@ &i2c0 { touchscreen@2c { compatible = "hid-over-i2c"; reg = <0x2c>; - pinctrl-names = "default"; - pinctrl-0 = <&touchscreen_pins>; interrupts-extended = <&pio 155 IRQ_TYPE_LEVEL_LOW>; post-power-on-delay-ms = <200>; diff --git a/arch/arm64/boot/dts/mediatek/mt8183-kukui-jacuzzi-cozmo.dts b/arch/arm64/boot/dts/mediatek/mt8183-kukui-jacuzzi-cozmo.dts index f34964afe39b5353de7b17e82d14d1fba88551ab..b75ab2d33550808196f2d1d4bf0d34ccb713a07a 100644 --- a/arch/arm64/boot/dts/mediatek/mt8183-kukui-jacuzzi-cozmo.dts +++ b/arch/arm64/boot/dts/mediatek/mt8183-kukui-jacuzzi-cozmo.dts @@ -23,9 +23,6 @@ trackpad@2c { reg = <0x2c>; hid-descr-addr = <0x20>; - pinctrl-names = "default"; - pinctrl-0 = <&trackpad_pins>; - interrupts-extended = <&pio 7 IRQ_TYPE_LEVEL_LOW>; wakeup-source; diff --git a/arch/arm64/boot/dts/mediatek/mt8183-kukui-jacuzzi-damu.dts b/arch/arm64/boot/dts/mediatek/mt8183-kukui-jacuzzi-damu.dts index 0b45aee2e29953b6117b462034a00dff2596b9ff..ebe6e161354c414d91859494ec9295db75a3baf9 100644 --- a/arch/arm64/boot/dts/mediatek/mt8183-kukui-jacuzzi-damu.dts +++ b/arch/arm64/boot/dts/mediatek/mt8183-kukui-jacuzzi-damu.dts @@ -19,8 +19,6 @@ &touchscreen { compatible = "hid-over-i2c"; reg = <0x10>; interrupts-extended = <&pio 155 IRQ_TYPE_LEVEL_LOW>; - pinctrl-names = "default"; - pinctrl-0 = <&touchscreen_pins>; post-power-on-delay-ms = <10>; hid-descr-addr = <0x0001>; diff --git a/arch/arm64/boot/dts/mediatek/mt8183-kukui-jacuzzi-fennel-sku1.dts b/arch/arm64/boot/dts/mediatek/mt8183-kukui-jacuzzi-fennel-sku1.dts index 72852b7600383972d98d9b0edd40b6e99e34a85b..2dc64cc539f815b9848b8243e5b487f22d605a6d 100644 --- a/arch/arm64/boot/dts/mediatek/mt8183-kukui-jacuzzi-fennel-sku1.dts +++ b/arch/arm64/boot/dts/mediatek/mt8183-kukui-jacuzzi-fennel-sku1.dts @@ -32,8 +32,6 @@ &touchscreen { compatible = "hid-over-i2c"; reg = <0x10>; interrupts-extended = <&pio 155 IRQ_TYPE_LEVEL_LOW>; - pinctrl-names = "default"; - pinctrl-0 = <&touchscreen_pins>; post-power-on-delay-ms = <10>; hid-descr-addr = <0x0001>; diff --git a/arch/arm64/boot/dts/mediatek/mt8183-kukui-jacuzzi-fennel-sku6.dts b/arch/arm64/boot/dts/mediatek/mt8183-kukui-jacuzzi-fennel-sku6.dts index 757d0afd14fb064fc1de4608e65eb1a561c4dfa6..53e996f9c605dc36df03d4b0051a91e19fefb38d 100644 --- a/arch/arm64/boot/dts/mediatek/mt8183-kukui-jacuzzi-fennel-sku6.dts +++ b/arch/arm64/boot/dts/mediatek/mt8183-kukui-jacuzzi-fennel-sku6.dts @@ -19,8 +19,6 @@ &touchscreen { compatible = "hid-over-i2c"; reg = <0x10>; interrupts-extended = <&pio 155 IRQ_TYPE_LEVEL_LOW>; - pinctrl-names = "default"; - pinctrl-0 = <&touchscreen_pins>; post-power-on-delay-ms = <10>; hid-descr-addr = <0x0001>; diff --git a/arch/arm64/boot/dts/mediatek/mt8183-kukui-jacuzzi-fennel-sku7.dts b/arch/arm64/boot/dts/mediatek/mt8183-kukui-jacuzzi-fennel-sku7.dts index 6641b087e7c5f3a957e43ac985137dfd84ac7878..d7db621383c6b823af08ca07e0794758d062e211 100644 --- a/arch/arm64/boot/dts/mediatek/mt8183-kukui-jacuzzi-fennel-sku7.dts +++ b/arch/arm64/boot/dts/mediatek/mt8183-kukui-jacuzzi-fennel-sku7.dts @@ -19,8 +19,6 @@ &touchscreen { compatible = "hid-over-i2c"; reg = <0x10>; interrupts-extended = <&pio 155 IRQ_TYPE_LEVEL_LOW>; - pinctrl-names = "default"; - pinctrl-0 = <&touchscreen_pins>; post-power-on-delay-ms = <10>; hid-descr-addr = <0x0001>; diff --git a/arch/arm64/boot/dts/mediatek/mt8183-kukui-jacuzzi-fennel.dtsi b/arch/arm64/boot/dts/mediatek/mt8183-kukui-jacuzzi-fennel.dtsi index bbe6c338f465ee7c11bfbfc30767bdb142706480..e5b51b27980ae90a8f1099f71a891bb0562a375a 100644 --- a/arch/arm64/boot/dts/mediatek/mt8183-kukui-jacuzzi-fennel.dtsi +++ b/arch/arm64/boot/dts/mediatek/mt8183-kukui-jacuzzi-fennel.dtsi @@ -16,9 +16,6 @@ trackpad@2c { reg = <0x2c>; hid-descr-addr = <0x20>; - pinctrl-names = "default"; - pinctrl-0 = <&trackpad_pins>; - interrupts-extended = <&pio 7 IRQ_TYPE_LEVEL_LOW>; wakeup-source; diff --git a/arch/arm64/boot/dts/mediatek/mt8183-kukui-jacuzzi-juniper.dtsi b/arch/arm64/boot/dts/mediatek/mt8183-kukui-jacuzzi-juniper.dtsi index 078bc765646f57fd8c55e97325893ab50e4dac51..a96c64a9251044b2c1ba4289467b411e6c744abe 100644 --- a/arch/arm64/boot/dts/mediatek/mt8183-kukui-jacuzzi-juniper.dtsi +++ b/arch/arm64/boot/dts/mediatek/mt8183-kukui-jacuzzi-juniper.dtsi @@ -12,9 +12,6 @@ trackpad@2c { reg = <0x2c>; hid-descr-addr = <0x20>; - pinctrl-names = "default"; - pinctrl-0 = <&trackpad_pins>; - interrupts-extended = <&pio 7 IRQ_TYPE_LEVEL_LOW>; wakeup-source; diff --git a/arch/arm64/boot/dts/mediatek/mt8183-kukui-jacuzzi-pico.dts b/arch/arm64/boot/dts/mediatek/mt8183-kukui-jacuzzi-pico.dts index 8ce9568fee95a6faba0c238f6c43f43948c26d9b..2c740b3e5d3d91980ed89e07a6be70ff51906145 100644 --- a/arch/arm64/boot/dts/mediatek/mt8183-kukui-jacuzzi-pico.dts +++ b/arch/arm64/boot/dts/mediatek/mt8183-kukui-jacuzzi-pico.dts @@ -25,9 +25,6 @@ trackpad@2c { reg = <0x2c>; hid-descr-addr = <0x20>; - pinctrl-names = "default"; - pinctrl-0 = <&trackpad_pins>; - interrupts-extended = <&pio 7 IRQ_TYPE_LEVEL_LOW>; wakeup-source; diff --git a/arch/arm64/boot/dts/mediatek/mt8183-kukui-jacuzzi-pico6.dts b/arch/arm64/boot/dts/mediatek/mt8183-kukui-jacuzzi-pico6.dts index cce326aec1aa594deb6f5b14340d3552d110b160..bce368fcc884008086c091a29e3f69e541215ee5 100644 --- a/arch/arm64/boot/dts/mediatek/mt8183-kukui-jacuzzi-pico6.dts +++ b/arch/arm64/boot/dts/mediatek/mt8183-kukui-jacuzzi-pico6.dts @@ -38,9 +38,6 @@ trackpad@2c { reg = <0x2c>; hid-descr-addr = <0x20>; - pinctrl-names = "default"; - pinctrl-0 = <&trackpad_pins>; - interrupts-extended = <&pio 7 IRQ_TYPE_LEVEL_LOW>; wakeup-source; diff --git a/arch/arm64/boot/dts/mediatek/mt8183-kukui-jacuzzi-willow.dtsi b/arch/arm64/boot/dts/mediatek/mt8183-kukui-jacuzzi-willow.dtsi index 76d33540166f900c99c419c4f97ca0a56cf658f5..9b1600d5c4c1247c97fd59aa7603eaa835420117 100644 --- a/arch/arm64/boot/dts/mediatek/mt8183-kukui-jacuzzi-willow.dtsi +++ b/arch/arm64/boot/dts/mediatek/mt8183-kukui-jacuzzi-willow.dtsi @@ -12,9 +12,6 @@ trackpad@2c { reg = <0x2c>; hid-descr-addr = <0x20>; - pinctrl-names = "default"; - pinctrl-0 = <&trackpad_pins>; - interrupts-extended = <&pio 7 IRQ_TYPE_LEVEL_LOW>; wakeup-source; diff --git a/arch/arm64/boot/dts/mediatek/mt8183-kukui-jacuzzi.dtsi b/arch/arm64/boot/dts/mediatek/mt8183-kukui-jacuzzi.dtsi index 783c333107bcbf7368398feae0a29e5f0ee50c19..65f70627f2dcc4af832b8a08f7cdce354c800fae 100644 --- a/arch/arm64/boot/dts/mediatek/mt8183-kukui-jacuzzi.dtsi +++ b/arch/arm64/boot/dts/mediatek/mt8183-kukui-jacuzzi.dtsi @@ -100,14 +100,13 @@ &dsi_out { &i2c0 { status = "okay"; + pinctrl-names = "default"; + pinctrl-0 = <&touchscreen_pins>; touchscreen: touchscreen@10 { compatible = "elan,ekth3500"; reg = <0x10>; - pinctrl-names = "default"; - pinctrl-0 = <&touchscreen_pins>; - interrupts-extended = <&pio 155 IRQ_TYPE_LEVEL_LOW>; reset-gpios = <&pio 156 GPIO_ACTIVE_LOW>; @@ -116,7 +115,7 @@ touchscreen: touchscreen@10 { &i2c2 { pinctrl-names = "default"; - pinctrl-0 = <&i2c2_pins>; + pinctrl-0 = <&i2c2_pins>, <&trackpad_pins>; status = "okay"; clock-frequency = <400000>; @@ -124,9 +123,6 @@ trackpad@15 { compatible = "elan,ekth3000"; reg = <0x15>; - pinctrl-names = "default"; - pinctrl-0 = <&trackpad_pins>; - interrupts-extended = <&pio 7 IRQ_TYPE_LEVEL_LOW>; wakeup-source;