From patchwork Fri Oct 18 12:03:05 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Hsin-Te Yuan X-Patchwork-Id: 13841691 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 4F56FD2FFF8 for ; Fri, 18 Oct 2024 12:07:44 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Cc:To:In-Reply-To:References :Message-Id:Content-Transfer-Encoding:Content-Type:MIME-Version:Subject:Date: From:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=pKGlVab4i7DHl/ffkFGpIlho3hvAo5V5WFM3UhTHe/o=; b=aS4dZET9/tHYA8jx4sfFl8FUi5 q+j8LLPGRS6w+I3IwlHDK/MrNtFmlZBelpOErKTiGTgfpmJ+8z2oMTlBk+mgHEz+NhnA53R2yyumc FUrQnGlOC/jj1i15jK6sTjB0+KUNBoMbpNzF8S/8UCTWwHIs2EJmZS5ovVmYtMBJ2zJiJsAwiZTo6 qpInF8t4LqFBXR2AVxggzoliZlPzIKrYXTVtCDuzPEiLv4fjkHvGOMAKMlb5736UGD+l1eWdnfvWr 1HkcnZa6MnGxrovex3RWOwqPo67zvTD14HDSg/nRFdJQghEYOvcYB6QpHSjv5artgGbtGfTMlCR10 jrO3nzDw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98 #2 (Red Hat Linux)) id 1t1llf-00000000iMq-0FlJ; Fri, 18 Oct 2024 12:07:43 +0000 Received: from mail-pf1-x429.google.com ([2607:f8b0:4864:20::429]) by bombadil.infradead.org with esmtps (Exim 4.98 #2 (Red Hat Linux)) id 1t1lhM-00000000hfP-3Qvc for linux-mediatek@lists.infradead.org; Fri, 18 Oct 2024 12:03:18 +0000 Received: by mail-pf1-x429.google.com with SMTP id d2e1a72fcca58-71e625b00bcso1534393b3a.3 for ; Fri, 18 Oct 2024 05:03:16 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; t=1729252996; x=1729857796; darn=lists.infradead.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=pKGlVab4i7DHl/ffkFGpIlho3hvAo5V5WFM3UhTHe/o=; b=ME2BQX6Yy8IBOzbu3UzPahUkvvw76lW64XYZuePbO3hg0TvWamaU4sniopUvWX8WTl xrlCww9YUu3+gajkoPeN1qWyy5IfsGe26oArVHc2xVcmaPZaDaxPgV8Fe28cjQoGaFNi BgbHAXFmEP0Df1BfDhYMwb4iJPQsVoOjlv/m4= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1729252996; x=1729857796; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=pKGlVab4i7DHl/ffkFGpIlho3hvAo5V5WFM3UhTHe/o=; b=Y13FZtpea9o5BZ+/D1OTJ9q124hoGj4gOHSivPbTsItkXgBGMJMmmak9geftlOfNJS aJz56n429ZnRSonKPHd4oro/HaxBCAdtP6wKmAgH3dJ8CECz195DVWWJaKCeTrHiS/4f v0ds+zMQmpFWbUI3yaie4vKDQMYcGd5G9hK1KcAjJTc9jPtjmltNjj9BptlC6CafaenV WOPJrhEJ63GSXD2JjsE0OzznI63o719wVb86WZBoEde4a/FzR3G8uRj0eNrBVNR2L8Ju ezK35r0XKbUNNJT2p9hKjdO/4aVq+GFEdQvEM5b2X4XMHNU9nsf1tgaSawYgGRVzaMwi gXbw== X-Forwarded-Encrypted: i=1; AJvYcCUFGBYOM+lIPUdXmwKqOPQu9Ox6c3PWDTfoTaHROGTDCA49WiaaiGIXloGnFcZsTAR64LVE79lwSVfosS1rSQ==@lists.infradead.org X-Gm-Message-State: AOJu0Yy3Q3falVf4sbAazW7C822kqIRy+mseUAN5rNsd4PlpWmZjoxGe A90QPmmwzO5V7DeESHam64c/uG7EjvUYShXM6GSssbogZyx/YdiYzTv7jI6uvg== X-Google-Smtp-Source: AGHT+IEMoyV6BqxdhGrDIRhbQDdZfec7fHmtNYn4YW1cd/EZHjfSnxgL4d4cV9mzhYNOQP54WR2zaw== X-Received: by 2002:a05:6a00:cc4:b0:71e:3b8:666b with SMTP id d2e1a72fcca58-71ea325b489mr2897763b3a.15.1729252995698; Fri, 18 Oct 2024 05:03:15 -0700 (PDT) Received: from yuanhsinte.c.googlers.com (176.220.194.35.bc.googleusercontent.com. [35.194.220.176]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-71ea34ae672sm1274014b3a.204.2024.10.18.05.03.13 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 18 Oct 2024 05:03:15 -0700 (PDT) From: Hsin-Te Yuan Date: Fri, 18 Oct 2024 12:03:05 +0000 Subject: [PATCH 2/2] arm64: dts: mediatek: mt8183: Switch to Elan touchscreen driver MIME-Version: 1.0 Message-Id: <20241018-post-reset-v1-2-5aadb7550037@chromium.org> References: <20241018-post-reset-v1-0-5aadb7550037@chromium.org> In-Reply-To: <20241018-post-reset-v1-0-5aadb7550037@chromium.org> To: Rob Herring , Krzysztof Kozlowski , Conor Dooley , Matthias Brugger , AngeloGioacchino Del Regno , Enric Balletbo i Serra , Hsin-Yi Wang , Benjamin Tissoires , Hans de Goede Cc: devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org, Hsin-Te Yuan X-Mailer: b4 0.15-dev-7be4f X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20241018_050316_871010_DC7C57CD X-CRM114-Status: GOOD ( 11.00 ) X-BeenThere: linux-mediatek@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "Linux-mediatek" Errors-To: linux-mediatek-bounces+linux-mediatek=archiver.kernel.org@lists.infradead.org After commit 2be404486c05 ("HID: i2c-hid-of: Add reset GPIO support to i2c-hid-of"), the i2c-hid-of driver used by some mt8183 devices resets the touchscreen without having enough post-reset delay. This makes those touchscreen fail to get probed. Switch to Elan touchscreen driver, which has enough post-reset delay. Fixes: 2be404486c05 ("HID: i2c-hid-of: Add reset GPIO support to i2c-hid-of") Signed-off-by: Hsin-Te Yuan --- arch/arm64/boot/dts/mediatek/mt8183-kukui-jacuzzi-damu.dts | 10 +++------- .../boot/dts/mediatek/mt8183-kukui-jacuzzi-fennel-sku1.dts | 9 ++------- .../boot/dts/mediatek/mt8183-kukui-jacuzzi-fennel-sku6.dts | 9 ++------- .../boot/dts/mediatek/mt8183-kukui-jacuzzi-fennel-sku7.dts | 9 ++------- 4 files changed, 9 insertions(+), 28 deletions(-) diff --git a/arch/arm64/boot/dts/mediatek/mt8183-kukui-jacuzzi-damu.dts b/arch/arm64/boot/dts/mediatek/mt8183-kukui-jacuzzi-damu.dts index ebe6e161354c414d91859494ec9295db75a3baf9..b98a3530511e576347a4ed291d37d45dd42fec97 100644 --- a/arch/arm64/boot/dts/mediatek/mt8183-kukui-jacuzzi-damu.dts +++ b/arch/arm64/boot/dts/mediatek/mt8183-kukui-jacuzzi-damu.dts @@ -14,14 +14,10 @@ / { }; &touchscreen { - status = "okay"; + compatible = "elan,ekth6a12nay"; - compatible = "hid-over-i2c"; - reg = <0x10>; - interrupts-extended = <&pio 155 IRQ_TYPE_LEVEL_LOW>; - - post-power-on-delay-ms = <10>; - hid-descr-addr = <0x0001>; + vcc33-supply = <&pp3300_alw>; + vccio-supply = <&pp1800_alw>; }; &qca_wifi { diff --git a/arch/arm64/boot/dts/mediatek/mt8183-kukui-jacuzzi-fennel-sku1.dts b/arch/arm64/boot/dts/mediatek/mt8183-kukui-jacuzzi-fennel-sku1.dts index 2dc64cc539f815b9848b8243e5b487f22d605a6d..9fb329626a82034e44fb5fbd2d0ad9675c0a5afa 100644 --- a/arch/arm64/boot/dts/mediatek/mt8183-kukui-jacuzzi-fennel-sku1.dts +++ b/arch/arm64/boot/dts/mediatek/mt8183-kukui-jacuzzi-fennel-sku1.dts @@ -27,14 +27,9 @@ &cros_ec_pwm { }; &touchscreen { - status = "okay"; - - compatible = "hid-over-i2c"; - reg = <0x10>; - interrupts-extended = <&pio 155 IRQ_TYPE_LEVEL_LOW>; + compatible = "elan,ekth6a12nay"; - post-power-on-delay-ms = <10>; - hid-descr-addr = <0x0001>; + vcc33-supply = <&pp3300_alw>; }; &qca_wifi { diff --git a/arch/arm64/boot/dts/mediatek/mt8183-kukui-jacuzzi-fennel-sku6.dts b/arch/arm64/boot/dts/mediatek/mt8183-kukui-jacuzzi-fennel-sku6.dts index 53e996f9c605dc36df03d4b0051a91e19fefb38d..6d547361fc4f9d2ab1f9b048af443495c9bed323 100644 --- a/arch/arm64/boot/dts/mediatek/mt8183-kukui-jacuzzi-fennel-sku6.dts +++ b/arch/arm64/boot/dts/mediatek/mt8183-kukui-jacuzzi-fennel-sku6.dts @@ -14,14 +14,9 @@ / { }; &touchscreen { - status = "okay"; + compatible = "elan,ekth6a12nay"; - compatible = "hid-over-i2c"; - reg = <0x10>; - interrupts-extended = <&pio 155 IRQ_TYPE_LEVEL_LOW>; - - post-power-on-delay-ms = <10>; - hid-descr-addr = <0x0001>; + vcc33-supply = <&pp3300_alw>; }; diff --git a/arch/arm64/boot/dts/mediatek/mt8183-kukui-jacuzzi-fennel-sku7.dts b/arch/arm64/boot/dts/mediatek/mt8183-kukui-jacuzzi-fennel-sku7.dts index d7db621383c6b823af08ca07e0794758d062e211..39ab09ce28aa2ed4335d5279a965f23a8458688e 100644 --- a/arch/arm64/boot/dts/mediatek/mt8183-kukui-jacuzzi-fennel-sku7.dts +++ b/arch/arm64/boot/dts/mediatek/mt8183-kukui-jacuzzi-fennel-sku7.dts @@ -14,14 +14,9 @@ / { }; &touchscreen { - status = "okay"; + compatible = "elan,ekth6a12nay"; - compatible = "hid-over-i2c"; - reg = <0x10>; - interrupts-extended = <&pio 155 IRQ_TYPE_LEVEL_LOW>; - - post-power-on-delay-ms = <10>; - hid-descr-addr = <0x0001>; + vcc33-supply = <&pp3300_alw>; };