| Message ID | 20241109105029.52748-1-linux@fw-web.de (mailing list archive) |
|---|---|
| State | New |
| Headers | show |
| Series | dt-bindings: spi: add compatibles for mt7988 | expand |
On Sat, Nov 09, 2024 at 11:50:28AM +0100, Frank Wunderlich wrote: > From: Frank Wunderlich <frank-w@public-files.de> > > MT7988 has 2 different spi controllers. Add their compatibles. > > Signed-off-by: Frank Wunderlich <frank-w@public-files.de> Acked-by: Conor Dooley <conor.dooley@microchip.com>
On Sat, Nov 09, 2024 at 11:50:28AM +0100, Frank Wunderlich wrote: > From: Frank Wunderlich <frank-w@public-files.de> > > MT7988 has 2 different spi controllers. Add their compatibles. > > Signed-off-by: Frank Wunderlich <frank-w@public-files.de> > --- > Documentation/devicetree/bindings/spi/mediatek,spi-mt65xx.yaml | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/Documentation/devicetree/bindings/spi/mediatek,spi-mt65xx.yaml b/Documentation/devicetree/bindings/spi/mediatek,spi-mt65xx.yaml > index e1f5bfa4433c..ed17815263a8 100644 > --- a/Documentation/devicetree/bindings/spi/mediatek,spi-mt65xx.yaml > +++ b/Documentation/devicetree/bindings/spi/mediatek,spi-mt65xx.yaml > @@ -35,6 +35,8 @@ properties: > - enum: > - mediatek,mt7981-spi-ipm > - mediatek,mt7986-spi-ipm > + - mediatek,mt7988-spi-quad > + - mediatek,mt7988-spi-single > - mediatek,mt8188-spi-ipm > - const: mediatek,spi-ipm Does the fallback make sense for both? Is there some common subset of functionality where they are the same? Rob
> Gesendet: Montag, 11. November 2024 um 21:38 > Von: "Rob Herring" <robh@kernel.org> > An: "Frank Wunderlich" <linux@fw-web.de> > CC: "Mark Brown" <broonie@kernel.org>, "Krzysztof Kozlowski" <krzk+dt@kernel.org>, "Conor Dooley" <conor+dt@kernel.org>, "Matthias Brugger" <matthias.bgg@gmail.com>, "AngeloGioacchino Del Regno" <angelogioacchino.delregno@collabora.com>, "Frank Wunderlich" <frank-w@public-files.de>, "Leilk Liu" <leilk.liu@mediatek.com>, linux-spi@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org > Betreff: Re: [PATCH] dt-bindings: spi: add compatibles for mt7988 > > On Sat, Nov 09, 2024 at 11:50:28AM +0100, Frank Wunderlich wrote: > > From: Frank Wunderlich <frank-w@public-files.de> > > > > MT7988 has 2 different spi controllers. Add their compatibles. > > > > Signed-off-by: Frank Wunderlich <frank-w@public-files.de> > > --- > > Documentation/devicetree/bindings/spi/mediatek,spi-mt65xx.yaml | 2 ++ > > 1 file changed, 2 insertions(+) > > > > diff --git a/Documentation/devicetree/bindings/spi/mediatek,spi-mt65xx.yaml b/Documentation/devicetree/bindings/spi/mediatek,spi-mt65xx.yaml > > index e1f5bfa4433c..ed17815263a8 100644 > > --- a/Documentation/devicetree/bindings/spi/mediatek,spi-mt65xx.yaml > > +++ b/Documentation/devicetree/bindings/spi/mediatek,spi-mt65xx.yaml > > @@ -35,6 +35,8 @@ properties: > > - enum: > > - mediatek,mt7981-spi-ipm > > - mediatek,mt7986-spi-ipm > > + - mediatek,mt7988-spi-quad > > + - mediatek,mt7988-spi-single > > - mediatek,mt8188-spi-ipm > > - const: mediatek,spi-ipm > > Does the fallback make sense for both? Is there some common subset of > functionality where they are the same? currently they work only with the fallback compatible, but we see in SDK that there are 2 types...in SDK non-soc specific compatibles are used which was rejected last time. > Rob > </frank-w@public-files.de></frank-w@public-files.de></leilk.liu@mediatek.com></frank-w@public-files.de></angelogioacchino.delregno@collabora.com></matthias.bgg@gmail.com></conor+dt@kernel.org></krzk+dt@kernel.org></broonie@kernel.org></linux@fw-web.de></robh@kernel.org>
diff --git a/Documentation/devicetree/bindings/spi/mediatek,spi-mt65xx.yaml b/Documentation/devicetree/bindings/spi/mediatek,spi-mt65xx.yaml index e1f5bfa4433c..ed17815263a8 100644 --- a/Documentation/devicetree/bindings/spi/mediatek,spi-mt65xx.yaml +++ b/Documentation/devicetree/bindings/spi/mediatek,spi-mt65xx.yaml @@ -35,6 +35,8 @@ properties: - enum: - mediatek,mt7981-spi-ipm - mediatek,mt7986-spi-ipm + - mediatek,mt7988-spi-quad + - mediatek,mt7988-spi-single - mediatek,mt8188-spi-ipm - const: mediatek,spi-ipm - items: