| Message ID | 20241122104938.1437925-2-wmacek@chromium.org (mailing list archive) |
|---|---|
| State | New |
| Headers | show |
| Series | Add Starmie Chromebooks | expand |
On Fri, Nov 22, 2024 at 10:49:37AM +0000, Wojciech Macek wrote: > Add an entry for the MT8186 based Starmie Chromebooks, also known as the > ASUS Chromebook Enterprise CM30 Detachable (CM3001). The device is > a tablet style chromebook. > > Signed-off-by: Wojciech Macek <wmacek@chromium.org> This was absolutely never tested. You obiovusly miss some items or enum, but main point is that it neither looks like existing code nor it was tested BY YOU prior to sending. Best regards, Krzysztof
diff --git a/Documentation/devicetree/bindings/arm/mediatek.yaml b/Documentation/devicetree/bindings/arm/mediatek.yaml index 1d4bb50fcd8d9..df38bcf7c1b61 100644 --- a/Documentation/devicetree/bindings/arm/mediatek.yaml +++ b/Documentation/devicetree/bindings/arm/mediatek.yaml @@ -263,6 +263,14 @@ properties: - const: google,steelix-sku196608 - const: google,steelix - const: mediatek,mt8186 + - description: Google Starmie (ASUS Chromebook Enterprise CM30 Detachable) + - const: google,starmie-sku0 + - const: google,starmie-sku1 + - const: google,starmie-sku2 + - const: google,starmie-sku3 + - const: google,starmie-sku4 + - const: google,starmie + - const: mediatek,mt8186 - description: Google Steelix (Lenovo 300e Yoga Chromebook Gen 4) items: - enum:
Add an entry for the MT8186 based Starmie Chromebooks, also known as the ASUS Chromebook Enterprise CM30 Detachable (CM3001). The device is a tablet style chromebook. Signed-off-by: Wojciech Macek <wmacek@chromium.org> --- Documentation/devicetree/bindings/arm/mediatek.yaml | 8 ++++++++ 1 file changed, 8 insertions(+)