| Message ID | 20241130135813.895628-2-u.kleine-koenig@baylibre.com (mailing list archive) |
|---|---|
| State | New |
| Headers | show |
| Series | devfreq: Switch back to struct platform_driver::remove() | expand |
Il 30/11/24 14:58, Uwe Kleine-König ha scritto: > After commit 0edb555a65d1 ("platform: Make platform_driver::remove() > return void") .remove() is (again) the right callback to implement for > platform drivers. > > Convert all platform drivers below drivers/devfreq to use .remove(), > with the eventual goal to drop struct platform_driver::remove_new(). As > .remove() and .remove_new() have the same prototypes, conversion is done > by just changing the structure member name in the driver initializer. > > While touching these drivers, make the alignment of the touched > initializers consistent. > > Signed-off-by: Uwe Kleine-König <u.kleine-koenig@baylibre.com> For MediaTek Reviewed-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>
Hello, On Sat, Nov 30, 2024 at 02:58:11PM +0100, Uwe Kleine-König wrote: > After commit 0edb555a65d1 ("platform: Make platform_driver::remove() > return void") .remove() is (again) the right callback to implement for > platform drivers. > > Convert all platform drivers below drivers/devfreq to use .remove(), > with the eventual goal to drop struct platform_driver::remove_new(). As > .remove() and .remove_new() have the same prototypes, conversion is done > by just changing the structure member name in the driver initializer. > > While touching these drivers, make the alignment of the touched > initializers consistent. > > Signed-off-by: Uwe Kleine-König <u.kleine-koenig@baylibre.com> Note this patch is obsoleted by https://git.kernel.org/linus/e70140ba0d2b1a30467d4af6bcfe761327b9ec95 . Best regards Uwe
>After commit 0edb555a65d1 ("platform: Make platform_driver::remove() >return void") .remove() is (again) the right callback to implement for >platform drivers. > >Convert all platform drivers below drivers/devfreq to use .remove(), >with the eventual goal to drop struct platform_driver::remove_new(). As >.remove() and .remove_new() have the same prototypes, conversion is done >by just changing the structure member name in the driver initializer. > >While touching these drivers, make the alignment of the touched >initializers consistent. > >Signed-off-by: Uwe Kleine-König <u.kleine-koenig@baylibre.com> Acked-by: MyungJoo Ham <myungjoo.ham@samsung.com> Cheers, MyungJoo >--- >Hello, > >this is based on Friday's next, feel free to drop changes that result in >a conflict when you come around to apply this. I'll care for the fallout >at a later time then. (Having said that, if you use b4 am -3 and git am >-3, there should be hardly any conflict.) > >This is merge window material. > >Best regards >Uwe > > drivers/devfreq/event/exynos-nocp.c | 6 +++--- > drivers/devfreq/event/exynos-ppmu.c | 6 +++--- > drivers/devfreq/mtk-cci-devfreq.c | 4 ++-- > drivers/devfreq/rk3399_dmc.c | 8 ++++---- > drivers/devfreq/sun8i-a33-mbus.c | 2 +- > 5 files changed, 13 insertions(+), 13 deletions(-) >
diff --git a/drivers/devfreq/event/exynos-nocp.c b/drivers/devfreq/event/exynos-nocp.c index 5edc522f715c..9480a92fc265 100644 --- a/drivers/devfreq/event/exynos-nocp.c +++ b/drivers/devfreq/event/exynos-nocp.c @@ -283,10 +283,10 @@ static void exynos_nocp_remove(struct platform_device *pdev) } static struct platform_driver exynos_nocp_driver = { - .probe = exynos_nocp_probe, - .remove_new = exynos_nocp_remove, + .probe = exynos_nocp_probe, + .remove = exynos_nocp_remove, .driver = { - .name = "exynos-nocp", + .name = "exynos-nocp", .of_match_table = exynos_nocp_id_match, }, }; diff --git a/drivers/devfreq/event/exynos-ppmu.c b/drivers/devfreq/event/exynos-ppmu.c index 7002df20a49e..a738e6145612 100644 --- a/drivers/devfreq/event/exynos-ppmu.c +++ b/drivers/devfreq/event/exynos-ppmu.c @@ -700,10 +700,10 @@ static void exynos_ppmu_remove(struct platform_device *pdev) } static struct platform_driver exynos_ppmu_driver = { - .probe = exynos_ppmu_probe, - .remove_new = exynos_ppmu_remove, + .probe = exynos_ppmu_probe, + .remove = exynos_ppmu_remove, .driver = { - .name = "exynos-ppmu", + .name = "exynos-ppmu", .of_match_table = exynos_ppmu_id_match, }, }; diff --git a/drivers/devfreq/mtk-cci-devfreq.c b/drivers/devfreq/mtk-cci-devfreq.c index 7ad5225b0381..3938878b2279 100644 --- a/drivers/devfreq/mtk-cci-devfreq.c +++ b/drivers/devfreq/mtk-cci-devfreq.c @@ -429,8 +429,8 @@ static const struct of_device_id mtk_ccifreq_machines[] = { MODULE_DEVICE_TABLE(of, mtk_ccifreq_machines); static struct platform_driver mtk_ccifreq_platdrv = { - .probe = mtk_ccifreq_probe, - .remove_new = mtk_ccifreq_remove, + .probe = mtk_ccifreq_probe, + .remove = mtk_ccifreq_remove, .driver = { .name = "mtk-ccifreq", .of_match_table = mtk_ccifreq_machines, diff --git a/drivers/devfreq/rk3399_dmc.c b/drivers/devfreq/rk3399_dmc.c index d405cee92c25..158e4bbd08cc 100644 --- a/drivers/devfreq/rk3399_dmc.c +++ b/drivers/devfreq/rk3399_dmc.c @@ -473,11 +473,11 @@ static const struct of_device_id rk3399dmc_devfreq_of_match[] = { MODULE_DEVICE_TABLE(of, rk3399dmc_devfreq_of_match); static struct platform_driver rk3399_dmcfreq_driver = { - .probe = rk3399_dmcfreq_probe, - .remove_new = rk3399_dmcfreq_remove, + .probe = rk3399_dmcfreq_probe, + .remove = rk3399_dmcfreq_remove, .driver = { - .name = "rk3399-dmc-freq", - .pm = &rk3399_dmcfreq_pm, + .name = "rk3399-dmc-freq", + .pm = &rk3399_dmcfreq_pm, .of_match_table = rk3399dmc_devfreq_of_match, }, }; diff --git a/drivers/devfreq/sun8i-a33-mbus.c b/drivers/devfreq/sun8i-a33-mbus.c index bcf654f4ff96..a405bab1a63e 100644 --- a/drivers/devfreq/sun8i-a33-mbus.c +++ b/drivers/devfreq/sun8i-a33-mbus.c @@ -495,7 +495,7 @@ static SIMPLE_DEV_PM_OPS(sun8i_a33_mbus_pm_ops, static struct platform_driver sun8i_a33_mbus_driver = { .probe = sun8i_a33_mbus_probe, - .remove_new = sun8i_a33_mbus_remove, + .remove = sun8i_a33_mbus_remove, .driver = { .name = "sun8i-a33-mbus", .of_match_table = sun8i_a33_mbus_of_match,
After commit 0edb555a65d1 ("platform: Make platform_driver::remove() return void") .remove() is (again) the right callback to implement for platform drivers. Convert all platform drivers below drivers/devfreq to use .remove(), with the eventual goal to drop struct platform_driver::remove_new(). As .remove() and .remove_new() have the same prototypes, conversion is done by just changing the structure member name in the driver initializer. While touching these drivers, make the alignment of the touched initializers consistent. Signed-off-by: Uwe Kleine-König <u.kleine-koenig@baylibre.com> --- Hello, this is based on Friday's next, feel free to drop changes that result in a conflict when you come around to apply this. I'll care for the fallout at a later time then. (Having said that, if you use b4 am -3 and git am -3, there should be hardly any conflict.) This is merge window material. Best regards Uwe drivers/devfreq/event/exynos-nocp.c | 6 +++--- drivers/devfreq/event/exynos-ppmu.c | 6 +++--- drivers/devfreq/mtk-cci-devfreq.c | 4 ++-- drivers/devfreq/rk3399_dmc.c | 8 ++++---- drivers/devfreq/sun8i-a33-mbus.c | 2 +- 5 files changed, 13 insertions(+), 13 deletions(-) base-commit: f486c8aa16b8172f63bddc70116a0c897a7f3f02