| Message ID | 20241202122602.30734-18-linux@fw-web.de (mailing list archive) |
|---|---|
| State | New |
| Headers | show |
| Series | continue mt7988 devicetree work | expand |
Il 02/12/24 13:25, Frank Wunderlich ha scritto: > From: Frank Wunderlich <frank-w@public-files.de> > > Enable front-usb on Bananapi R4 board. > > Signed-off-by: Frank Wunderlich <frank-w@public-files.de> Reviewed-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>
Am 2024-12-03 10:40, schrieb AngeloGioacchino Del Regno: > Il 02/12/24 13:25, Frank Wunderlich ha scritto: >> From: Frank Wunderlich <frank-w@public-files.de> >> >> Enable front-usb on Bananapi R4 board. >> >> Signed-off-by: Frank Wunderlich <frank-w@public-files.de> > > Reviewed-by: AngeloGioacchino Del Regno > <angelogioacchino.delregno@collabora.com> thanks, but i noticed, that the controllers in dtsi are not disabled like in my final dtsi. Imho controllers should be disabled by default and only enabled when used on board. Should i add disabling in this patch too? and i noticed that usb phys have to be added to get working usb. Here for ssusb1 a tphy is used where i now have prepared patch so i can add it in next version (reusing mt7986 compatible). ssusb0 uses a different phy (xsphy) which needs a bit more work before (driver and binding change). regards Frank
diff --git a/arch/arm64/boot/dts/mediatek/mt7988a-bananapi-bpi-r4.dts b/arch/arm64/boot/dts/mediatek/mt7988a-bananapi-bpi-r4.dts index 9ceefc990000..12b45b18955b 100644 --- a/arch/arm64/boot/dts/mediatek/mt7988a-bananapi-bpi-r4.dts +++ b/arch/arm64/boot/dts/mediatek/mt7988a-bananapi-bpi-r4.dts @@ -373,6 +373,10 @@ &serial0 { status = "okay"; }; +&ssusb1 { + status = "okay"; +}; + &watchdog { status = "okay"; }; diff --git a/arch/arm64/boot/dts/mediatek/mt7988a.dtsi b/arch/arm64/boot/dts/mediatek/mt7988a.dtsi index 93c21a5248fa..2be84acac06a 100644 --- a/arch/arm64/boot/dts/mediatek/mt7988a.dtsi +++ b/arch/arm64/boot/dts/mediatek/mt7988a.dtsi @@ -336,7 +336,7 @@ usb@11190000 { clock-names = "sys_ck", "ref_ck", "mcu_ck", "dma_ck", "xhci_ck"; }; - usb@11200000 { + ssusb1: usb@11200000 { compatible = "mediatek,mt7988-xhci", "mediatek,mtk-xhci"; reg = <0 0x11200000 0 0x2e00>, <0 0x11203e00 0 0x0100>;