From patchwork Tue Feb 11 11:33:59 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: AngeloGioacchino Del Regno X-Patchwork-Id: 13969686 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 33C9CC0219B for ; Tue, 11 Feb 2025 12:21:10 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Content-Transfer-Encoding: MIME-Version:References:In-Reply-To:Message-ID:Date:Subject:Cc:To:From: Reply-To:Content-Type:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=vV6CgEb0TdbwoWSkNLFm82rJ2ziDufUTwUUl+RdTNGc=; b=XxQJlVXnkSoL2ksZTjXyYICnCS OXjCxzlQ/L2QZVtY71NUIexJlKz8rdOeiuXWnlIAwN684TDsT0EmKX8HCPAvEzYGoEmEW5mexTuja u4C+L60u9+thjEPQvMGOTi0fW90Zarqo7MR9cEaKSSXfBewqyg2q2/Yi4sPxSpRyp2pYPgmEgIMXe 9ujuIeZ/IJDVPq+JmMCZF1nkWiC9xzM8oJD+gqsiOWLmT//XmIy7gGy5y6+GyzdSnlLQ/+l1FPGeE CTWbPAoG3V0TMNiFg9Lb06JKrcyAvtecJW96XvkuMmjOFLsBBQFz6c1Lc8jRgL80+Ib8WxhBSujXn /xeKwYHA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98 #2 (Red Hat Linux)) id 1thpGG-00000003kg5-3qMk; Tue, 11 Feb 2025 12:21:08 +0000 Received: from bali.collaboradmins.com ([148.251.105.195]) by bombadil.infradead.org with esmtps (Exim 4.98 #2 (Red Hat Linux)) id 1thoXl-00000003Z8m-0wt7; Tue, 11 Feb 2025 11:35:10 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=collabora.com; s=mail; t=1739273707; bh=zsvtpwR8ZbYLRu4Z9EpZnoP0yLsKeHqoWYykVxwC1Xo=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=CWpAR6u0lR1kGILXzovPs19wFZzcdynhJ7+YYnCv8f5FErvPGQ8DcZDYdcLBLxO/J 2D3k6rE57WN07Io0pEU/8O5uJ20XSyKddK04M1HRnl8O8vcafAyUXuwqe5RZAQSprf Qz+b856rCXMXmdBxeHFWYHwd63FRuP4bMYtBNMfRVdIJ1ocTlkYKK1BoFxk3sIqDyP WgscO4buqxxnFWlkRUGv+rpd0XGPmImNx6j0FrEIZnzYCkgUmjD34msdwoKe+fvzOc gSatQDq7ZeliIg0Gcgxt7ffY1r1XEih4EIQUfLb58uR1a8xU7slJQhDJOy7eZ9GvL3 f2A4D5Z+T+woA== Received: from IcarusMOD.eternityproject.eu (2-237-20-237.ip236.fastwebnet.it [2.237.20.237]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) (Authenticated sender: kholk11) by bali.collaboradmins.com (Postfix) with ESMTPSA id A219E17E1545; Tue, 11 Feb 2025 12:35:06 +0100 (CET) From: AngeloGioacchino Del Regno To: chunkuang.hu@kernel.org Cc: p.zabel@pengutronix.de, airlied@gmail.com, simona@ffwll.ch, maarten.lankhorst@linux.intel.com, mripard@kernel.org, tzimmermann@suse.de, robh@kernel.org, krzk+dt@kernel.org, conor+dt@kernel.org, matthias.bgg@gmail.com, angelogioacchino.delregno@collabora.com, ck.hu@mediatek.com, jitao.shi@mediatek.com, jie.qiu@mediatek.com, junzhi.zhao@mediatek.com, dri-devel@lists.freedesktop.org, linux-mediatek@lists.infradead.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, kernel@collabora.com, dmitry.baryshkov@linaro.org, lewis.liao@mediatek.com, ives.chenjh@mediatek.com, tommyyl.chen@mediatek.com, jason-jh.lin@mediatek.com Subject: [PATCH v6 32/42] drm/mediatek: mtk_hdmi: Cleanup function mtk_hdmi_resume() Date: Tue, 11 Feb 2025 12:33:59 +0100 Message-ID: <20250211113409.1517534-33-angelogioacchino.delregno@collabora.com> X-Mailer: git-send-email 2.48.1 In-Reply-To: <20250211113409.1517534-1-angelogioacchino.delregno@collabora.com> References: <20250211113409.1517534-1-angelogioacchino.delregno@collabora.com> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20250211_033509_405210_4E02E648 X-CRM114-Status: UNSURE ( 9.69 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-mediatek@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "Linux-mediatek" Errors-To: linux-mediatek-bounces+linux-mediatek=archiver.kernel.org@lists.infradead.org Remove the error print in case of mtk_hdmi_clk_enable_audio() failures: since the APIs will already print on their own, having one in there is redundant. Signed-off-by: AngeloGioacchino Del Regno Reviewed-by: CK Hu --- drivers/gpu/drm/mediatek/mtk_hdmi.c | 9 +-------- 1 file changed, 1 insertion(+), 8 deletions(-) diff --git a/drivers/gpu/drm/mediatek/mtk_hdmi.c b/drivers/gpu/drm/mediatek/mtk_hdmi.c index 53c28737ac2a..8f31363c5522 100644 --- a/drivers/gpu/drm/mediatek/mtk_hdmi.c +++ b/drivers/gpu/drm/mediatek/mtk_hdmi.c @@ -1704,15 +1704,8 @@ static __maybe_unused int mtk_hdmi_suspend(struct device *dev) static __maybe_unused int mtk_hdmi_resume(struct device *dev) { struct mtk_hdmi *hdmi = dev_get_drvdata(dev); - int ret = 0; - ret = mtk_hdmi_clk_enable_audio(hdmi); - if (ret) { - dev_err(dev, "hdmi resume failed!\n"); - return ret; - } - - return 0; + return mtk_hdmi_clk_enable_audio(hdmi); } static SIMPLE_DEV_PM_OPS(mtk_hdmi_pm_ops, mtk_hdmi_suspend, mtk_hdmi_resume);