| Message ID | 20250212163359.2407327-9-andriy.shevchenko@linux.intel.com (mailing list archive) |
|---|---|
| State | New |
| Headers | show |
| Series | i2c: busses: Introduce and use i2c_10bit_addr_from_msg() | expand |
> From: Andy Shevchenko <andriy.shevchenko@linux.intel.com> > Sent: 12 February 2025 16:33 > Subject: [PATCH v1 8/8] i2c: rzv2m: Use i2c_10bit_addr_from_msg() helper > > Use i2c_10bit_addr_from_msg() helper instead of local copy. > No functional change intended. > > Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com> Reviewed-by: Fabrizio Castro <fabrizio.castro.jz@renesas.com> > --- > drivers/i2c/busses/i2c-rzv2m.c | 10 +++------- > 1 file changed, 3 insertions(+), 7 deletions(-) > > diff --git a/drivers/i2c/busses/i2c-rzv2m.c b/drivers/i2c/busses/i2c-rzv2m.c > index 02b76e24a476..55c5ce3b0f97 100644 > --- a/drivers/i2c/busses/i2c-rzv2m.c > +++ b/drivers/i2c/busses/i2c-rzv2m.c > @@ -287,13 +287,9 @@ static int rzv2m_i2c_send_address(struct rzv2m_i2c_priv *priv, > int ret; > > if (msg->flags & I2C_M_TEN) { > - /* > - * 10-bit address > - * addr_1: 5'b11110 | addr[9:8] | (R/nW) > - * addr_2: addr[7:0] > - */ > - addr = 0xf0 | ((msg->addr & GENMASK(9, 8)) >> 7); > - addr |= !!(msg->flags & I2C_M_RD); > + /* 10-bit address */ > + addr = i2c_10bit_addr_from_msg(msg); > + > /* Send 1st address(extend code) */ > ret = rzv2m_i2c_write_with_ack(priv, addr); > if (ret) > -- > 2.45.1.3035.g276e886db78b
diff --git a/drivers/i2c/busses/i2c-rzv2m.c b/drivers/i2c/busses/i2c-rzv2m.c index 02b76e24a476..55c5ce3b0f97 100644 --- a/drivers/i2c/busses/i2c-rzv2m.c +++ b/drivers/i2c/busses/i2c-rzv2m.c @@ -287,13 +287,9 @@ static int rzv2m_i2c_send_address(struct rzv2m_i2c_priv *priv, int ret; if (msg->flags & I2C_M_TEN) { - /* - * 10-bit address - * addr_1: 5'b11110 | addr[9:8] | (R/nW) - * addr_2: addr[7:0] - */ - addr = 0xf0 | ((msg->addr & GENMASK(9, 8)) >> 7); - addr |= !!(msg->flags & I2C_M_RD); + /* 10-bit address */ + addr = i2c_10bit_addr_from_msg(msg); + /* Send 1st address(extend code) */ ret = rzv2m_i2c_write_with_ack(priv, addr); if (ret)
Use i2c_10bit_addr_from_msg() helper instead of local copy. No functional change intended. Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com> --- drivers/i2c/busses/i2c-rzv2m.c | 10 +++------- 1 file changed, 3 insertions(+), 7 deletions(-)