diff mbox series

[v1] arm64: defconfig: mediatek: enable PHY drivers

Message ID 20250311061703.16850-1-vignesh.raman@collabora.com (mailing list archive)
State New
Headers show
Series [v1] arm64: defconfig: mediatek: enable PHY drivers | expand

Commit Message

Vignesh Raman March 11, 2025, 6:16 a.m. UTC
The mediatek display driver fails to probe on mt8173 and mt8183 in
v6.14-rc4, with the following errors:

mt8173:
platform 1401b000.dsi: deferred probe pending: mtk-dsi: Failed to get hs clock
platform 14025000.hdmi: deferred probe pending: (reason unknown)
i2c 1-0008: deferred probe pending: (reason unknown)

mt8183:
platform 14014000.dsi: deferred probe pending: mtk-dsi: Failed to get hs clock
i2c 4-0058: deferred probe pending: anx7625: fail to find dsi host.

Enabling CONFIG_PHY_MTK_MIPI_DSI=y in drm-ci resolves this error,
but mt8173 still fails with,

[drm:mtk_dsi_host_attach] *ERROR* failed to add dsi_host component: -517
panel-simple-dp-aux aux-1-0008: DP AUX done_probing() can't defer
panel-simple-dp-aux aux-1-0008: probe with driver panel-simple-dp-aux failed with error -22

Enabling CONFIG_PHY_MTK_XSPHY=y and CONFIG_PHY_MTK_HDMI=y in drm-ci
resolves this issue for mt8173.

So enable these PHY configs for mediatek platforms.

Signed-off-by: Vignesh Raman <vignesh.raman@collabora.com>
---
 arch/arm64/configs/defconfig | 3 +++
 1 file changed, 3 insertions(+)

Comments

Krzysztof Kozlowski March 11, 2025, 7:24 a.m. UTC | #1
On 11/03/2025 07:16, Vignesh Raman wrote:
> The mediatek display driver fails to probe on mt8173 and mt8183 in
> v6.14-rc4, with the following errors:

Which boards?

> 
> mt8173:
> platform 1401b000.dsi: deferred probe pending: mtk-dsi: Failed to get hs clock
> platform 14025000.hdmi: deferred probe pending: (reason unknown)
> i2c 1-0008: deferred probe pending: (reason unknown)
> 
> mt8183:
> platform 14014000.dsi: deferred probe pending: mtk-dsi: Failed to get hs clock
> i2c 4-0058: deferred probe pending: anx7625: fail to find dsi host.
> 
> Enabling CONFIG_PHY_MTK_MIPI_DSI=y in drm-ci resolves this error,
> but mt8173 still fails with,
> 
> [drm:mtk_dsi_host_attach] *ERROR* failed to add dsi_host component: -517
> panel-simple-dp-aux aux-1-0008: DP AUX done_probing() can't defer
> panel-simple-dp-aux aux-1-0008: probe with driver panel-simple-dp-aux failed with error -22
> 
> Enabling CONFIG_PHY_MTK_XSPHY=y and CONFIG_PHY_MTK_HDMI=y in drm-ci
> resolves this issue for mt8173.
> 
> So enable these PHY configs for mediatek platforms.

Just say which boards need it for which functionality/features. Three
sentences are enough.

Best regards,
Krzysztof
Vignesh Raman March 11, 2025, 11:56 a.m. UTC | #2
Hi Krzysztof,

On 11/03/25 12:54, Krzysztof Kozlowski wrote:
> On 11/03/2025 07:16, Vignesh Raman wrote:
>> The mediatek display driver fails to probe on mt8173 and mt8183 in
>> v6.14-rc4, with the following errors:
> 
> Which boards?

These are the boards,
https://lava.pages.collabora.com/docs/boards/chromebooks/boards/hana/
https://lava.pages.collabora.com/docs/boards/chromebooks/boards/jacuzzi/

> 
>>
>> mt8173:
>> platform 1401b000.dsi: deferred probe pending: mtk-dsi: Failed to get hs clock
>> platform 14025000.hdmi: deferred probe pending: (reason unknown)
>> i2c 1-0008: deferred probe pending: (reason unknown)
>>
>> mt8183:
>> platform 14014000.dsi: deferred probe pending: mtk-dsi: Failed to get hs clock
>> i2c 4-0058: deferred probe pending: anx7625: fail to find dsi host.
>>
>> Enabling CONFIG_PHY_MTK_MIPI_DSI=y in drm-ci resolves this error,
>> but mt8173 still fails with,
>>
>> [drm:mtk_dsi_host_attach] *ERROR* failed to add dsi_host component: -517
>> panel-simple-dp-aux aux-1-0008: DP AUX done_probing() can't defer
>> panel-simple-dp-aux aux-1-0008: probe with driver panel-simple-dp-aux failed with error -22
>>
>> Enabling CONFIG_PHY_MTK_XSPHY=y and CONFIG_PHY_MTK_HDMI=y in drm-ci
>> resolves this issue for mt8173.
>>
>> So enable these PHY configs for mediatek platforms.
> 
> Just say which boards need it for which functionality/features. Three
> sentences are enough.

Sure, will update the commit message. Thanks.

Regards,
Vignesh

> 
> Best regards,
> Krzysztof
Nícolas F. R. A. Prado March 11, 2025, 7:45 p.m. UTC | #3
On Tue, Mar 11, 2025 at 05:26:37PM +0530, Vignesh Raman wrote:
> Hi Krzysztof,
> 
> On 11/03/25 12:54, Krzysztof Kozlowski wrote:
> > On 11/03/2025 07:16, Vignesh Raman wrote:
> > > The mediatek display driver fails to probe on mt8173 and mt8183 in
> > > v6.14-rc4, with the following errors:
> > 
> > Which boards?
> 
> These are the boards,
> https://lava.pages.collabora.com/docs/boards/chromebooks/boards/hana/
> https://lava.pages.collabora.com/docs/boards/chromebooks/boards/jacuzzi/

You can use the Devicetree name to identify them in a way that's meaningful for
the kernel:

mt8173-elm-hana
mt8183-kukui-jacuzzi-juniper-sku16

Thanks,
Nícolas
Vignesh Raman March 12, 2025, 3:37 a.m. UTC | #4
Hi Nícolas,

On 12/03/25 01:15, Nícolas F. R. A. Prado wrote:
> On Tue, Mar 11, 2025 at 05:26:37PM +0530, Vignesh Raman wrote:
>> Hi Krzysztof,
>>
>> On 11/03/25 12:54, Krzysztof Kozlowski wrote:
>>> On 11/03/2025 07:16, Vignesh Raman wrote:
>>>> The mediatek display driver fails to probe on mt8173 and mt8183 in
>>>> v6.14-rc4, with the following errors:
>>>
>>> Which boards?
>>
>> These are the boards,
>> https://lava.pages.collabora.com/docs/boards/chromebooks/boards/hana/
>> https://lava.pages.collabora.com/docs/boards/chromebooks/boards/jacuzzi/
> 
> You can use the Devicetree name to identify them in a way that's meaningful for
> the kernel:
> 
> mt8173-elm-hana
> mt8183-kukui-jacuzzi-juniper-sku16

Thanks. Will use the device tree name.

Regards,
Vignesh

> 
> Thanks,
> Nícolas
diff mbox series

Patch

diff --git a/arch/arm64/configs/defconfig b/arch/arm64/configs/defconfig
index 1f25423de383..09aedc3447b7 100644
--- a/arch/arm64/configs/defconfig
+++ b/arch/arm64/configs/defconfig
@@ -1573,6 +1573,9 @@  CONFIG_PHY_HISTB_COMBPHY=y
 CONFIG_PHY_HISI_INNO_USB2=y
 CONFIG_PHY_MVEBU_CP110_COMPHY=y
 CONFIG_PHY_MTK_TPHY=y
+CONFIG_PHY_MTK_MIPI_DSI=m
+CONFIG_PHY_MTK_XSPHY=m
+CONFIG_PHY_MTK_HDMI=m
 CONFIG_PHY_QCOM_EDP=m
 CONFIG_PHY_QCOM_PCIE2=m
 CONFIG_PHY_QCOM_QMP=m