From patchwork Fri Nov 16 10:01:12 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Viresh Kumar X-Patchwork-Id: 10685781 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 02AF714E2 for ; Fri, 16 Nov 2018 10:03:05 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id E650C2D3EC for ; Fri, 16 Nov 2018 10:03:04 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id DA6BA2D472; Fri, 16 Nov 2018 10:03:04 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.6 required=2.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,MAILING_LIST_MULTI,RCVD_IN_DNSWL_LOW autolearn=ham version=3.3.1 Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.wl.linuxfoundation.org (Postfix) with ESMTPS id 860DD2D403 for ; Fri, 16 Nov 2018 10:03:04 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-Id:Date:Subject:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=jNnsGfb0UGevHgiUQym4ILbthE9n7Qq/yOl6+A/Ge9U=; b=Ax2qBoRncLQ+/2 0a6n6+KH/9LCw0D3BkfzjI+saBWVc+R68NIxSe3lUSqIOF4pxFtE5+as93HjzZa+XRen1FMpXJKQX RzQk7ll1BOjvBJ8HJNLWq6iqqEtq5Bz1wqB9fl9pN1S9tpcHpfBaGZ4nYit/h0WHV3oY+M7g2D5is yBhL4h7ip3UmkOMR4LNFU0IhAxDi5tJDY7/OLOhVJ5bt0oG5mnaTA6lYTiCTfyAeu2fGmOWnCL5UO JDRJZwSkkQa/GvxZKwN5vkjHK+aWwYH/N9xki+dgTZqYkB9hbPXvlwoXDpmTL4Js6pDXIKM2UAKaW Lmh3B6ivXHLE7Y8bgSkw==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1gNaxq-0004uE-RM; Fri, 16 Nov 2018 10:03:02 +0000 Received: from mail-pl1-x642.google.com ([2607:f8b0:4864:20::642]) by bombadil.infradead.org with esmtps (Exim 4.90_1 #2 (Red Hat Linux)) id 1gNawf-0003dA-7P for linux-mediatek@lists.infradead.org; Fri, 16 Nov 2018 10:01:57 +0000 Received: by mail-pl1-x642.google.com with SMTP id e5so911478plb.5 for ; Fri, 16 Nov 2018 02:01:40 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=LK6GiW769WFFMCSrW8bZq8d0PusJgT2ioSzhc2edhMA=; b=fq+At354HoAdN09twMtyS3uMc8QXc2XxXLgHQY9WkbhKgkRKwNemxOdQH3+SceMY+m SKk6RGwNyqjv49thLZgJfxIzTLX44RhhOfJ+SJqDtuiDCjrESb1MkUqMz+5EDSEwLDzM InKRhBL9rj1SrpStpMIXCel8q5B66PSAT13EE= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=LK6GiW769WFFMCSrW8bZq8d0PusJgT2ioSzhc2edhMA=; b=a31p73JDQi40vtEaD5dmFGVBgBLJDCAzDDBFUuJ6BuMhjkoP4sw1sDgTE/IwbFVFLK C1238f24tbBsu7NCWqLuVc1VxXTokiv9cYInTqdZxwexbKHFDHtN2m3wilcKCQDqdDri EdQDBUXESfWzQVb87bU4OG70iy2kt73rxNNtQle19bY6el5JYry+htV3hBHY7x/5K9G/ JmfYMA/uYF3xlGt34gBpwMiBq5E8Q5hh004ZB/NCs/W0uJbNc/dUH8Q5KCmxXMFRa9JV r14boOBdMdBBnmYqBMZ1E5TNsmG6v7asbpT4aeL0SKxTb25GRzC1/WoxrLrZi4uSkIi4 /+qQ== X-Gm-Message-State: AGRZ1gKeewPrEvPR75hMez7/ZYqcIzYg6Ept2yT1g2iMc4rQU3oq4R6Q eZs/m9y9P0Aegp+Y5Vb5jQpHUpr1eeQ= X-Google-Smtp-Source: AJdET5cP3OiPVJ0GUIcBL5FuxbLvoThio2c0iqx0gdi1CHjEsGsz/vnFwS7sJ94vVR+Jg81RGev/lw== X-Received: by 2002:a17:902:162:: with SMTP id 89-v6mr10100540plb.293.1542362499626; Fri, 16 Nov 2018 02:01:39 -0800 (PST) Received: from localhost ([122.172.88.116]) by smtp.gmail.com with ESMTPSA id o84sm18959674pfi.172.2018.11.16.02.01.38 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 16 Nov 2018 02:01:39 -0800 (PST) From: Viresh Kumar To: Mark Rutland , Rob Herring , Matthias Brugger Subject: [PATCH 3/6] ARM: dts: mt7623: Add all CPUs in cooling maps Date: Fri, 16 Nov 2018 15:31:12 +0530 Message-Id: <3c44454d70c9c9bafcf86f2c020d17d048f33360.1542362000.git.viresh.kumar@linaro.org> X-Mailer: git-send-email 2.19.1.568.g152ad8e3369a In-Reply-To: References: MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20181116_020149_266508_63CB9239 X-CRM114-Status: GOOD ( 12.26 ) X-BeenThere: linux-mediatek@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: devicetree@vger.kernel.org, Vincent Guittot , Viresh Kumar , Daniel Lezcano , linux-kernel@vger.kernel.org, linux-mediatek@lists.infradead.org, linux-arm-kernel@lists.infradead.org Sender: "Linux-mediatek" Errors-To: linux-mediatek-bounces+patchwork-linux-mediatek=patchwork.kernel.org@lists.infradead.org X-Virus-Scanned: ClamAV using ClamSMTP Each CPU can (and does) participate in cooling down the system but the DT only captures a handful of them, normally CPU0, in the cooling maps. Things work by chance currently as under normal circumstances its the first CPU of each cluster which is used by the operating systems to probe the cooling devices. But as soon as this CPU ordering changes and any other CPU is used to bring up the cooling device, we will start seeing failures. Also the DT is rather incomplete when we list only one CPU in the cooling maps, as the hardware doesn't have any such limitations. Update cooling maps to include all devices affected by individual trip points. Signed-off-by: Viresh Kumar --- arch/arm/boot/dts/mt7623.dtsi | 15 ++++++++++++--- 1 file changed, 12 insertions(+), 3 deletions(-) diff --git a/arch/arm/boot/dts/mt7623.dtsi b/arch/arm/boot/dts/mt7623.dtsi index d01bdee6f2f3..7cae886f79c9 100644 --- a/arch/arm/boot/dts/mt7623.dtsi +++ b/arch/arm/boot/dts/mt7623.dtsi @@ -187,17 +187,26 @@ cooling-maps { map0 { trip = <&cpu_passive>; - cooling-device = <&cpu0 THERMAL_NO_LIMIT THERMAL_NO_LIMIT>; + cooling-device = <&cpu0 THERMAL_NO_LIMIT THERMAL_NO_LIMIT>, + <&cpu1 THERMAL_NO_LIMIT THERMAL_NO_LIMIT>, + <&cpu2 THERMAL_NO_LIMIT THERMAL_NO_LIMIT>, + <&cpu3 THERMAL_NO_LIMIT THERMAL_NO_LIMIT>; }; map1 { trip = <&cpu_active>; - cooling-device = <&cpu0 THERMAL_NO_LIMIT THERMAL_NO_LIMIT>; + cooling-device = <&cpu0 THERMAL_NO_LIMIT THERMAL_NO_LIMIT>, + <&cpu1 THERMAL_NO_LIMIT THERMAL_NO_LIMIT>, + <&cpu2 THERMAL_NO_LIMIT THERMAL_NO_LIMIT>, + <&cpu3 THERMAL_NO_LIMIT THERMAL_NO_LIMIT>; }; map2 { trip = <&cpu_hot>; - cooling-device = <&cpu0 THERMAL_NO_LIMIT THERMAL_NO_LIMIT>; + cooling-device = <&cpu0 THERMAL_NO_LIMIT THERMAL_NO_LIMIT>, + <&cpu1 THERMAL_NO_LIMIT THERMAL_NO_LIMIT>, + <&cpu2 THERMAL_NO_LIMIT THERMAL_NO_LIMIT>, + <&cpu3 THERMAL_NO_LIMIT THERMAL_NO_LIMIT>; }; }; };