diff mbox series

[6/9] wifi: mt76: mt7921: drop ieee80211_[start, stop]_queues in driver

Message ID 44acac2a0c1ce4a5d554a24227f80c6ccb3af878.1660606893.git.objelf@gmail.com (mailing list archive)
State New, archived
Headers show
Series wifi: mt76: mt7921: introduce chanctx support | expand

Commit Message

Sean Wang Aug. 16, 2022, 12:03 a.m. UTC
From: Sean Wang <sean.wang@mediatek.com>

The firmware would be in charge of braking and continuing the traffic while
the channel contexts are switching between different BSS and HW SCAN in the
background.

Signed-off-by: Sean Wang <sean.wang@mediatek.com>
---
 drivers/net/wireless/mediatek/mt76/mt7921/mcu.c | 8 +++-----
 1 file changed, 3 insertions(+), 5 deletions(-)

Comments

Lorenzo Bianconi Aug. 17, 2022, 7:16 a.m. UTC | #1
> From: Sean Wang <sean.wang@mediatek.com>
> 
> The firmware would be in charge of braking and continuing the traffic while
> the channel contexts are switching between different BSS and HW SCAN in the
> background.
> 
> Signed-off-by: Sean Wang <sean.wang@mediatek.com>
> ---
>  drivers/net/wireless/mediatek/mt76/mt7921/mcu.c | 8 +++-----
>  1 file changed, 3 insertions(+), 5 deletions(-)
> 
> diff --git a/drivers/net/wireless/mediatek/mt76/mt7921/mcu.c b/drivers/net/wireless/mediatek/mt76/mt7921/mcu.c
> index 76c8afc00c24..05b625e02265 100644
> --- a/drivers/net/wireless/mediatek/mt76/mt7921/mcu.c
> +++ b/drivers/net/wireless/mediatek/mt76/mt7921/mcu.c
> @@ -175,15 +175,13 @@ mt7921_mcu_connection_loss_event(struct mt7921_dev *dev, struct sk_buff *skb)
>  static void
>  mt7921_mcu_bss_event(struct mt7921_dev *dev, struct sk_buff *skb)
>  {
> -	struct mt76_phy *mphy = &dev->mt76.phy;
>  	struct mt76_connac_mcu_bss_event *event;
>  
>  	skb_pull(skb, sizeof(struct mt76_connac2_mcu_rxd));
>  	event = (struct mt76_connac_mcu_bss_event *)skb->data;
> -	if (event->is_absent)
> -		ieee80211_stop_queues(mphy->hw);
> -	else
> -		ieee80211_wake_queues(mphy->hw);
> +
> +	dev_dbg(dev->mt76.dev, "BSS %d is %s\n", event->bss_idx,
> +		event->is_absent ? "Absent" : "Present");

do we really need this? I guess we can just drop mt7921_mcu_bss_event entirely

Regards,
Lorenzo

>  }
>  
>  static void
> -- 
> 2.25.1
>
Sean Wang Aug. 18, 2022, 12:44 a.m. UTC | #2
HI Lorenzo,

<snip>
> > +
> > +     dev_dbg(dev->mt76.dev, "BSS %d is %s\n", event->bss_idx,
> > +             event->is_absent ? "Absent" : "Present");
>
> do we really need this? I guess we can just drop mt7921_mcu_bss_event entirely

That is not really necessary. That was just what I used to diagnose
firmware behavior. I think I will remove it in the next version.

     Sean
>
> Regards,
> Lorenzo
>
> >  }
> >
> >  static void
> > --
> > 2.25.1
> >
diff mbox series

Patch

diff --git a/drivers/net/wireless/mediatek/mt76/mt7921/mcu.c b/drivers/net/wireless/mediatek/mt76/mt7921/mcu.c
index 76c8afc00c24..05b625e02265 100644
--- a/drivers/net/wireless/mediatek/mt76/mt7921/mcu.c
+++ b/drivers/net/wireless/mediatek/mt76/mt7921/mcu.c
@@ -175,15 +175,13 @@  mt7921_mcu_connection_loss_event(struct mt7921_dev *dev, struct sk_buff *skb)
 static void
 mt7921_mcu_bss_event(struct mt7921_dev *dev, struct sk_buff *skb)
 {
-	struct mt76_phy *mphy = &dev->mt76.phy;
 	struct mt76_connac_mcu_bss_event *event;
 
 	skb_pull(skb, sizeof(struct mt76_connac2_mcu_rxd));
 	event = (struct mt76_connac_mcu_bss_event *)skb->data;
-	if (event->is_absent)
-		ieee80211_stop_queues(mphy->hw);
-	else
-		ieee80211_wake_queues(mphy->hw);
+
+	dev_dbg(dev->mt76.dev, "BSS %d is %s\n", event->bss_idx,
+		event->is_absent ? "Absent" : "Present");
 }
 
 static void