From patchwork Wed Jan 27 09:27:34 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Arnd Bergmann X-Patchwork-Id: 8131501 Return-Path: X-Original-To: patchwork-linux-mediatek@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork1.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.136]) by patchwork1.web.kernel.org (Postfix) with ESMTP id A65249F818 for ; Wed, 27 Jan 2016 09:29:01 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id BDD9020270 for ; Wed, 27 Jan 2016 09:29:00 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.9]) (using TLSv1.2 with cipher AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id D9E472013D for ; Wed, 27 Jan 2016 09:28:59 +0000 (UTC) Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.80.1 #2 (Red Hat Linux)) id 1aOMPJ-0006Kw-LC; Wed, 27 Jan 2016 09:28:57 +0000 Received: from mout.kundenserver.de ([212.227.126.187]) by bombadil.infradead.org with esmtps (Exim 4.80.1 #2 (Red Hat Linux)) id 1aOMOu-0005bI-3u; Wed, 27 Jan 2016 09:28:44 +0000 Received: from wuerfel.localnet ([78.42.132.4]) by mrelayeu.kundenserver.de (mreue002) with ESMTPSA (Nemesis) id 0Lcsfw-1ZgG901zmK-00iAuZ; Wed, 27 Jan 2016 10:27:42 +0100 From: Arnd Bergmann To: linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH] clk: Move vendor's Kconfig into CCF menu section Date: Wed, 27 Jan 2016 10:27:34 +0100 Message-ID: <4711589.Ig064LES4c@wuerfel> User-Agent: KMail/4.11.5 (Linux/3.16.0-10-generic; KDE/4.11.5; x86_64; ; ) In-Reply-To: <201601271708.gQUxXACW%fengguang.wu@intel.com> References: <201601271708.gQUxXACW%fengguang.wu@intel.com> MIME-Version: 1.0 X-Provags-ID: V03:K0:Xr5k1X7vsS4nr3fhovoX+UStjcP2auyN6Jq9lY6/iXIcmnFsXT6 l8YRu1UEzWndKd/Y+ZA0botjCje4zvpszq6fw4qnw6hGDOsAtSyyXdXAb6NmgTrcTyjtf3f /HrAvj35NKBuqRRqhbSBcHiUqFuMTkfPC0+Ifok6FDyY/nY2Qd+YNhllpjPgX7HFKgq/y4b QSeFEvlG/WrmfzR4WQU2Q== X-UI-Out-Filterresults: notjunk:1; V01:K0:m1qUDQrVdGE=:tIg/09eST47JHr9KClMhH8 FktztKcvAANAC9xNDoQc8wC7gSaCr6Eq6SVShDsB2Om29IQr0Vg6i0wedRPeXQ4TOo49Z/KuQ xQk/QppwIf5koq2titaYwPhXGdvU1UcwgcnjzD+5tNWoJx7+RsHXQAiuPJaUO0TcJFWryDN3P NwRoMErwQrulbXbdbHmvpuoSTqQfm73KLNZiZsGStJAiOUchyylSKEdkbCHrK7YXT33eW9TrN yidbI4bLRXajGxWpPVDtbKdanojfbe95dDtCPVAUDQZxqBDEJmGp5DawnmwkDeRXrIB7dCDPI Gq5eNjgYup+clxS0tQJNCIBCZCLsrDNZlJAQLClsosqfCYuX4I7v1NFPbX4HAhQmPaIYUrKwA h145A6vEmpzA/L5LOTs1TeM9RIeqTtdZgRDWme8J/+kWuFmGZsI7sx2E9GFueatkIMN9yYpaM wXnLmm+ngAdNQ4PtN0Ui1YtuVzsD1VrZuQVe56GUkw2Sh3yaVxtaL9kt4hcVXoXIIIPY/3UEr lwxl9luXMVYmkuNSRlYS+ksjrZBOFwV9sITeQ7FaVSBZmYYAvItdjxoZ3wPwDkGO4toz1e+vH ujND9XXxoFdRxO4JRqqCwiHkjNnjIXw543T22P7cxk4GAlLfss99XDOGI4v4CBmRT1i3DMBF4 c9Qr0Y1XDI4fe9ZL810nvFGZAfX/vVFj25/eS2yyPEHYvS679DaMeTt8m/MaBdNnn6PJvl7uP //OiVlrYctAlZDD8 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20160127_012833_030666_C74C1424 X-CRM114-Status: GOOD ( 15.85 ) X-Spam-Score: -1.9 (-) X-BeenThere: linux-mediatek@lists.infradead.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: James Liao , kbuild test robot , srv_heupstream@mediatek.com, devicetree@vger.kernel.org, Mike Turquette , Stephen Boyd , linux-kernel@vger.kernel.org, linux-mediatek@lists.infradead.org, kbuild-all@01.org, Sascha Hauer , Matthias Brugger , linux-clk@vger.kernel.org Sender: "Linux-mediatek" Errors-To: linux-mediatek-bounces+patchwork-linux-mediatek=patchwork.kernel.org@lists.infradead.org X-Spam-Status: No, score=-4.2 required=5.0 tests=BAYES_00, RCVD_IN_DNSWL_MED, RP_MATCHES_RCVD, UNPARSEABLE_RELAY autolearn=unavailable version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP On Wednesday 27 January 2016 17:18:03 kbuild test robot wrote: > Hi James, > > [auto build test ERROR on clk/clk-next] > [also build test ERROR on v4.5-rc1 next-20160127] > [if your patch is applied to the wrong git tree, please drop us a note to help improving the system] > > url: https://github.com/0day-ci/linux/commits/James-Liao/clk-Move-vendor-s-Kconfig-into-CCF-menu-section/20160127-152850 > base: https://git.kernel.org/pub/scm/linux/kernel/git/clk/linux.git clk-next > config: arm-samsung (attached as .config) > reproduce: > wget https://git.kernel.org/cgit/linux/kernel/git/wfg/lkp-tests.git/plain/sbin/make.cross -O ~/bin/make.cross > chmod +x ~/bin/make.cross > # save the attached .config to linux build tree > make.cross ARCH=arm > > All error/warnings (new ones prefixed by >>): > > warning: (ARCH_BAST && MACH_VR1000 && MACH_ANUBIS && MACH_OSIRIS && MACH_RX1950) selects S3C2410_COMMON_DCLK which has unmet direct dependencies (COMMON_CLK) > warning: (CPU_S3C2410 && CPU_S3C2440 && CPU_S3C2442) selects S3C2410_COMMON_CLK which has unmet direct dependencies (COMMON_CLK) > warning: (CPU_S3C2412) selects S3C2412_COMMON_CLK which has unmet direct dependencies (COMMON_CLK) > warning: (CPU_S3C2416 && CPU_S3C2443) selects S3C2443_COMMON_CLK which has unmet direct dependencies (COMMON_CLK) > drivers/built-in.o: In function `pwm_samsung_remove': > >> :(.text+0xba68): undefined reference to `clk_disable' > drivers/built-in.o: In function `pwm_samsung_config': > >> :(.text+0xbc18): undefined reference to `clk_get_rate' > :(.text+0xbc30): undefined reference to `clk_get_rate' I think you should include this change in your patch, or as a preparation. All other samsung platforms already select COMMON_CLK through ARCH_MULTIPLATFORM, and all SoCs that are part of ARCH_S3C24XX individually select a symbol that selects COMMON_CLK. Arnd diff --git a/arch/arm/mach-s3c24xx/Kconfig b/arch/arm/mach-s3c24xx/Kconfig index bf66c8334822..85e051d1c2d6 100644 --- a/arch/arm/mach-s3c24xx/Kconfig +++ b/arch/arm/mach-s3c24xx/Kconfig @@ -15,6 +15,7 @@ config PLAT_S3C24XX select NO_IOPORT_MAP select S3C_DEV_NAND select IRQ_DOMAIN + select COMMON_CLK help Base platform code for any Samsung S3C24XX device diff --git a/drivers/clk/samsung/Kconfig b/drivers/clk/samsung/Kconfig index 84196ecdaa12..b3fe5cb01afe 100644 --- a/drivers/clk/samsung/Kconfig +++ b/drivers/clk/samsung/Kconfig @@ -1,6 +1,5 @@ config COMMON_CLK_SAMSUNG bool - select COMMON_CLK config S3C2410_COMMON_CLK bool