| Message ID | 693c433a-cf72-4938-a1aa-58af2ff89479@stanley.mountain (mailing list archive) |
|---|---|
| State | New |
| Headers | show |
| Series | [net-next] net: airoha: Fix forever loops in error handling | expand |
> These loops have ++ where -- was intended. It would end up looping until > the system died. Hi Dan, I have already posted a fix for it: https://git.kernel.org/pub/scm/linux/kernel/git/netdev/net.git/commit/?id=1f038d5897fe6b439039fc28420842abcc0d126b Regards, Lorenzo > > Fixes: 23020f049327 ("net: airoha: Introduce ethernet support for EN7581 SoC") > Signed-off-by: Dan Carpenter <dan.carpenter@linaro.org> > --- > drivers/net/ethernet/mediatek/airoha_eth.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/net/ethernet/mediatek/airoha_eth.c b/drivers/net/ethernet/mediatek/airoha_eth.c > index 7967a92803c2..698835dc6da0 100644 > --- a/drivers/net/ethernet/mediatek/airoha_eth.c > +++ b/drivers/net/ethernet/mediatek/airoha_eth.c > @@ -977,7 +977,7 @@ static int airoha_set_gdm_ports(struct airoha_eth *eth, bool enable) > return 0; > > error: > - for (i--; i >= 0; i++) > + while (--i >= 0) > airoha_set_gdm_port(eth, port_list[i], false); > > return err; > @@ -2431,7 +2431,7 @@ static netdev_tx_t airoha_dev_xmit(struct sk_buff *skb, > return NETDEV_TX_OK; > > error_unmap: > - for (i--; i >= 0; i++) > + while (--i >= 0) > dma_unmap_single(dev->dev.parent, q->entry[i].dma_addr, > q->entry[i].dma_len, DMA_TO_DEVICE); > > -- > 2.43.0 >
diff --git a/drivers/net/ethernet/mediatek/airoha_eth.c b/drivers/net/ethernet/mediatek/airoha_eth.c index 7967a92803c2..698835dc6da0 100644 --- a/drivers/net/ethernet/mediatek/airoha_eth.c +++ b/drivers/net/ethernet/mediatek/airoha_eth.c @@ -977,7 +977,7 @@ static int airoha_set_gdm_ports(struct airoha_eth *eth, bool enable) return 0; error: - for (i--; i >= 0; i++) + while (--i >= 0) airoha_set_gdm_port(eth, port_list[i], false); return err; @@ -2431,7 +2431,7 @@ static netdev_tx_t airoha_dev_xmit(struct sk_buff *skb, return NETDEV_TX_OK; error_unmap: - for (i--; i >= 0; i++) + while (--i >= 0) dma_unmap_single(dev->dev.parent, q->entry[i].dma_addr, q->entry[i].dma_len, DMA_TO_DEVICE);
These loops have ++ where -- was intended. It would end up looping until the system died. Fixes: 23020f049327 ("net: airoha: Introduce ethernet support for EN7581 SoC") Signed-off-by: Dan Carpenter <dan.carpenter@linaro.org> --- drivers/net/ethernet/mediatek/airoha_eth.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)