From patchwork Wed Mar 11 19:19:05 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Aman Sharma X-Patchwork-Id: 11432679 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 8F7201392 for ; Wed, 11 Mar 2020 19:20:58 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 07FEB20578 for ; Wed, 11 Mar 2020 19:20:58 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="TYHtYb1j"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="eZXdYYUO" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 07FEB20578 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-mediatek-bounces+patchwork-linux-mediatek=patchwork.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-Id:Date:Subject:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=V3DD+EWnmBZC/k7cTn9myU86CqG9UXq10LZiYJ1go5Q=; b=TYHtYb1jSjtPNF /1c7sYVEmhjPtxOZwiWecO1uwm6/GFg0zLTW1nHcaJvIn/q3SMm0wrRM/phZkViSR5WB1tUXnycjR p8tNSCs3aEhsE7xf6UbpNJPJhYVhzt11XGqy+zGyKyIlpTmc42UmGNVsz2iGCN9IJWdxgch+oVw/8 PCrYZlWjP4Ic7g+viG9WEoM4N77v3+M8QJykwj3P7+qxLWm8/PgK/P4/qAnr8ivSwqTLqn15j3989 ybtoZhFzM5wp9zMhL6AGDJkeeyz3UWZiV5vu1BHF7cszIZacke+rXNATZlzSQkmWB9/UHwrKpWcj/ TS/bZG7TUki7S/qZhwjg==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jC6uU-00004r-8h; Wed, 11 Mar 2020 19:20:54 +0000 Received: from mail-pl1-x644.google.com ([2607:f8b0:4864:20::644]) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1jC6tF-0006GI-JC; Wed, 11 Mar 2020 19:19:39 +0000 Received: by mail-pl1-x644.google.com with SMTP id w12so1524282pll.13; Wed, 11 Mar 2020 12:19:37 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=pOjQrnVayTgdrET4gCgzOMQ7+VznZ1NPyMucBXzQRTg=; b=eZXdYYUO9MJk8vDBz2ohUHhTlFQ6OUvKe5NJC3wwMup1+78yjzPuD0a1yqr7kKDAzn R6bakE9D6+2lnyfG457Nwws4+THsXyHBMV88kQa77cHLpoisL/FI1o5FbYjjD+Cho972 a/pSRcvr7B/YCgFV1J8wk+jRpXIpqHPrPXkUbPz86UioJj5qwacgDmZn15UmH5MpjSIm NvmTKUXeA4shooBgG2EMsAcLL3Sm7nQ72CXnpIBnlTEibmiT3TrxdnaIeopIbHLfMDA9 iCdUKJsTETkc/0yFfjDjJIJEzpVlInD/58X/THAjQ3ciF01RAOk751kpX86fuzJRi0o3 d2OA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=pOjQrnVayTgdrET4gCgzOMQ7+VznZ1NPyMucBXzQRTg=; b=Opmn/W2hzzQ+5ZNi+BUApGZ5tpdzLGzq1ng5WBskTdTCYgPGRu/xpOOwI4Y0I+n697 HwT4XTeFAGAuS8LxsTZX3/Pm662jqcxD9tYWDslz5zEIORpI2czzuS2U9fuO7UE7YFyY wFSs4b+WTTuqafmSaXQ/fY092OxUCVuRpmKZ3F0g5BaZVBawA60JGRsI9vqJtmkDNxCp F6Kuvtqa8nCzpIGJeYIpncYuip7uPzBJ+rxSt79vs/B79OQ84hzg6PeGsjx/bXhNMKC0 OKo2c6BLhSdQpYHR2/VlnyLFxR42JohpnqekVejz6UAp/zYZXacu/QC2jdLEepBFzezH cC8A== X-Gm-Message-State: ANhLgQ1jhFYPxlw5Ir00MZPdGnivFQD0C7yxT6RwB3HB88PCSPLs59A8 qFJKH6YJlhgLth5f56PApnw= X-Google-Smtp-Source: ADFU+vsSzPj8KundN3q85Ksdo5biFKHHfX+UdUbQyTZOldP1FMJEG8vyFDHt7yRgWjL+jYyHW5T0Zg== X-Received: by 2002:a17:90b:1a8b:: with SMTP id ng11mr201893pjb.173.1583954376003; Wed, 11 Mar 2020 12:19:36 -0700 (PDT) Received: from localhost.localdomain ([103.46.201.94]) by smtp.gmail.com with ESMTPSA id z17sm3792673pff.12.2020.03.11.12.19.31 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 11 Mar 2020 12:19:35 -0700 (PDT) From: Aman Sharma To: Subject: [PATCH 4/5] pci: handled return value of platform_get_irq correctly Date: Thu, 12 Mar 2020 00:49:05 +0530 Message-Id: X-Mailer: git-send-email 2.20.1 In-Reply-To: References: MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200311_121937_770634_732A3E14 X-CRM114-Status: GOOD ( 10.73 ) X-Spam-Score: 0.1 (/) X-Spam-Report: SpamAssassin version 3.4.3 on bombadil.infradead.org summary: Content analysis details: (0.1 points) pts rule name description ---- ---------------------- -------------------------------------------------- -0.0 RCVD_IN_DNSWL_NONE RBL: Sender listed at https://www.dnswl.org/, no trust [2607:f8b0:4864:20:0:0:0:644 listed in] [list.dnswl.org] 0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record -0.0 SPF_PASS SPF: sender matches SPF record 0.0 FREEMAIL_FROM Sender email is commonly abused enduser mail provider [amanharitsh123[at]gmail.com] 0.2 FREEMAIL_ENVFROM_END_DIGIT Envelope-from freemail username ends in digit [amanharitsh123[at]gmail.com] -0.1 DKIM_VALID_AU Message has a valid DKIM or DK signature from author's domain -0.1 DKIM_VALID_EF Message has a valid DKIM or DK signature from envelope-from domain 0.1 DKIM_SIGNED Message has a DKIM or DK signature, not necessarily valid -0.1 DKIM_VALID Message has at least one valid DKIM or DK signature X-BeenThere: linux-mediatek@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Lorenzo Pieralisi , Karthikeyan Mitran , Marc Gonzalez , linux-pci@vger.kernel.org, Linus Walleij , amanharitsh123@gmail.com, linux-kernel@vger.kernel.org, Matthias Brugger , Ryder Lee , linux-mediatek@lists.infradead.org, Thomas Petazzoni , Bjorn Helgaas , Mans Rullgard , Hou Zhiqiang , linux-arm-kernel@lists.infradead.org, Andrew Murray Sender: "Linux-mediatek" Errors-To: linux-mediatek-bounces+patchwork-linux-mediatek=patchwork.kernel.org@lists.infradead.org Signed-off-by: Aman Sharma Signed-off-by: Bjorn Helgaas --- drivers/pci/controller/pcie-tango.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/pci/controller/pcie-tango.c b/drivers/pci/controller/pcie-tango.c index 21a208da3f59..18c2c4313eb5 100644 --- a/drivers/pci/controller/pcie-tango.c +++ b/drivers/pci/controller/pcie-tango.c @@ -273,9 +273,9 @@ static int tango_pcie_probe(struct platform_device *pdev) writel_relaxed(0, pcie->base + SMP8759_ENABLE + offset); virq = platform_get_irq(pdev, 1); - if (virq <= 0) { + if (virq < 0) { dev_err(dev, "Failed to map IRQ\n"); - return -ENXIO; + return virq; } irq_dom = irq_domain_create_linear(fwnode, MSI_MAX, &dom_ops, pcie);