| Message ID | fd4890851d8233635b334a0fad7742a58e53bc7a.1506509659.git.chunfeng.yun@mediatek.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
On Thu, Sep 28, 2017 at 08:17:18AM +0800, Chunfeng Yun wrote: > Add a new optional property to disable u3ports > > Signed-off-by: Chunfeng Yun <chunfeng.yun@mediatek.com> > --- > .../devicetree/bindings/usb/mediatek,mtu3.txt | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/Documentation/devicetree/bindings/usb/mediatek,mtu3.txt b/Documentation/devicetree/bindings/usb/mediatek,mtu3.txt > index 49f5476..7c611d1 100644 > --- a/Documentation/devicetree/bindings/usb/mediatek,mtu3.txt > +++ b/Documentation/devicetree/bindings/usb/mediatek,mtu3.txt > @@ -44,6 +44,8 @@ Optional properties: > - mediatek,enable-wakeup : supports ip sleep wakeup used by host mode > - mediatek,syscon-wakeup : phandle to syscon used to access USB wakeup > control register, it depends on "mediatek,enable-wakeup". > + - mediatek,u3p-dis-msk : mask to disable u3ports, bit0 for u3port0, > + bit1 for u3port1, ... etc; How does this relate to the XHCI change? Same comment applies.
On Thu, 2017-10-05 at 17:31 -0500, Rob Herring wrote: > On Thu, Sep 28, 2017 at 08:17:18AM +0800, Chunfeng Yun wrote: > > Add a new optional property to disable u3ports > > > > Signed-off-by: Chunfeng Yun <chunfeng.yun@mediatek.com> > > --- > > .../devicetree/bindings/usb/mediatek,mtu3.txt | 2 ++ > > 1 file changed, 2 insertions(+) > > > > diff --git a/Documentation/devicetree/bindings/usb/mediatek,mtu3.txt b/Documentation/devicetree/bindings/usb/mediatek,mtu3.txt > > index 49f5476..7c611d1 100644 > > --- a/Documentation/devicetree/bindings/usb/mediatek,mtu3.txt > > +++ b/Documentation/devicetree/bindings/usb/mediatek,mtu3.txt > > @@ -44,6 +44,8 @@ Optional properties: > > - mediatek,enable-wakeup : supports ip sleep wakeup used by host mode > > - mediatek,syscon-wakeup : phandle to syscon used to access USB wakeup > > control register, it depends on "mediatek,enable-wakeup". > > + - mediatek,u3p-dis-msk : mask to disable u3ports, bit0 for u3port0, > > + bit1 for u3port1, ... etc; > > How does this relate to the XHCI change? Same comment applies. There is a upper layer called IPPC (IP Power and Clock interface) shared by device IP and host IP (xHCI) to control power and clock of each port. So I can disable or enable xCHI's ports by IPPC indirectly.
diff --git a/Documentation/devicetree/bindings/usb/mediatek,mtu3.txt b/Documentation/devicetree/bindings/usb/mediatek,mtu3.txt index 49f5476..7c611d1 100644 --- a/Documentation/devicetree/bindings/usb/mediatek,mtu3.txt +++ b/Documentation/devicetree/bindings/usb/mediatek,mtu3.txt @@ -44,6 +44,8 @@ Optional properties: - mediatek,enable-wakeup : supports ip sleep wakeup used by host mode - mediatek,syscon-wakeup : phandle to syscon used to access USB wakeup control register, it depends on "mediatek,enable-wakeup". + - mediatek,u3p-dis-msk : mask to disable u3ports, bit0 for u3port0, + bit1 for u3port1, ... etc; Sub-nodes: The xhci should be added as subnode to mtu3 as shown in the following example
Add a new optional property to disable u3ports Signed-off-by: Chunfeng Yun <chunfeng.yun@mediatek.com> --- .../devicetree/bindings/usb/mediatek,mtu3.txt | 2 ++ 1 file changed, 2 insertions(+)