| Message ID | fd8b6099192ddee3b277f5ca3a699c20fb273ffe.1506503880.git.chunfeng.yun@mediatek.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
On Wed, Sep 27, 2017 at 05:23:04PM +0800, Chunfeng Yun wrote: > Add a new optional property to disable u3ports > > Signed-off-by: Chunfeng Yun <chunfeng.yun@mediatek.com> > --- > .../devicetree/bindings/usb/mediatek,mtk-xhci.txt | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/Documentation/devicetree/bindings/usb/mediatek,mtk-xhci.txt b/Documentation/devicetree/bindings/usb/mediatek,mtk-xhci.txt > index 5611a2e..2d9b459 100644 > --- a/Documentation/devicetree/bindings/usb/mediatek,mtk-xhci.txt > +++ b/Documentation/devicetree/bindings/usb/mediatek,mtk-xhci.txt > @@ -38,6 +38,8 @@ Optional properties: > mode; > - mediatek,syscon-wakeup : phandle to syscon used to access USB wakeup > control register, it depends on "mediatek,wakeup-src". > + - mediatek,u3p-dis-msk : mask to disable u3ports, bit0 for u3port0, > + bit1 for u3port1, ... etc; I think you should have child nodes for ports and use "status" to disable them (or omit them). IIRC, the common USB bus binding already defines ports. > - vbus-supply : reference to the VBUS regulator; > - usb3-lpm-capable : supports USB3.0 LPM > - pinctrl-names : a pinctrl state named "default" must be defined > -- > 1.7.9.5 >
On Thu, 2017-10-05 at 17:16 -0500, Rob Herring wrote: > On Wed, Sep 27, 2017 at 05:23:04PM +0800, Chunfeng Yun wrote: > > Add a new optional property to disable u3ports > > > > Signed-off-by: Chunfeng Yun <chunfeng.yun@mediatek.com> > > --- > > .../devicetree/bindings/usb/mediatek,mtk-xhci.txt | 2 ++ > > 1 file changed, 2 insertions(+) > > > > diff --git a/Documentation/devicetree/bindings/usb/mediatek,mtk-xhci.txt b/Documentation/devicetree/bindings/usb/mediatek,mtk-xhci.txt > > index 5611a2e..2d9b459 100644 > > --- a/Documentation/devicetree/bindings/usb/mediatek,mtk-xhci.txt > > +++ b/Documentation/devicetree/bindings/usb/mediatek,mtk-xhci.txt > > @@ -38,6 +38,8 @@ Optional properties: > > mode; > > - mediatek,syscon-wakeup : phandle to syscon used to access USB wakeup > > control register, it depends on "mediatek,wakeup-src". > > + - mediatek,u3p-dis-msk : mask to disable u3ports, bit0 for u3port0, > > + bit1 for u3port1, ... etc; > > I think you should have child nodes for ports and use "status" to > disable them (or omit them). IIRC, the common USB bus binding already > defines ports. I survey it to see whether it can replace the current way thanks > > > - vbus-supply : reference to the VBUS regulator; > > - usb3-lpm-capable : supports USB3.0 LPM > > - pinctrl-names : a pinctrl state named "default" must be defined > > -- > > 1.7.9.5 > >
On Thu, 2017-10-05 at 17:16 -0500, Rob Herring wrote: Hi, > On Wed, Sep 27, 2017 at 05:23:04PM +0800, Chunfeng Yun wrote: > > Add a new optional property to disable u3ports > > > > Signed-off-by: Chunfeng Yun <chunfeng.yun@mediatek.com> > > --- > > .../devicetree/bindings/usb/mediatek,mtk-xhci.txt | 2 ++ > > 1 file changed, 2 insertions(+) > > > > diff --git a/Documentation/devicetree/bindings/usb/mediatek,mtk-xhci.txt b/Documentation/devicetree/bindings/usb/mediatek,mtk-xhci.txt > > index 5611a2e..2d9b459 100644 > > --- a/Documentation/devicetree/bindings/usb/mediatek,mtk-xhci.txt > > +++ b/Documentation/devicetree/bindings/usb/mediatek,mtk-xhci.txt > > @@ -38,6 +38,8 @@ Optional properties: > > mode; > > - mediatek,syscon-wakeup : phandle to syscon used to access USB wakeup > > control register, it depends on "mediatek,wakeup-src". > > + - mediatek,u3p-dis-msk : mask to disable u3ports, bit0 for u3port0, > > + bit1 for u3port1, ... etc; > > I think you should have child nodes for ports and use "status" to > disable them (or omit them). IIRC, the common USB bus binding already > defines ports. I find only one common binding document about USB bus, that is bindings/usb/usb-device.txt, but it can't be used to disable some ports, because in hub_probe() function, hub driver enables all downstream ports, but doesn't get any property info from DTS. > > > - vbus-supply : reference to the VBUS regulator; > > - usb3-lpm-capable : supports USB3.0 LPM > > - pinctrl-names : a pinctrl state named "default" must be defined > > -- > > 1.7.9.5 > >
diff --git a/Documentation/devicetree/bindings/usb/mediatek,mtk-xhci.txt b/Documentation/devicetree/bindings/usb/mediatek,mtk-xhci.txt index 5611a2e..2d9b459 100644 --- a/Documentation/devicetree/bindings/usb/mediatek,mtk-xhci.txt +++ b/Documentation/devicetree/bindings/usb/mediatek,mtk-xhci.txt @@ -38,6 +38,8 @@ Optional properties: mode; - mediatek,syscon-wakeup : phandle to syscon used to access USB wakeup control register, it depends on "mediatek,wakeup-src". + - mediatek,u3p-dis-msk : mask to disable u3ports, bit0 for u3port0, + bit1 for u3port1, ... etc; - vbus-supply : reference to the VBUS regulator; - usb3-lpm-capable : supports USB3.0 LPM - pinctrl-names : a pinctrl state named "default" must be defined
Add a new optional property to disable u3ports Signed-off-by: Chunfeng Yun <chunfeng.yun@mediatek.com> --- .../devicetree/bindings/usb/mediatek,mtk-xhci.txt | 2 ++ 1 file changed, 2 insertions(+)