diff mbox series

wifi: mt76: mt7996: remove duplicate check in mt7996_mcu_sta_mld_setup_tlv()

Message ID fde7246b-08a2-4c2f-b2dc-c3fd0e6b300b@stanley.mountain (mailing list archive)
State New
Headers show
Series wifi: mt76: mt7996: remove duplicate check in mt7996_mcu_sta_mld_setup_tlv() | expand

Commit Message

Dan Carpenter March 21, 2025, 2:35 p.m. UTC
The "msta_link" pointer has two NULL checks.  Delete the second check.

Signed-off-by: Dan Carpenter <dan.carpenter@linaro.org>
---
 drivers/net/wireless/mediatek/mt76/mt7996/mcu.c | 3 ---
 1 file changed, 3 deletions(-)

Comments

Lorenzo Bianconi March 21, 2025, 3:52 p.m. UTC | #1
> The "msta_link" pointer has two NULL checks.  Delete the second check.
> 
> Signed-off-by: Dan Carpenter <dan.carpenter@linaro.org>
> ---
>  drivers/net/wireless/mediatek/mt76/mt7996/mcu.c | 3 ---
>  1 file changed, 3 deletions(-)
> 

Acked-by: Lorenzo Bianconi <lorenzo@kernel.org>

> diff --git a/drivers/net/wireless/mediatek/mt76/mt7996/mcu.c b/drivers/net/wireless/mediatek/mt76/mt7996/mcu.c
> index ddd555942c73..03539e20f5c5 100644
> --- a/drivers/net/wireless/mediatek/mt76/mt7996/mcu.c
> +++ b/drivers/net/wireless/mediatek/mt76/mt7996/mcu.c
> @@ -2242,9 +2242,6 @@ mt7996_mcu_sta_mld_setup_tlv(struct mt7996_dev *dev, struct sk_buff *skb,
>  		if (!link)
>  			continue;
>  
> -		if (!msta_link)
> -			continue;
> -
>  		mld_setup_link->wcid = cpu_to_le16(msta_link->wcid.idx);
>  		mld_setup_link->bss_idx = link->mt76.idx;
>  		mld_setup_link++;
> -- 
> 2.47.2
>
diff mbox series

Patch

diff --git a/drivers/net/wireless/mediatek/mt76/mt7996/mcu.c b/drivers/net/wireless/mediatek/mt76/mt7996/mcu.c
index ddd555942c73..03539e20f5c5 100644
--- a/drivers/net/wireless/mediatek/mt76/mt7996/mcu.c
+++ b/drivers/net/wireless/mediatek/mt76/mt7996/mcu.c
@@ -2242,9 +2242,6 @@  mt7996_mcu_sta_mld_setup_tlv(struct mt7996_dev *dev, struct sk_buff *skb,
 		if (!link)
 			continue;
 
-		if (!msta_link)
-			continue;
-
 		mld_setup_link->wcid = cpu_to_le16(msta_link->wcid.idx);
 		mld_setup_link->bss_idx = link->mt76.idx;
 		mld_setup_link++;