From patchwork Wed Mar 6 12:01:06 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Yifeng Li X-Patchwork-Id: 10841037 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id ACFD717E9 for ; Wed, 6 Mar 2019 12:01:47 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 98E022D6B5 for ; Wed, 6 Mar 2019 12:01:47 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 8F30D2D77F; Wed, 6 Mar 2019 12:01:47 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.0 required=2.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,RCVD_IN_DNSWL_HI autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id E792C2D775 for ; Wed, 6 Mar 2019 12:01:46 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1725267AbfCFMBp (ORCPT ); Wed, 6 Mar 2019 07:01:45 -0500 Received: from tomli.me ([153.92.126.73]:46566 "EHLO tomli.me" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728931AbfCFMBp (ORCPT ); Wed, 6 Mar 2019 07:01:45 -0500 Received: from tomli.me (localhost [127.0.0.1]) by tomli.me (OpenSMTPD) with ESMTP id 8dd4fbaa; Wed, 6 Mar 2019 12:01:42 +0000 (UTC) X-HELO: localhost.lan Authentication-Results: tomli.me; auth=pass (login) smtp.auth=tomli Received: from Unknown (HELO localhost.lan) (2402:f000:1:1501:200:5efe:72f4:b31) by tomli.me (qpsmtpd/0.95) with ESMTPSA (DHE-RSA-CHACHA20-POLY1305 encrypted); Wed, 06 Mar 2019 12:01:41 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed; d=tomli.me; h=from:to:cc:subject:date:message-id:mime-version:content-transfer-encoding; s=1490979754; bh=YuR9eiUBEkchFJaxsK0WxnVqvtw3dGIzE2OVCB0RO8A=; b=1ZZlGuRpY5hKXOSlSNH5sJ+6VEYFjbyMrEmZxM37cwzvTljFr6ltOeHKcGXFr2o5puLjwR4kPtzC33HNcMwjDP6LnaCpLqlInZ11VHDel19Zanmj/LO3v9Zxflh4I5pz9KKojcAxRG9fi3o2My3RLdgl+mB4g20aX2J1pY2cKNkMPiy1+Drr4/4dF/2kd8ysufIvL2s7LMCNCzJfIvyeWBK60BYx+MUCWi5UgAVNJCtVs4+n1xPRLlYDLO5XT3YjVHwNX5eWPoTdk28rXRz1qaHCfvhFXxlW0UoMeANArPdzzLAOISHEFwKmLktrmGw698ydYGgQFdauDq3s5VXXLQ== From: Yifeng Li To: Lee Jones , linux-mips@vger.kernel.org, Paul Burton Cc: Yifeng Li , Jiaxun Yang , Huacai Chen , Ralf Baechle , James Hogan , linux-kernel@vger.kernel.org Subject: [PATCH v3 0/7] Preliminary Platform Driver Support for Lemote Yeeloong Laptops Date: Wed, 6 Mar 2019 20:01:06 +0800 Message-Id: <20190306120113.648-1-tomli@tomli.me> X-Mailer: git-send-email 2.20.1 MIME-Version: 1.0 Sender: linux-mips-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-mips@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP v3: - Style fixes: remove asterisks banners from code comments, use pr_fmt() to format driver messages, remove newlines in mfd_cells retries, fix copyright years. - Define DEFINE_SPINLOCK(kb3310b_command_lock) as a static variable within kb3310b_query_seq(). - Reword misleading notes on using regmap. v2: - Fix the missing io.h header for the MFD driver. - Use SIMPLE_DEV_PM_OPS instead of the inappropriate .suspend/resume in the SCI driver. Lemote Yeeloong is a laptop powered by Loongson 2F MIPS processor, primarily a demo platform for hobbyists and developers. It uses an ENE KB3310B Embedded Controller with customized firmware to implement hardware and power management. Due to the lack of separation of responsibilities and functions between different subsystems, the original platform driver submitted to the mailing list was a piece of monolithic module that implements numerous drivers, as a result, it was never accepted. This patch series was carefully reorganized and partially reimplemented to avoid those pitfalls in the original driver. This is the first part of the submission, which modifies the core MIPS code to introduce preliminary preparation for other subdrivers. Notably, it leverages a notify chain and MFD cells to avoid introducing unnecessary code into the core MIPS subsystem. It features the following... * Create a MFD driver for KB3310B controller, and move the original KB3310B controller code from mips/loongson64 to our new MFD driver. This needs to be reviewed by the MFD subsystem maintainer before the following can proceed. * Add yeeloong_sci driver support of System Control Interrupt to arch/mips/loongson64/lemote-2f. This piece of code is crucial and has to be included in loongson64/lemote-2f because it reprograms CS5536 southbridge GPIO to handle the underlying interrupts. * Originally, the SCI code was mixed into the hotkey driver. The new yeeloong_sci driver was written to avoid introducing unrelated subdriver code that is unsuitable for Linux/MIPS. It only handle a minimum set of core operations directly related to the hardware platform, and pass the events to other subdrivers via a notifier chain. As a result, the SCI logic and the specific hotkey handling logic have been decoupled. * Subdrivers - hwmon, battery, backlight, lcd and hotkey are registered as MFD cells in the MFD driver. It means onlf the MFD driver is resposible to register the upcoming subdrivers, the core board files mips/loongson64/ will not contain unrelated code. I've done everything I can think of to factor unrelated code out of the MIPS subsystem. I hope the refactored code would be acceptable now. Please review my changeset to see whether it's appropriate. Thanks, Yifeng Li (7): mfd: yeeloong_kb3310b: support KB3310B EC for Lemote Yeeloong laptops. mips: loongson64: select MFD_YEELOONG_KB3310B for LEMOTE_MACH2F. mips: loongson64: remove ec_kb3310b.c, use MFD driver. mips: loongson64: remove yeeloong_report_lid_status from pm.c mips: loongson64: register per-board platform drivers for lemote-2f mips: loongson64: Support System Control Interrupts for Lemote Yeeloong. MAINTAINERS: add myself as a maintainer of MIPS/Loongson2 platform code. MAINTAINERS | 16 + .../include/asm/mach-loongson64/loongson.h | 3 + arch/mips/loongson64/Kconfig | 1 + arch/mips/loongson64/common/platform.c | 15 + arch/mips/loongson64/lemote-2f/Makefile | 2 +- arch/mips/loongson64/lemote-2f/ec_kb3310b.c | 129 ------ arch/mips/loongson64/lemote-2f/ec_kb3310b.h | 188 --------- arch/mips/loongson64/lemote-2f/platform.c | 47 +++ arch/mips/loongson64/lemote-2f/pm.c | 38 +- arch/mips/loongson64/lemote-2f/reset.c | 4 +- arch/mips/loongson64/lemote-2f/sci.c | 394 ++++++++++++++++++ drivers/mfd/Kconfig | 10 + drivers/mfd/Makefile | 1 + drivers/mfd/yeeloong_kb3310b.c | 200 +++++++++ include/linux/mfd/yeeloong_kb3310b.h | 211 ++++++++++ 15 files changed, 909 insertions(+), 350 deletions(-) delete mode 100644 arch/mips/loongson64/lemote-2f/ec_kb3310b.c delete mode 100644 arch/mips/loongson64/lemote-2f/ec_kb3310b.h create mode 100644 arch/mips/loongson64/lemote-2f/platform.c create mode 100644 arch/mips/loongson64/lemote-2f/sci.c create mode 100644 drivers/mfd/yeeloong_kb3310b.c create mode 100644 include/linux/mfd/yeeloong_kb3310b.h