From patchwork Fri Feb 7 22:35:16 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Peter Xu X-Patchwork-Id: 11371335 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 40E97109A for ; Fri, 7 Feb 2020 22:35:28 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 1CCF424650 for ; Fri, 7 Feb 2020 22:35:28 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="AOc/2Uws" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727031AbgBGWf1 (ORCPT ); Fri, 7 Feb 2020 17:35:27 -0500 Received: from us-smtp-delivery-1.mimecast.com ([205.139.110.120]:36409 "EHLO us-smtp-1.mimecast.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1727048AbgBGWf1 (ORCPT ); Fri, 7 Feb 2020 17:35:27 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1581114926; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding; bh=ugZBz7enuCINLO2hCs0M9spDUSXUeBZ8X9fYPkjTl9M=; b=AOc/2UwsgyWFumXlcUmRsQ8YnXeZxd8AmFdKV20GYopInCVNjKV1YsFzGsH1Kx/lNK5pSc 69wzGCdve9owXwCsTPAjVeWdhLMjpunhhA6XYWQCfP2TnUH5afAWHF1N1uGAuOuctBVKHP ZpOCyyrQ9WJlM8pyFN9HjuqbTTwTSMM= Received: from mail-qk1-f200.google.com (mail-qk1-f200.google.com [209.85.222.200]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-50-ve_wM522NSavU2sox1SkMw-1; Fri, 07 Feb 2020 17:35:24 -0500 X-MC-Unique: ve_wM522NSavU2sox1SkMw-1 Received: by mail-qk1-f200.google.com with SMTP id r145so485393qke.8 for ; Fri, 07 Feb 2020 14:35:24 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=ugZBz7enuCINLO2hCs0M9spDUSXUeBZ8X9fYPkjTl9M=; b=IiICPsOxA6EPn+Tv/0p+LJvWPBTLNYFVgNaekgO3sRL1kCgsvO5QQsEDjTE8Yjysts bCB0xjhNHAzBRMdc0X146Fq19xgnLUy4NArnYmmsg3aMEzs9qU8sSLEBOBs9c1j0LP4J P7KNQJZRm3K+odnibHEqKb+ruPL14h2ZTs5olOpzo/lIc57c/CHnPtQqJDsq6172PevE pdVvbPsk5MXcXKdSWNz5oUe7PM+OduRMc2Np53zSfw675EeAJMLjvxTD3qph5hmYGNtP 265AbzHV+5dprQlRQmhtjmO98im3Gm4wV1c5sJAgFcBN7WQEsjqobk6+FQRRwovNbAqT LeXw== X-Gm-Message-State: APjAAAWeh8WmgPE3DtZM0HqjSv7/i2n2ENkRBMnBChoqNqcnMIH1Zkf5 Ihg4I5dAMjJQOgY0kI3z8a6KOwH67zz/ONbTGh9ZaodiwiyQl9MH5sUfpPiiZ/0BAUz9Qr5J6Ub p5+fucuxv9MJU3Zot9QM5Cw== X-Received: by 2002:ac8:1205:: with SMTP id x5mr598701qti.238.1581114923526; Fri, 07 Feb 2020 14:35:23 -0800 (PST) X-Google-Smtp-Source: APXvYqzFhVS1bhbCdouqP3dIqYiC7xAeG36OuHcbu/fkXUSHwKqa8FFEiGxaaY0/f//YMJs09H18pw== X-Received: by 2002:ac8:1205:: with SMTP id x5mr598684qti.238.1581114923289; Fri, 07 Feb 2020 14:35:23 -0800 (PST) Received: from xz-x1.redhat.com ([2607:9880:19c8:32::2]) by smtp.gmail.com with ESMTPSA id u12sm2178736qtj.84.2020.02.07.14.35.21 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 07 Feb 2020 14:35:22 -0800 (PST) From: Peter Xu To: linux-kernel@vger.kernel.org, kvm@vger.kernel.org Cc: Sean Christopherson , Paolo Bonzini , linux-mips@vger.kernel.org, peterx@redhat.com, Vitaly Kuznetsov Subject: [PATCH RFC 0/4] KVM: MIPS: Provide arch-specific kvm_flush_remote_tlbs() Date: Fri, 7 Feb 2020 17:35:16 -0500 Message-Id: <20200207223520.735523-1-peterx@redhat.com> X-Mailer: git-send-email 2.24.1 MIME-Version: 1.0 Sender: linux-mips-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-mips@vger.kernel.org [This series is RFC because I don't have MIPS to compile and test] kvm_flush_remote_tlbs() can be arch-specific, by either: - Completely replace kvm_flush_remote_tlbs(), like ARM, who is the only user of CONFIG_HAVE_KVM_ARCH_TLB_FLUSH_ALL so far - Doing something extra before kvm_flush_remote_tlbs(), like MIPS VZ support, however still wants to have the common tlb flush to be part of the process. Could refer to kvm_vz_flush_shadow_all(). Then in MIPS it's awkward to flush remote TLBs: we'll need to call the mips hooks. It's awkward to have different ways to specialize this procedure, especially MIPS cannot use the genenal interface which is quite a pity. It's good to make it a common interface. This patch series removes the 2nd MIPS usage above, and let it also use the common kvm_flush_remote_tlbs() interface. It should be suggested that we always keep kvm_flush_remote_tlbs() be a common entrance for tlb flushing on all archs. This idea comes from the reading of Sean's patchset on dynamic memslot allocation, where a new dirty log specific hook is added for flushing TLBs only for the MIPS code [1]. With this patchset, logically the new hook in that patch can be dropped so we can directly use kvm_flush_remote_tlbs(). TODO: We can even extend another common interface for ranged TLB, but let's see how we think about this series first. Any comment is welcomed, thanks. Peter Xu (4): KVM: Provide kvm_flush_remote_tlbs_common() KVM: MIPS: Drop flush_shadow_memslot() callback KVM: MIPS: Replace all the kvm_flush_remote_tlbs() references KVM: MIPS: Define arch-specific kvm_flush_remote_tlbs() arch/mips/include/asm/kvm_host.h | 7 ------- arch/mips/kvm/Kconfig | 1 + arch/mips/kvm/mips.c | 22 ++++++++++------------ arch/mips/kvm/trap_emul.c | 15 +-------------- arch/mips/kvm/vz.c | 14 ++------------ include/linux/kvm_host.h | 1 + virt/kvm/kvm_main.c | 10 ++++++++-- 7 files changed, 23 insertions(+), 47 deletions(-)