From patchwork Thu May 7 14:59:48 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Ira Weiny X-Patchwork-Id: 11534095 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 11767139F for ; Thu, 7 May 2020 15:00:40 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 03873221F7 for ; Thu, 7 May 2020 15:00:40 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726860AbgEGPAg (ORCPT ); Thu, 7 May 2020 11:00:36 -0400 Received: from mga14.intel.com ([192.55.52.115]:14344 "EHLO mga14.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726268AbgEGPAZ (ORCPT ); Thu, 7 May 2020 11:00:25 -0400 IronPort-SDR: +g5TY5L3ZD/a79EGUOM9SkMvHLm1quMEAsn3Vq+Qje1vBIUzFI7bKue4D9HZ3/HlfoCClMFOld Sj/nIGRJZKBQ== X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga004.jf.intel.com ([10.7.209.38]) by fmsmga103.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 07 May 2020 08:00:07 -0700 IronPort-SDR: b/s7ZWxVBNmG4J2I+k7yxw4bkhrO5iMaLGMsoiM7CLNhxvnQQ99q0hnTaoBLVOL1NGGxx8SlhW 4VsFNQaNuTzg== X-IronPort-AV: E=Sophos;i="5.73,364,1583222400"; d="scan'208";a="407664102" Received: from iweiny-desk2.sc.intel.com (HELO localhost) ([10.3.52.147]) by orsmga004-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 07 May 2020 08:00:06 -0700 From: ira.weiny@intel.com To: linux-kernel@vger.kernel.org, Andrew Morton Cc: Ira Weiny , Thomas Bogendoerfer , "James E.J. Bottomley" , Helge Deller , Benjamin Herrenschmidt , Paul Mackerras , "David S. Miller" , Thomas Gleixner , Ingo Molnar , Borislav Petkov , x86@kernel.org, "H. Peter Anvin" , Dave Hansen , Andy Lutomirski , Peter Zijlstra , Chris Zankel , Max Filippov , Dan Williams , linux-snps-arc@lists.infradead.org, linux-arm-kernel@lists.infradead.org, linux-csky@vger.kernel.org, linux-mips@vger.kernel.org, linux-parisc@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, sparclinux@vger.kernel.org, linux-xtensa@linux-xtensa.org, dri-devel@lists.freedesktop.org, Christian Koenig , Al Viro , Christoph Hellwig Subject: [PATCH V3 00/15] Remove duplicated kmap code Date: Thu, 7 May 2020 07:59:48 -0700 Message-Id: <20200507150004.1423069-1-ira.weiny@intel.com> X-Mailer: git-send-email 2.25.1 MIME-Version: 1.0 Sender: linux-mips-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-mips@vger.kernel.org From: Ira Weiny The kmap infrastructure has been copied almost verbatim to every architecture. This series consolidates obvious duplicated code by defining core functions which call into the architectures only when needed. Some of the k[un]map_atomic() implementations have some similarities but the similarities were not sufficient to warrant further changes. In addition we remove a duplicate implementation of kmap() in DRM. Testing was done by 0day to cover all the architectures I can't readily build/test. --- Changes from V2: Collect review/acks Add kmap_prot consolidation patch from Christoph Add 3 suggested patches from Al Viro Fix include for microblaze Fix static inline for microblaze Changes from V1: Fix bisect-ability Update commit message and fix line lengths Remove unneded kunmap_atomic_high() declarations Remove unneded kmap_atomic_high() declarations collect reviews rebase to 5.7-rc4 Changes from V0: Define kmap_flush_tlb() and make kmap() truely arch independent. Redefine the k[un]map_atomic_* code to call into the architectures for high mem pages Ensure all architectures define kmap_prot, use it appropriately, and define kmap_atomic_prot() Remove drm implementation of kmap_atomic() Ira Weiny (15): arch/kmap: Remove BUG_ON() arch/xtensa: Move kmap build bug out of the way arch/kmap: Remove redundant arch specific kmaps arch/kunmap: Remove duplicate kunmap implementations {x86,powerpc,microblaze}/kmap: Move preempt disable arch/kmap_atomic: Consolidate duplicate code arch/kunmap_atomic: Consolidate duplicate code arch/kmap: Ensure kmap_prot visibility arch/kmap: Don't hard code kmap_prot values arch/kmap: Define kmap_atomic_prot() for all arch's drm: Remove drm specific kmap_atomic code kmap: Remove kmap_atomic_to_page() parisc/kmap: Remove duplicate kmap code sparc: Remove unnecessary includes kmap: Consolidate kmap_prot definitions arch/arc/include/asm/highmem.h | 18 ------- arch/arc/mm/highmem.c | 28 ++-------- arch/arm/include/asm/highmem.h | 9 ---- arch/arm/mm/highmem.c | 35 ++----------- arch/csky/include/asm/highmem.h | 12 +---- arch/csky/mm/highmem.c | 56 ++++---------------- arch/microblaze/include/asm/highmem.h | 27 ---------- arch/microblaze/mm/highmem.c | 16 ++---- arch/microblaze/mm/init.c | 3 -- arch/mips/include/asm/highmem.h | 11 +--- arch/mips/mm/cache.c | 6 +-- arch/mips/mm/highmem.c | 49 +++--------------- arch/nds32/include/asm/highmem.h | 9 ---- arch/nds32/mm/highmem.c | 39 ++------------ arch/parisc/include/asm/cacheflush.h | 30 +---------- arch/powerpc/include/asm/highmem.h | 28 ---------- arch/powerpc/mm/highmem.c | 21 ++------ arch/powerpc/mm/mem.c | 3 -- arch/sparc/include/asm/highmem.h | 25 +-------- arch/sparc/mm/highmem.c | 20 ++------ arch/sparc/mm/io-unit.c | 1 - arch/sparc/mm/iommu.c | 1 - arch/x86/include/asm/fixmap.h | 1 - arch/x86/include/asm/highmem.h | 9 ---- arch/x86/mm/highmem_32.c | 50 ++---------------- arch/xtensa/include/asm/highmem.h | 27 ---------- arch/xtensa/mm/highmem.c | 22 ++++---- drivers/gpu/drm/ttm/ttm_bo_util.c | 56 ++------------------ drivers/gpu/drm/vmwgfx/vmwgfx_blit.c | 16 +++--- include/drm/ttm/ttm_bo_api.h | 4 -- include/linux/highmem.h | 74 ++++++++++++++++++++++++--- 31 files changed, 150 insertions(+), 556 deletions(-)