mbox series

[v3,0/6] DEV_PM_OPS macros rework v3

Message ID 20220107181723.54392-1-paul@crapouillou.net (mailing list archive)
Headers show
Series DEV_PM_OPS macros rework v3 | expand

Message

Paul Cercueil Jan. 7, 2022, 6:17 p.m. UTC
Hi,

A V2 of my patchset that tweaks a bit the *_DEV_PM_OPS() macros that
were introduced recently.

Changes since V2:
* [1/6]: - Keep UNIVERSAL_DEV_PM_OPS() macro deprecated
         - Rework commit message
* [3/6]: - Reorder the code to have non-private macros together in the
           file
	 - Add comment about the necesity to use the new export macro
	   when the dev_pm_ops has to be exported
* [5/6]: Add comment about the necesity to use the new export macro
         when the dev_pm_ops has to be exported

Cheers,
-Paul

Paul Cercueil (6):
  PM: core: Remove DEFINE_UNIVERSAL_DEV_PM_OPS() macro
  PM: core: Remove static qualifier in DEFINE_SIMPLE_DEV_PM_OPS macro
  PM: core: Add EXPORT[_GPL]_SIMPLE_DEV_PM_OPS macros
  PM: runtime: Add DEFINE_RUNTIME_DEV_PM_OPS() macro
  PM: runtime: Add EXPORT[_GPL]_RUNTIME_DEV_PM_OPS macros
  iio: pressure: bmp280: Use new PM macros

 drivers/iio/pressure/bmp280-core.c | 11 ++----
 drivers/iio/pressure/bmp280-i2c.c  |  2 +-
 drivers/iio/pressure/bmp280-spi.c  |  2 +-
 drivers/mmc/host/jz4740_mmc.c      |  4 +--
 drivers/mmc/host/mxcmmc.c          |  2 +-
 include/linux/pm.h                 | 55 ++++++++++++++++++++++--------
 include/linux/pm_runtime.h         | 24 +++++++++++++
 7 files changed, 71 insertions(+), 29 deletions(-)

Comments

Paul Cercueil Jan. 7, 2022, 6:20 p.m. UTC | #1
Le ven., janv. 7 2022 at 18:17:17 +0000, Paul Cercueil 
<paul@crapouillou.net> a écrit :
> Hi,
> 
> A V2 of my patchset that tweaks a bit the *_DEV_PM_OPS() macros that
> were introduced recently.

I meant V3 here. Bad copy-paste.

-Paul
Paul Cercueil Jan. 16, 2022, 12:05 p.m. UTC | #2
Hi Rafael,

Could patches [1/6] and [2/6] make it to 5.17-rc1, or at least -rc2?

I'm afraid that if these two have to wait for the 5.18 cycle, then I'll 
have more drivers to fix later.

Should I add a Fixes tag maybe?

Cheers,
-Paul


Le ven., janv. 7 2022 at 18:17:17 +0000, Paul Cercueil 
<paul@crapouillou.net> a écrit :
> Hi,
> 
> A V2 of my patchset that tweaks a bit the *_DEV_PM_OPS() macros that
> were introduced recently.
> 
> Changes since V2:
> * [1/6]: - Keep UNIVERSAL_DEV_PM_OPS() macro deprecated
>          - Rework commit message
> * [3/6]: - Reorder the code to have non-private macros together in the
>            file
> 	 - Add comment about the necesity to use the new export macro
> 	   when the dev_pm_ops has to be exported
> * [5/6]: Add comment about the necesity to use the new export macro
>          when the dev_pm_ops has to be exported
> 
> Cheers,
> -Paul
> 
> Paul Cercueil (6):
>   PM: core: Remove DEFINE_UNIVERSAL_DEV_PM_OPS() macro
>   PM: core: Remove static qualifier in DEFINE_SIMPLE_DEV_PM_OPS macro
>   PM: core: Add EXPORT[_GPL]_SIMPLE_DEV_PM_OPS macros
>   PM: runtime: Add DEFINE_RUNTIME_DEV_PM_OPS() macro
>   PM: runtime: Add EXPORT[_GPL]_RUNTIME_DEV_PM_OPS macros
>   iio: pressure: bmp280: Use new PM macros
> 
>  drivers/iio/pressure/bmp280-core.c | 11 ++----
>  drivers/iio/pressure/bmp280-i2c.c  |  2 +-
>  drivers/iio/pressure/bmp280-spi.c  |  2 +-
>  drivers/mmc/host/jz4740_mmc.c      |  4 +--
>  drivers/mmc/host/mxcmmc.c          |  2 +-
>  include/linux/pm.h                 | 55 
> ++++++++++++++++++++++--------
>  include/linux/pm_runtime.h         | 24 +++++++++++++
>  7 files changed, 71 insertions(+), 29 deletions(-)
> 
> --
> 2.34.1
>
Rafael J. Wysocki Jan. 17, 2022, 1:37 p.m. UTC | #3
Hi,

On Sun, Jan 16, 2022 at 1:05 PM Paul Cercueil <paul@crapouillou.net> wrote:
>
> Hi Rafael,
>
> Could patches [1/6] and [2/6] make it to 5.17-rc1, or at least -rc2?

Yes.  I'm going to send a PR with the whole series later today.

> I'm afraid that if these two have to wait for the 5.18 cycle, then I'll
> have more drivers to fix later.
>
> Should I add a Fixes tag maybe?

No need, thanks!

> Le ven., janv. 7 2022 at 18:17:17 +0000, Paul Cercueil
> <paul@crapouillou.net> a écrit :
> > Hi,
> >
> > A V2 of my patchset that tweaks a bit the *_DEV_PM_OPS() macros that
> > were introduced recently.
> >
> > Changes since V2:
> > * [1/6]: - Keep UNIVERSAL_DEV_PM_OPS() macro deprecated
> >          - Rework commit message
> > * [3/6]: - Reorder the code to have non-private macros together in the
> >            file
> >        - Add comment about the necesity to use the new export macro
> >          when the dev_pm_ops has to be exported
> > * [5/6]: Add comment about the necesity to use the new export macro
> >          when the dev_pm_ops has to be exported
> >
> > Cheers,
> > -Paul
> >
> > Paul Cercueil (6):
> >   PM: core: Remove DEFINE_UNIVERSAL_DEV_PM_OPS() macro
> >   PM: core: Remove static qualifier in DEFINE_SIMPLE_DEV_PM_OPS macro
> >   PM: core: Add EXPORT[_GPL]_SIMPLE_DEV_PM_OPS macros
> >   PM: runtime: Add DEFINE_RUNTIME_DEV_PM_OPS() macro
> >   PM: runtime: Add EXPORT[_GPL]_RUNTIME_DEV_PM_OPS macros
> >   iio: pressure: bmp280: Use new PM macros
> >
> >  drivers/iio/pressure/bmp280-core.c | 11 ++----
> >  drivers/iio/pressure/bmp280-i2c.c  |  2 +-
> >  drivers/iio/pressure/bmp280-spi.c  |  2 +-
> >  drivers/mmc/host/jz4740_mmc.c      |  4 +--
> >  drivers/mmc/host/mxcmmc.c          |  2 +-
> >  include/linux/pm.h                 | 55
> > ++++++++++++++++++++++--------
> >  include/linux/pm_runtime.h         | 24 +++++++++++++
> >  7 files changed, 71 insertions(+), 29 deletions(-)
> >
> > --
> > 2.34.1
> >
>
>
Paul Cercueil Jan. 17, 2022, 4:57 p.m. UTC | #4
Le lun., janv. 17 2022 at 14:37:45 +0100, Rafael J. Wysocki 
<rafael@kernel.org> a écrit :
> Hi,
> 
> On Sun, Jan 16, 2022 at 1:05 PM Paul Cercueil <paul@crapouillou.net> 
> wrote:
>> 
>>  Hi Rafael,
>> 
>>  Could patches [1/6] and [2/6] make it to 5.17-rc1, or at least -rc2?
> 
> Yes.  I'm going to send a PR with the whole series later today.

Ok, perfect then. I saw my previous PM patches in upstream/master and 
assumed that you already sent your PR.

Cheers,
-Paul

> 
>>  I'm afraid that if these two have to wait for the 5.18 cycle, then 
>> I'll
>>  have more drivers to fix later.
>> 
>>  Should I add a Fixes tag maybe?
> 
> No need, thanks!
> 
>>  Le ven., janv. 7 2022 at 18:17:17 +0000, Paul Cercueil
>>  <paul@crapouillou.net> a écrit :
>>  > Hi,
>>  >
>>  > A V2 of my patchset that tweaks a bit the *_DEV_PM_OPS() macros 
>> that
>>  > were introduced recently.
>>  >
>>  > Changes since V2:
>>  > * [1/6]: - Keep UNIVERSAL_DEV_PM_OPS() macro deprecated
>>  >          - Rework commit message
>>  > * [3/6]: - Reorder the code to have non-private macros together 
>> in the
>>  >            file
>>  >        - Add comment about the necesity to use the new export 
>> macro
>>  >          when the dev_pm_ops has to be exported
>>  > * [5/6]: Add comment about the necesity to use the new export 
>> macro
>>  >          when the dev_pm_ops has to be exported
>>  >
>>  > Cheers,
>>  > -Paul
>>  >
>>  > Paul Cercueil (6):
>>  >   PM: core: Remove DEFINE_UNIVERSAL_DEV_PM_OPS() macro
>>  >   PM: core: Remove static qualifier in DEFINE_SIMPLE_DEV_PM_OPS 
>> macro
>>  >   PM: core: Add EXPORT[_GPL]_SIMPLE_DEV_PM_OPS macros
>>  >   PM: runtime: Add DEFINE_RUNTIME_DEV_PM_OPS() macro
>>  >   PM: runtime: Add EXPORT[_GPL]_RUNTIME_DEV_PM_OPS macros
>>  >   iio: pressure: bmp280: Use new PM macros
>>  >
>>  >  drivers/iio/pressure/bmp280-core.c | 11 ++----
>>  >  drivers/iio/pressure/bmp280-i2c.c  |  2 +-
>>  >  drivers/iio/pressure/bmp280-spi.c  |  2 +-
>>  >  drivers/mmc/host/jz4740_mmc.c      |  4 +--
>>  >  drivers/mmc/host/mxcmmc.c          |  2 +-
>>  >  include/linux/pm.h                 | 55
>>  > ++++++++++++++++++++++--------
>>  >  include/linux/pm_runtime.h         | 24 +++++++++++++
>>  >  7 files changed, 71 insertions(+), 29 deletions(-)
>>  >
>>  > --
>>  > 2.34.1
>>  >
>> 
>>