From patchwork Fri Jun 24 14:18:44 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Serge Semin X-Patchwork-Id: 12894640 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id B15D9C433EF for ; Fri, 24 Jun 2022 14:35:51 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232619AbiFXOft (ORCPT ); Fri, 24 Jun 2022 10:35:49 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:35134 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232616AbiFXOfN (ORCPT ); Fri, 24 Jun 2022 10:35:13 -0400 Received: from mail.baikalelectronics.com (mail.baikalelectronics.com [87.245.175.230]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id 53F7456773; Fri, 24 Jun 2022 07:34:52 -0700 (PDT) Received: from mail (mail.baikal.int [192.168.51.25]) by mail.baikalelectronics.com (Postfix) with ESMTP id E5D8716C8; Fri, 24 Jun 2022 17:20:18 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 mail.baikalelectronics.com E5D8716C8 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=baikalelectronics.ru; s=mail; t=1656080419; bh=YrWLm+KZr1EyqRgLsnSLO9iR2EG0j+IlZGICVjODVIw=; h=From:To:CC:Subject:Date:From; b=BJJOnystZUcVnJQMlgxTP9kwPSGW+RdQo75pSPf09HWs5KK4yU4zgnJ8qkNjk0knT lxUHBM1GB2kUKW12ytZAHjC3CVFsH3JAbWpkFHuzB5VQeCNOZHTK066ZZV8Lo/7F/J rS0vIiNGv4Pn57IiwK5TdwupCmE+BUj7+5DrFz3M= Received: from localhost (192.168.53.207) by mail (192.168.51.25) with Microsoft SMTP Server (TLS) id 15.0.1395.4; Fri, 24 Jun 2022 17:18:59 +0300 From: Serge Semin To: Stephen Boyd , Philipp Zabel , Michael Turquette CC: Serge Semin , Serge Semin , Alexey Malahov , Pavel Parkhomenko , Thomas Bogendoerfer , , , Subject: [PATCH RESEND v5 0/8] clk/resets: baikal-t1: Add DDR/PCIe resets and xGMAC/SATA fixes Date: Fri, 24 Jun 2022 17:18:44 +0300 Message-ID: <20220624141853.7417-1-Sergey.Semin@baikalelectronics.ru> MIME-Version: 1.0 X-ClientProxiedBy: MAIL.baikal.int (192.168.51.25) To mail (192.168.51.25) Precedence: bulk List-ID: X-Mailing-List: linux-mips@vger.kernel.org Folks! It has been over four months since the first series submission for review. Please merge it in. Short summary regarding this patchset. The series starts from fixing a wrong semantic of the device managed optional exclusive bulk reset control getter. Then we suggest a fix of the clocks glitching cause by the Renesas 5P49V6901 chip in some circumstances. Afterwards a few more modifications are introduced to finally finish the Baikal-T1 CCU unit support up and prepare the code before adding the Baikal-T1 PCIe/xGMAC support. First of all it turned out I specified wrong DW xGMAC PTP reference clock divider in my initial patches. It must be 8, not 10. Secondly I was wrong to add a joint xGMAC Ref and PTP clock instead of having them separately defined. The SoC manual describes these clocks as separate fixed clock wrappers. Finally in order to close the SoC clock/reset support up we need to add the DDR and PCIe interfaces reset controls support. It's done in two steps. First I've moved the reset-controls-related code into a dedicated module. Then the DDR/PCIe reset-control functionality is added. As the series finalization we've decided to convert the Baikal-T1 clock/reset source drivers to mainly being the platform device driver and pre-initialize the basic clocks only at the early kernel boot stages. Link: https://lore.kernel.org/linux-pci/20220324010905.15589-1-Sergey.Semin@baikalelectronics.ru/ Changelog v2: - Resubmit the series with adding @Philipp to the list of the recipients. Link: https://lore.kernel.org/linux-pci/20220330144320.27039-1-Sergey.Semin@baikalelectronics.ru/ Changelog v3: - No comments. Just resend the series. - Rebased from v5.17 onto v5.18-rc3. Link: https://lore.kernel.org/linux-clk/20220503205722.24755-1-Sergey.Semin@baikalelectronics.ru/ Changelog v4: - Completely split the CCU Dividers and Resets functionality up. (@Stephen) - Add a new fixes patch: "clk: baikal-t1: Actually enable SATA internal ref clock". - Add a new fixes patch: "reset: Fix devm bulk optional exclusive control getter". - Add a new fixes patch: "clk: vc5: Fix 5P49V6901 outputs disabling when enabling FOD". - Add a new feagure patch: "clk: baikal-t1: Convert to platform device driver". - Change the internal clock ID to the XGMAC-referred name. - Rebase onto the kernel v5.18. Link: https://lore.kernel.org/lkml/20220610072124.8714-1-Sergey.Semin@baikalelectronics.ru/ Changelog v5: - Just resend. - Rebase onto the kernel v5.19-rcX. Signed-off-by: Serge Semin Cc: Alexey Malahov Cc: Pavel Parkhomenko Cc: Thomas Bogendoerfer Cc: linux-clk@vger.kernel.org Cc: linux-mips@vger.kernel.org Cc: linux-kernel@vger.kernel.org Serge Semin (8): reset: Fix devm bulk optional exclusive control getter clk: vc5: Fix 5P49V6901 outputs disabling when enabling FOD clk: baikal-t1: Fix invalid xGMAC PTP clock divider clk: baikal-t1: Add shared xGMAC ref/ptp clocks internal parent clk: baikal-t1: Add SATA internal ref clock buffer clk: baikal-t1: Move reset-controls code into a dedicated module clk: baikal-t1: Add DDR/PCIe directly controlled resets support clk: baikal-t1: Convert to platform device driver drivers/clk/baikal-t1/Kconfig | 12 +- drivers/clk/baikal-t1/Makefile | 1 + drivers/clk/baikal-t1/ccu-div.c | 84 +++++++-- drivers/clk/baikal-t1/ccu-div.h | 17 +- drivers/clk/baikal-t1/ccu-pll.h | 8 + drivers/clk/baikal-t1/ccu-rst.c | 99 ++++++++++ drivers/clk/baikal-t1/ccu-rst.h | 79 ++++++++ drivers/clk/baikal-t1/clk-ccu-div.c | 272 +++++++++++++++++----------- drivers/clk/baikal-t1/clk-ccu-pll.c | 128 ++++++++++--- drivers/clk/baikal-t1/clk-ccu-rst.c | 257 ++++++++++++++++++++++++++ drivers/clk/clk-versaclock5.c | 2 +- include/dt-bindings/reset/bt1-ccu.h | 9 + include/linux/reset.h | 2 +- 13 files changed, 814 insertions(+), 156 deletions(-) create mode 100644 drivers/clk/baikal-t1/ccu-rst.c create mode 100644 drivers/clk/baikal-t1/ccu-rst.h create mode 100644 drivers/clk/baikal-t1/clk-ccu-rst.c