[0/6] drm/ingenic: JZ4760(B) support and random changes

Message

Paul Cercueil July 8, 2022, 8:54 p.m. UTC

Hi,

A small set of changes to the ingenic-drm driver.

The most notable thing is that ingenic-ipu is now its own platform
driver.

Cheers,
-Paul

Paul Cercueil (6):
  dt-bindings/display: ingenic: Add compatible string for the JZ4760(B)
  drm/ingenic: Fix MODULE_LICENSE() string
  drm/ingenic: Add support for the JZ4760(B)
  drm/ingenic: Don't request full modeset if property is not modified
  drm/ingenic: Make IPU driver its own module
  drm/ingenic: Use the new PM macros

 .../bindings/display/ingenic,lcd.yaml         |  2 +
 drivers/gpu/drm/ingenic/Kconfig               |  2 +-
 drivers/gpu/drm/ingenic/Makefile              |  2 +-
 drivers/gpu/drm/ingenic/ingenic-drm-drv.c     | 72 +++++++++++--------
 drivers/gpu/drm/ingenic/ingenic-drm.h         |  3 -
 drivers/gpu/drm/ingenic/ingenic-ipu.c         | 10 ++-
 6 files changed, 53 insertions(+), 38 deletions(-)

Comments

Sam Ravnborg July 9, 2022, 8:31 a.m. UTC | #1

Hi Paul,

On Fri, Jul 08, 2022 at 09:54:00PM +0100, Paul Cercueil wrote:
> Hi,
> 
> A small set of changes to the ingenic-drm driver.
> 
> The most notable thing is that ingenic-ipu is now its own platform
> driver.
It would be nice to know what is achieved by this change, I could
see the code being a tad simpler, but the cost was more EXPORTs.

With the added explanation, which you can add when applying, all patches are:
Acked-by: Sam Ravnborg <[e-mail]>

	Sam

Paul Cercueil July 9, 2022, 10:43 a.m. UTC | #2

Hi Sam,

Le sam., juil. 9 2022 at 10:31:45 +0200, Sam Ravnborg 
<[e-mail]> a écrit :
> Hi Paul,
> 
> On Fri, Jul 08, 2022 at 09:54:00PM +0100, Paul Cercueil wrote:
>>  Hi,
>> 
>>  A small set of changes to the ingenic-drm driver.
>> 
>>  The most notable thing is that ingenic-ipu is now its own platform
>>  driver.
> It would be nice to know what is achieved by this change, I could
> see the code being a tad simpler, but the cost was more EXPORTs.

Well… we now have two separate drivers instead of one driver that 
deals with two different devices. I thought the benefit here was 
obvious.

> With the added explanation, which you can add when applying, all 
> patches are:
> Acked-by: Sam Ravnborg <[e-mail]>

I'll apply the other ones and keep this patch for a V2. You made me 
realize that I could use namespaced exports instead of global ones.

Thanks,
-Paul