From patchwork Tue Jul 18 14:37:13 2023
Content-Type: text/plain; charset="utf-8"
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
X-Patchwork-Submitter: "Maciej W. Rozycki" <macro@orcam.me.uk>
X-Patchwork-Id: 13317379
Return-Path: <linux-mips-owner@vger.kernel.org>
X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on
	aws-us-west-2-korg-lkml-1.web.codeaurora.org
Received: from vger.kernel.org (vger.kernel.org [23.128.96.18])
	by smtp.lore.kernel.org (Postfix) with ESMTP id B0ED8EB64DC
	for <linux-mips@archiver.kernel.org>; Tue, 18 Jul 2023 14:37:17 +0000 (UTC)
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S230221AbjGROhQ (ORCPT <rfc822;linux-mips@archiver.kernel.org>);
        Tue, 18 Jul 2023 10:37:16 -0400
Received: from lindbergh.monkeyblade.net ([23.128.96.19]:55138 "EHLO
        lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S229512AbjGROhQ (ORCPT
        <rfc822;linux-mips@vger.kernel.org>); Tue, 18 Jul 2023 10:37:16 -0400
Received: from angie.orcam.me.uk (angie.orcam.me.uk [78.133.224.34])
        by lindbergh.monkeyblade.net (Postfix) with ESMTP id 465E1113;
        Tue, 18 Jul 2023 07:37:14 -0700 (PDT)
Received: by angie.orcam.me.uk (Postfix, from userid 500)
        id 20E5E92009C; Tue, 18 Jul 2023 16:37:13 +0200 (CEST)
Received: from localhost (localhost [127.0.0.1])
        by angie.orcam.me.uk (Postfix) with ESMTP id 1AFCA92009B;
        Tue, 18 Jul 2023 15:37:13 +0100 (BST)
Date: Tue, 18 Jul 2023 15:37:13 +0100 (BST)
From: "Maciej W. Rozycki" <macro@orcam.me.uk>
To: Thomas Bogendoerfer <tsbogend@alpha.franken.de>
cc: Jan-Benedict Glaw <jbglaw@lug-owl.de>,
        Guillaume Tucker <guillaume.tucker@collabora.com>,
        Huacai Chen <chenhuacai@loongson.cn>,
        linux-mips@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: [PATCH 0/3] MIPS: Fix build issues from the introduction of
 `need-compiler'
Message-ID: <alpine.DEB.2.21.2307180025120.62448@angie.orcam.me.uk>
User-Agent: Alpine 2.21 (DEB 202 2017-01-01)
MIME-Version: 1.0
Precedence: bulk
List-ID: <linux-mips.vger.kernel.org>
X-Mailing-List: linux-mips@vger.kernel.org

Hi,

 With the addition of the `need-compiler' variable the `Makefile.compiler' 
fragment is not included with no-build targets such as `modules_install', 
which in turn means $(call cc-option,), etc. are no-ops with these targets 
and any attempt to evaluate these function calls causes all kinds of weird 
behaviour to happen.

 The solution is to avoid making these calls in the first place, as they 
are surely irrelevant where the compiler is not going to be otherwise 
invoked.  This small patch series fixes two places known-affected in the 
MIPS Makefile fragment and also included a follow-up revert of an earlier 
misguided attempt.  See individual change descriptions for details.

 Verified with `decstation_64_defconfig' and `fuloong2e_defconfig' using 
`modules_install'.  Please apply.

  Maciej