diff mbox series

[08/41] drivers: tty: serial: sb1250-duart: fix checkpatch warning on printk()

Message ID	1556369542-13247-9-git-send-email-info@metux.net (mailing list archive)
State	Not Applicable
Headers	show Return-Path: <linux-mips-owner@kernel.org> From: "Enrico Weigelt, metux IT consult" <info@metux.net> To: linux-kernel@vger.kernel.org Cc: gregkh@linuxfoundation.org, andrew@aj.id.au, andriy.shevchenko@linux.intel.com, macro@linux-mips.org, vz@mleia.com, slemieux.tyco@gmail.com, khilman@baylibre.com, liviu.dudau@arm.com, sudeep.holla@arm.com, lorenzo.pieralisi@arm.com, davem@davemloft.net, jacmet@sunsite.dk, linux@prisktech.co.nz, matthias.bgg@gmail.com, linux-mips@vger.kernel.org, linux-serial@vger.kernel.org, linux-ia64@vger.kernel.org, linux-amlogic@lists.infradead.org, linuxppc-dev@lists.ozlabs.org, sparclinux@vger.kernel.org Subject: [PATCH 08/41] drivers: tty: serial: sb1250-duart: fix checkpatch warning on printk() Date: Sat, 27 Apr 2019 14:51:49 +0200 Message-Id: <1556369542-13247-9-git-send-email-info@metux.net> In-Reply-To: <1556369542-13247-1-git-send-email-info@metux.net> References: <1556369542-13247-1-git-send-email-info@metux.net> Sender: linux-mips-owner@vger.kernel.org Precedence: bulk
Series	[01/41] drivers: tty: serial: dz: use dev_err() instead of printk() \| expand [01/41] drivers: tty: serial: dz: use dev_err() instead of printk() [02/41] drivers: tty: serial: dz: include <linux/io.h> instead of <asm/io.h> [03/41] drivers: tty: serial: dz: fix missing parentheses [04/41] drivers: tty: serial: dz: fix use fix bare 'unsigned' [05/41] drivers: tty: serial: dz: use pr_info() instead of incomplete printk() [06/41] drivers: tty: serial: sb1250-duart: use dev_err() instead of printk() [07/41] drivers: tty: serial: sb1250-duart: include <linux/io.h> instead of <asm/io.h> [08/41] drivers: tty: serial: sb1250-duart: fix checkpatch warning on printk() [09/41] drivers: tty: serial: sb1250-duart: fill mapsize and use it [10/41] drivers: tty: serial: sb1250-duart: fix missing parentheses [11/41] drivers: tty: serial: sb1250-duart: fix formatting error [12/41] drivers: tty: serial: uartlite: use dev_dbg() instead of pr_debug() [13/41] drivers: tty: serial: uartlite: fill mapsize and use it [14/41] drivers: tty: serial: uartlite: remove unnecessary braces [15/41] drivers: tty: serial: uartlite: fix use fix bare 'unsigned' [16/41] drivers: tty: serial: uartlite: fix overlong lines [17/41] drivers: tty: serial: apbuart: fix logging calls [18/41] drivers: tty: serial: apbuart: use dev_info() instead of printk() [19/41] drivers: tty: serial: apbuart: fix code formatting [20/41] drivers: tty: serial: cpm_uart: use dev_err()/dev_warn() instead of printk() [21/41] drivers: tty: serial: cpm_uart: fix includes [22/41] drivers: tty: serial: cpm_uart: fix logging calls [23/41] drivers: tty: serial: cpm_uart: fix styling issues [24/41] drivers: tty: serial: timbuart: use dev_err() instead of printk() [25/41] drivers: tty: serial: timbuart: fix formatting issues [26/41] drivers: tty: serial: sunzilog: use dev_info() instead of printk() [27/41] drivers: tty: serial: sunzilog: fix formatting issues [28/41] drivers: tty: serial: sunzilog: fix includes [29/41] drivers: tty: serial: sunzilog: cleanup logging [30/41] drivers: tty: serial: ioc4_serial: use dev_warn() instead of printk() [31/41] drivers: tty: serial: ioc4_serial: use pr_*() instead of printk() [32/41] drivers: tty: serial: 21285: define's for address/size, use mapsize field [33/41] drivers: tty: serial: zs: use dev_err() instead of printk() [34/41] drivers: tty: serial: zs: fill mapsize and use it [35/41] drivers: tty: serial: 8250: add mapsize to platform data [36/41] drivers: tty: serial: 8250: store mmio resource size in port struct [37/41] drivers: tty: serial: 8250: simplify io resource size computation [38/41] drivers: tty: serial: xilinx_uartps: fill mapsize and use it [39/41] drivers: tty: serial: pmac_zilog: fill mapsize and use it [40/41] drivers: tty: serial: helper for setting mmio range [41/41] drivers: tty: serial: lpc32xx_hs: fill mapsize and use it

Commit Message

Enrico Weigelt, metux IT consult April 27, 2019, 12:51 p.m. UTC

checkpatch complaints:

    WARNING: printk() should include KERN_<LEVEL> facility level
    #698: FILE: drivers/tty/serial/sb1250-duart.c:698:
    +		printk(err);

    WARNING: printk() should include KERN_<LEVEL> facility level
    #706: FILE: drivers/tty/serial/sb1250-duart.c:706:
    +			printk(err);

Even though it's a false alarm here (the string is already prefixed
w/ KERN_ERR), it's nicer to use pr_err() here, which also makes
checkpatch happy.

Signed-off-by: Enrico Weigelt <info@metux.net>
---
 drivers/tty/serial/sb1250-duart.c | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff mbox series

Patch

diff --git a/drivers/tty/serial/sb1250-duart.c b/drivers/tty/serial/sb1250-duart.c
index b4342c8..227af87 100644
--- a/drivers/tty/serial/sb1250-duart.c
+++ b/drivers/tty/serial/sb1250-duart.c
@@ -689,13 +689,13 @@  static int sbd_map_port(struct uart_port *uport)
 
 static int sbd_request_port(struct uart_port *uport)
 {
-	const char *err = KERN_ERR "sbd: Unable to reserve MMIO resource\n";
+	const char *err = "sbd: Unable to reserve MMIO resource\n";
 	struct sbd_duart *duart = to_sport(uport)->duart;
 	int ret = 0;
 
 	if (!request_mem_region(uport->mapbase, DUART_CHANREG_SPACING,
 				"sb1250-duart")) {
-		printk(err);
+		pr_err(err);
 		return -EBUSY;
 	}
 	refcount_inc(&duart->map_guard);
@@ -703,7 +703,7 @@  static int sbd_request_port(struct uart_port *uport)
 		if (!request_mem_region(duart->mapctrl, DUART_CHANREG_SPACING,
 					"sb1250-duart")) {
 			refcount_dec(&duart->map_guard);
-			printk(err);
+			pr_err(err);
 			ret = -EBUSY;
 		}
 	}