| Message ID | 1589508901-18077-1-git-send-email-yangtiezhu@loongson.cn (mailing list archive) |
|---|---|
| State | Superseded |
| Headers | show |
| Series | [1/2] MIPS: Loongson: Fix fatal error during GPU init | expand |
于 2020年5月15日 GMT+08:00 上午10:15:00, Tiezhu Yang <yangtiezhu@loongson.cn> 写到: >When ATI Radeon graphics card has been compiled directly into the kernel >instead of as a module, we should make sure the firmware for the model >(check available ones in /lib/firmware/radeon) is built-in to the kernel >as well, otherwise there exists the following fatal error during GPU init, >change CONFIG_DRM_RADEON=y to CONFIG_DRM_RADEON=m to fix it. > The commit message looks shocking. You'd better reword it as "MIPS: Loongson64: Mark GPU driver as module in Kconfig" Thanks.
On 05/15/2020 10:33 AM, Jiaxun Yang wrote: > > 于 2020年5月15日 GMT+08:00 上午10:15:00, Tiezhu Yang <yangtiezhu@loongson.cn> 写到: >> When ATI Radeon graphics card has been compiled directly into the kernel >> instead of as a module, we should make sure the firmware for the model >> (check available ones in /lib/firmware/radeon) is built-in to the kernel >> as well, otherwise there exists the following fatal error during GPU init, >> change CONFIG_DRM_RADEON=y to CONFIG_DRM_RADEON=m to fix it. >> > The commit message looks shocking. > > You'd better reword it as "MIPS: Loongson64: Mark GPU driver as module in Kconfig" OK, I will modify the patch subject and send v2. > > Thanks.
于 2020年5月15日 GMT+08:00 上午11:09:56, Tiezhu Yang <yangtiezhu@loongson.cn> 写到: >On 05/15/2020 10:33 AM, Jiaxun Yang wrote: >> >> 于 2020年5月15日 GMT+08:00 上午10:15:00, Tiezhu Yang <yangtiezhu@loongson.cn> 写到: >>> When ATI Radeon graphics card has been compiled directly into the kernel >>> instead of as a module, we should make sure the firmware for the model >>> (check available ones in /lib/firmware/radeon) is built-in to the kernel >>> as well, otherwise there exists the following fatal error during GPU init, >>> change CONFIG_DRM_RADEON=y to CONFIG_DRM_RADEON=m to fix it. >>> >> The commit message looks shocking. >> >> You'd better reword it as "MIPS: Loongson64: Mark GPU driver as module in Kconfig" > >OK, I will modify the patch subject and send v2. Sorry I meant defconfig not Kconfig. > >> >> Thanks. >
Hello! On 15.05.2020 5:15, Tiezhu Yang wrote: > When ATI Radeon graphics card has been compiled directly into the kernel ^ driver > instead of as a module, we should make sure the firmware for the model > (check available ones in /lib/firmware/radeon) is built-in to the kernel > as well, otherwise there exists the following fatal error during GPU init, > change CONFIG_DRM_RADEON=y to CONFIG_DRM_RADEON=m to fix it. > > [ 1.900997] [drm] Loading RS780 Microcode > [ 1.905077] radeon 0000:01:05.0: Direct firmware load for radeon/RS780_pfp.bin failed with error -2 > [ 1.914140] r600_cp: Failed to load firmware "radeon/RS780_pfp.bin" > [ 1.920405] [drm:r600_init] *ERROR* Failed to load firmware! > [ 1.926069] radeon 0000:01:05.0: Fatal error during GPU init > [ 1.931729] [drm] radeon: finishing device. > > Fixes: 024e6a8b5bb1 ("MIPS: Loongson: Add a Loongson-3 default config file") > Signed-off-by: Tiezhu Yang <yangtiezhu@loongson.cn> [...] MBR, Sergei
On 05/15/2020 04:51 PM, Sergei Shtylyov wrote: > Hello! > > On 15.05.2020 5:15, Tiezhu Yang wrote: > >> When ATI Radeon graphics card has been compiled directly into the kernel > ^ driver Hi Sergei, Thanks for your review, I have been sent v2 with the updated commit message: https://lore.kernel.org/patchwork/patch/1242218/ Thanks, Tiezhu Yang > >> instead of as a module, we should make sure the firmware for the model >> (check available ones in /lib/firmware/radeon) is built-in to the kernel >> as well, otherwise there exists the following fatal error during GPU >> init, >> change CONFIG_DRM_RADEON=y to CONFIG_DRM_RADEON=m to fix it. >> >> [ 1.900997] [drm] Loading RS780 Microcode >> [ 1.905077] radeon 0000:01:05.0: Direct firmware load for >> radeon/RS780_pfp.bin failed with error -2 >> [ 1.914140] r600_cp: Failed to load firmware "radeon/RS780_pfp.bin" >> [ 1.920405] [drm:r600_init] *ERROR* Failed to load firmware! >> [ 1.926069] radeon 0000:01:05.0: Fatal error during GPU init >> [ 1.931729] [drm] radeon: finishing device. >> >> Fixes: 024e6a8b5bb1 ("MIPS: Loongson: Add a Loongson-3 default config >> file") >> Signed-off-by: Tiezhu Yang <yangtiezhu@loongson.cn> > [...] > > MBR, Sergei
diff --git a/arch/mips/configs/loongson3_defconfig b/arch/mips/configs/loongson3_defconfig index 6768c16..4df2434 100644 --- a/arch/mips/configs/loongson3_defconfig +++ b/arch/mips/configs/loongson3_defconfig @@ -230,7 +230,7 @@ CONFIG_MEDIA_CAMERA_SUPPORT=y CONFIG_MEDIA_USB_SUPPORT=y CONFIG_USB_VIDEO_CLASS=m CONFIG_DRM=y -CONFIG_DRM_RADEON=y +CONFIG_DRM_RADEON=m CONFIG_FB_RADEON=y CONFIG_LCD_CLASS_DEVICE=y CONFIG_LCD_PLATFORM=m
When ATI Radeon graphics card has been compiled directly into the kernel instead of as a module, we should make sure the firmware for the model (check available ones in /lib/firmware/radeon) is built-in to the kernel as well, otherwise there exists the following fatal error during GPU init, change CONFIG_DRM_RADEON=y to CONFIG_DRM_RADEON=m to fix it. [ 1.900997] [drm] Loading RS780 Microcode [ 1.905077] radeon 0000:01:05.0: Direct firmware load for radeon/RS780_pfp.bin failed with error -2 [ 1.914140] r600_cp: Failed to load firmware "radeon/RS780_pfp.bin" [ 1.920405] [drm:r600_init] *ERROR* Failed to load firmware! [ 1.926069] radeon 0000:01:05.0: Fatal error during GPU init [ 1.931729] [drm] radeon: finishing device. Fixes: 024e6a8b5bb1 ("MIPS: Loongson: Add a Loongson-3 default config file") Signed-off-by: Tiezhu Yang <yangtiezhu@loongson.cn> --- arch/mips/configs/loongson3_defconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)