| Message ID | 1589891291-7030-1-git-send-email-yangtiezhu@loongson.cn (mailing list archive) |
|---|---|
| State | Accepted |
| Headers | show |
| Series | MIPS: SGI-IP27: Remove duplicated include in ip27-timer.c | expand |
On Tue, May 19, 2020 at 08:28:11PM +0800, Tiezhu Yang wrote: > After commit 9d0aaf98dc24 ("MIPS: SGI-IP27: Move all shared IP27 > declarations to ip27-common.h"), ip27-common.h is included more > than once in ip27-timer.c, remove it. > > Signed-off-by: Tiezhu Yang <yangtiezhu@loongson.cn> applied to mips-next. I only removed the second #include. If you want to clean this up further the includes and comment about ioc3_init() could be removed as well. Thomas.
On 05/20/2020 12:03 AM, Thomas Bogendoerfer wrote: > On Tue, May 19, 2020 at 08:28:11PM +0800, Tiezhu Yang wrote: >> After commit 9d0aaf98dc24 ("MIPS: SGI-IP27: Move all shared IP27 >> declarations to ip27-common.h"), ip27-common.h is included more >> than once in ip27-timer.c, remove it. >> >> Signed-off-by: Tiezhu Yang <yangtiezhu@loongson.cn> > applied to mips-next. I only removed the second #include. If you > want to clean this up further the includes and comment about > ioc3_init() could be removed as well. OK, thank you. I will do it later. Thanks, Tiezhu Yang > > Thomas. >
diff --git a/arch/mips/sgi-ip27/ip27-timer.c b/arch/mips/sgi-ip27/ip27-timer.c index 61f3565..6513e6a 100644 --- a/arch/mips/sgi-ip27/ip27-timer.c +++ b/arch/mips/sgi-ip27/ip27-timer.c @@ -27,8 +27,6 @@ #include <asm/sn/addrs.h> #include <asm/sn/agent.h> -#include "ip27-common.h" - #define TICK_SIZE (tick_nsec / 1000) /* Includes for ioc3_init(). */
After commit 9d0aaf98dc24 ("MIPS: SGI-IP27: Move all shared IP27 declarations to ip27-common.h"), ip27-common.h is included more than once in ip27-timer.c, remove it. Signed-off-by: Tiezhu Yang <yangtiezhu@loongson.cn> --- arch/mips/sgi-ip27/ip27-timer.c | 2 -- 1 file changed, 2 deletions(-)