| Message ID | 1615792543-73864-1-git-send-email-yang.lee@linux.alibaba.com (mailing list archive) |
|---|---|
| State | Deferred |
| Headers | show |
| Series | MIPS: generic: use true and false for bool variable | expand |
On 15/03/2021 15:15:43+0800, Yang Li wrote: > fixed the following coccicheck: > ./arch/mips/generic/board-ocelot.c:29:9-10: WARNING: return of 0/1 in > function 'ocelot_detect' with return type bool > Can you elaborate why this is an issue and what exactly is fixed? Even the original coccinelle script submission doesn't give any good reason. bool in Linux is _Bool and, as per C99, it holds either 0 or 1, not true or false.
diff --git a/arch/mips/generic/board-ocelot.c b/arch/mips/generic/board-ocelot.c index c238e95..7115410 100644 --- a/arch/mips/generic/board-ocelot.c +++ b/arch/mips/generic/board-ocelot.c @@ -26,13 +26,13 @@ static __init bool ocelot_detect(void) tlb_probe_hazard(); idx = read_c0_index(); if (idx < 0) - return 0; + return false; /* A TLB entry exists, lets assume its usable and check the CHIP ID */ rev = __raw_readl((void __iomem *)DEVCPU_GCB_CHIP_REGS_CHIP_ID); if ((rev & CHIP_ID_PART_ID) != OCELOT_PART_ID) - return 0; + return false; /* Copy command line from bootloader early for Initrd detection */ if (fw_arg0 < 10 && (fw_arg1 & 0xFFF00000) == 0x80000000) { @@ -44,7 +44,7 @@ static __init bool ocelot_detect(void) strcpy(arcs_cmdline, prom_argv[1]); } - return 1; + return true; } static void __init ocelot_earlyprintk_init(void)
fixed the following coccicheck: ./arch/mips/generic/board-ocelot.c:29:9-10: WARNING: return of 0/1 in function 'ocelot_detect' with return type bool Reported-by: Abaci Robot <abaci@linux.alibaba.com> Signed-off-by: Yang Li <yang.lee@linux.alibaba.com> --- arch/mips/generic/board-ocelot.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-)