diff mbox series

irqchip: irq-bcm7120-l2: add missing put_device() call in bcm7120_l2_intc_probe()

Message ID 1639052506-23462-1-git-send-email-wangqing@vivo.com (mailing list archive)
State Not Applicable
Headers show
Series irqchip: irq-bcm7120-l2: add missing put_device() call in bcm7120_l2_intc_probe() | expand

Commit Message

王擎 Dec. 9, 2021, 12:21 p.m. UTC 
From: Wang Qing <wangqing@vivo.com>

of_find_device_by_node() takes a reference to the embedded struct device 
which needs to be dropped when error return.

Signed-off-by: Wang Qing <wangqing@vivo.com>
---
 drivers/irqchip/irq-bcm7120-l2.c | 1 +
 1 file changed, 1 insertion(+)

Comments

Florian Fainelli Dec. 9, 2021, 4:58 p.m. UTC | #1 
On 12/9/21 4:21 AM, Qing Wang wrote:
> From: Wang Qing <wangqing@vivo.com>
> 
> of_find_device_by_node() takes a reference to the embedded struct device 
> which needs to be dropped when error return.
> 
> Signed-off-by: Wang Qing <wangqing@vivo.com>

This has been submitted already with:

https://lore.kernel.org/lkml/20211109055958.130287-1-ye.guojin@zte.com.cn/
diff mbox series

Patch

diff --git a/drivers/irqchip/irq-bcm7120-l2.c b/drivers/irqchip/irq-bcm7120-l2.c
index d80e67a..24573ca
--- a/drivers/irqchip/irq-bcm7120-l2.c
+++ b/drivers/irqchip/irq-bcm7120-l2.c
@@ -336,6 +336,7 @@  static int __init bcm7120_l2_intc_probe(struct device_node *dn,
 		if (data->map_base[idx])
 			iounmap(data->map_base[idx]);
 	}
+	put_device(&pdev->dev);
 out_free_data:
 	kfree(data);
 	return ret;