diff mbox series

[v3,2/2] MIPS: Makefile: Remove "ifdef need-compiler" for Kbuild.platforms

Message ID 1639389477-17586-3-git-send-email-yangtiezhu@loongson.cn (mailing list archive)
State Superseded
Headers show
Series MIPS: Remove some code | expand

Commit Message

Tiezhu Yang Dec. 13, 2021, 9:57 a.m. UTC
After commit 13ceb48bc19c ("MIPS: Loongson2ef: Remove unnecessary
{as,cc}-option calls"), no need to use "ifdef need-compiler" for
Kbuild.platforms, because the cause of the build issue mentioned
in commit 0706f74f719e ("MIPS: fix *-pkg builds for loongson2ef
platform") has been disappeared, so just remove it.

Signed-off-by: Tiezhu Yang <yangtiezhu@loongson.cn>
---
 arch/mips/Makefile | 2 --
 1 file changed, 2 deletions(-)

Comments

Nathan Chancellor Dec. 13, 2021, 5:13 p.m. UTC | #1
On Mon, Dec 13, 2021 at 05:57:57PM +0800, Tiezhu Yang wrote:
> After commit 13ceb48bc19c ("MIPS: Loongson2ef: Remove unnecessary
> {as,cc}-option calls"), no need to use "ifdef need-compiler" for
> Kbuild.platforms, because the cause of the build issue mentioned
> in commit 0706f74f719e ("MIPS: fix *-pkg builds for loongson2ef
> platform") has been disappeared, so just remove it.
> 
> Signed-off-by: Tiezhu Yang <yangtiezhu@loongson.cn>

Reviewed-by: Nathan Chancellor <nathan@kernel.org>

> ---
>  arch/mips/Makefile | 2 --
>  1 file changed, 2 deletions(-)
> 
> diff --git a/arch/mips/Makefile b/arch/mips/Makefile
> index ace7f03..e036fc0 100644
> --- a/arch/mips/Makefile
> +++ b/arch/mips/Makefile
> @@ -253,9 +253,7 @@ endif
>  #
>  # Board-dependent options and extra files
>  #
> -ifdef need-compiler
>  include $(srctree)/arch/mips/Kbuild.platforms
> -endif
>  
>  ifdef CONFIG_PHYSICAL_START
>  load-y					= $(CONFIG_PHYSICAL_START)
> -- 
> 2.1.0
>
Masahiro Yamada Dec. 14, 2021, 1:31 a.m. UTC | #2
On Mon, Dec 13, 2021 at 6:58 PM Tiezhu Yang <yangtiezhu@loongson.cn> wrote:
>
> After commit 13ceb48bc19c ("MIPS: Loongson2ef: Remove unnecessary
> {as,cc}-option calls"), no need to use "ifdef need-compiler" for
> Kbuild.platforms, because the cause of the build issue mentioned
> in commit 0706f74f719e ("MIPS: fix *-pkg builds for loongson2ef
> platform") has been disappeared, so just remove it.
>
> Signed-off-by: Tiezhu Yang <yangtiezhu@loongson.cn>
> ---


Reviewed-by: Masahiro Yamada <masahiroy@kernel.org>


>  arch/mips/Makefile | 2 --
>  1 file changed, 2 deletions(-)
>
> diff --git a/arch/mips/Makefile b/arch/mips/Makefile
> index ace7f03..e036fc0 100644
> --- a/arch/mips/Makefile
> +++ b/arch/mips/Makefile
> @@ -253,9 +253,7 @@ endif
>  #
>  # Board-dependent options and extra files
>  #
> -ifdef need-compiler
>  include $(srctree)/arch/mips/Kbuild.platforms
> -endif
>
>  ifdef CONFIG_PHYSICAL_START
>  load-y                                 = $(CONFIG_PHYSICAL_START)
> --
> 2.1.0
>
diff mbox series

Patch

diff --git a/arch/mips/Makefile b/arch/mips/Makefile
index ace7f03..e036fc0 100644
--- a/arch/mips/Makefile
+++ b/arch/mips/Makefile
@@ -253,9 +253,7 @@  endif
 #
 # Board-dependent options and extra files
 #
-ifdef need-compiler
 include $(srctree)/arch/mips/Kbuild.platforms
-endif
 
 ifdef CONFIG_PHYSICAL_START
 load-y					= $(CONFIG_PHYSICAL_START)