diff mbox series

[v3,3/3] MIPS: Modify the declaration for die()

Message ID 1692005246-18399-4-git-send-email-yangtiezhu@loongson.cn (mailing list archive)
State Superseded
Headers show
Series Modify die() for MIPS | expand

Commit Message

Tiezhu Yang Aug. 14, 2023, 9:27 a.m. UTC 
While at it, modify the die() declaration in ptrace.h to fix
the following checkpatch warnings:

  WARNING: function definition argument 'const char *' should also have an identifier name
  WARNING: function definition argument 'struct pt_regs *' should also have an identifier name

Signed-off-by: Tiezhu Yang <yangtiezhu@loongson.cn>
---
 arch/mips/include/asm/ptrace.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Maciej W. Rozycki Aug. 18, 2023, 2:42 a.m. UTC | #1 
On Mon, 14 Aug 2023, Tiezhu Yang wrote:

> While at it, modify the die() declaration in ptrace.h to fix
> the following checkpatch warnings:

 It doesn't make sense to say: "While at it" now that it's a separate 
change, so how about:

"
Modify the die() declaration in ptrace.h to fix the following checkpatch 
warnings:
"

?

  Maciej
Tiezhu Yang Aug. 19, 2023, 2:44 a.m. UTC | #2 
On 08/18/2023 10:42 AM, Maciej W. Rozycki wrote:
> On Mon, 14 Aug 2023, Tiezhu Yang wrote:
>
>> While at it, modify the die() declaration in ptrace.h to fix
>> the following checkpatch warnings:
>
>  It doesn't make sense to say: "While at it" now that it's a separate
> change, so how about:
>
> "
> Modify the die() declaration in ptrace.h to fix the following checkpatch
> warnings:
> "

OK, I will update it in v4.

Thanks,
Tiezhu
diff mbox series

Patch

diff --git a/arch/mips/include/asm/ptrace.h b/arch/mips/include/asm/ptrace.h
index aee8e0a..d05844e 100644
--- a/arch/mips/include/asm/ptrace.h
+++ b/arch/mips/include/asm/ptrace.h
@@ -159,7 +159,7 @@  static inline long regs_return_value(struct pt_regs *regs)
 extern asmlinkage long syscall_trace_enter(struct pt_regs *regs, long syscall);
 extern asmlinkage void syscall_trace_leave(struct pt_regs *regs);
 
-extern void die(const char *, struct pt_regs *);
+extern void die(const char *str, struct pt_regs *regs);
 
 static inline void die_if_kernel(const char *str, struct pt_regs *regs)
 {