diff mbox series

[v4,1/4] MIPS: Add BUG() at the end of nmi_exception_handler()

Message ID 1692434183-2054-2-git-send-email-yangtiezhu@loongson.cn (mailing list archive)
State Accepted
Commit 96def19a06f7c1c8d07bdaa291c990d8d423a0c4
Headers show
Series Modify die() for MIPS | expand

Commit Message

Tiezhu Yang Aug. 19, 2023, 8:36 a.m. UTC
In the later patch, we will remove noreturn attribute for die(), in order
to make each patch can be built without errors and warnings, just add a
noreturn function BUG() at the end of nmi_exception_handler() to make sure
it does not return, otherwise there exists the following build error after
the later patch:

  arch/mips/kernel/traps.c:2001:1: error: 'noreturn' function does return [-Werror]

Signed-off-by: Tiezhu Yang <yangtiezhu@loongson.cn>
---
 arch/mips/kernel/traps.c | 1 +
 1 file changed, 1 insertion(+)
diff mbox series

Patch

diff --git a/arch/mips/kernel/traps.c b/arch/mips/kernel/traps.c
index 246c6a6..b1b68ce 100644
--- a/arch/mips/kernel/traps.c
+++ b/arch/mips/kernel/traps.c
@@ -1998,6 +1998,7 @@  void __noreturn nmi_exception_handler(struct pt_regs *regs)
 	regs->cp0_epc = read_c0_errorepc();
 	die(str, regs);
 	nmi_exit();
+	BUG();
 }
 
 unsigned long ebase;