| Message ID | 20190408142100.27618-3-tbogendoerfer@suse.de (mailing list archive) |
|---|---|
| State | Superseded |
| Headers | show |
| Series | Use MFD framework for SGI IOC3 drivers | expand |
From: Thomas Bogendoerfer <tbogendoerfer@suse.de> Date: Mon, 8 Apr 2019 16:20:54 +0200 > RTC platform device will be setup by new IOC3 MFD driver, therefore > remove it from IP27 platform code. > > Signed-off-by: Thomas Bogendoerfer <tbogendoerfer@suse.de> You cannot break the driver like this. Your patch series must be fully bisectable, which means that after this patch is applied things still must continue working properly.
On Mon, 08 Apr 2019 10:05:28 -0700 (PDT) David Miller <davem@davemloft.net> wrote: > From: Thomas Bogendoerfer <tbogendoerfer@suse.de> > Date: Mon, 8 Apr 2019 16:20:54 +0200 > > > RTC platform device will be setup by new IOC3 MFD driver, therefore > > remove it from IP27 platform code. > > > > Signed-off-by: Thomas Bogendoerfer <tbogendoerfer@suse.de> > > You cannot break the driver like this. > > Your patch series must be fully bisectable, which means that after > this patch is applied things still must continue working properly. I see your point and the ethernet driver itself will work properly, but of course IP27 will be working again after applying the whole series. One way I can see to solve this to also add the addition of the serial driver into it. Then we are on par with the current driver. Does this solve your concern ? Thomas.
On Mon, 08 Apr 2019 10:05:28 -0700 (PDT) David Miller <davem@davemloft.net> wrote: > From: Thomas Bogendoerfer <tbogendoerfer@suse.de> > Date: Mon, 8 Apr 2019 16:20:54 +0200 > > > RTC platform device will be setup by new IOC3 MFD driver, therefore > > remove it from IP27 platform code. > > > > Signed-off-by: Thomas Bogendoerfer <tbogendoerfer@suse.de> > > You cannot break the driver like this. > > Your patch series must be fully bisectable, which means that after > this patch is applied things still must continue working properly. sorry didn't realize your are talking about RTC. I'll check, if there is a chance to move after the MFD driver addition. Thomas.
diff --git a/arch/mips/sgi-ip27/ip27-timer.c b/arch/mips/sgi-ip27/ip27-timer.c index 9b4b9ac621a3..5631e93ea350 100644 --- a/arch/mips/sgi-ip27/ip27-timer.c +++ b/arch/mips/sgi-ip27/ip27-timer.c @@ -188,23 +188,3 @@ void hub_rtc_init(cnodeid_t cnode) LOCAL_HUB_S(PI_RT_PEND_B, 0); } } - -static int __init sgi_ip27_rtc_devinit(void) -{ - struct resource res; - - memset(&res, 0, sizeof(res)); - res.start = XPHYSADDR(KL_CONFIG_CH_CONS_INFO(master_nasid)->memory_base + - IOC3_BYTEBUS_DEV0); - res.end = res.start + 32767; - res.flags = IORESOURCE_MEM; - - return IS_ERR(platform_device_register_simple("rtc-m48t35", -1, - &res, 1)); -} - -/* - * kludge make this a device_initcall after ioc3 resource conflicts - * are resolved - */ -late_initcall(sgi_ip27_rtc_devinit);
RTC platform device will be setup by new IOC3 MFD driver, therefore remove it from IP27 platform code. Signed-off-by: Thomas Bogendoerfer <tbogendoerfer@suse.de> --- arch/mips/sgi-ip27/ip27-timer.c | 20 -------------------- 1 file changed, 20 deletions(-)