| Message ID | 20190423224748.3765-9-fancer.lancer@gmail.com (mailing list archive) |
|---|---|
| State | Superseded |
| Headers | show |
| Series | mips: Post-bootmem-memblock transition fixes | expand |
On Wed, Apr 24, 2019 at 01:47:44AM +0300, Serge Semin wrote: > It is useful to have the whole memblock memory space printed to console > when basic memlock initializations are done. It can be performed by > ready-to-use method memblock_dump_all(), which prints the available > and reserved memory spaces if MEMBLOCK_DEBUG config is enabled. Nit: there's no MEMBLOCK_DEBUG config option but rather memblock=debug command line parameter ;-) > Lets call it at the very end of arch_mem_init() function, when > all memblock memory and reserved regions are defined, but before > any serious allocation is performed. > > Signed-off-by: Serge Semin <fancer.lancer@gmail.com> > --- > arch/mips/kernel/setup.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/arch/mips/kernel/setup.c b/arch/mips/kernel/setup.c > index 2a1b2e7a1bc9..ca493fdf69b0 100644 > --- a/arch/mips/kernel/setup.c > +++ b/arch/mips/kernel/setup.c > @@ -824,6 +824,8 @@ static void __init arch_mem_init(char **cmdline_p) > /* Reserve for hibernation. */ > memblock_reserve(__pa_symbol(&__nosave_begin), > __pa_symbol(&__nosave_end) - __pa_symbol(&__nosave_begin)); > + > + memblock_dump_all(); > } > > static void __init resource_init(void) > -- > 2.21.0 >
On Wed, Apr 24, 2019 at 04:45:47PM +0300, Mike Rapoport wrote: > On Wed, Apr 24, 2019 at 01:47:44AM +0300, Serge Semin wrote: > > It is useful to have the whole memblock memory space printed to console > > when basic memlock initializations are done. It can be performed by > > ready-to-use method memblock_dump_all(), which prints the available > > and reserved memory spaces if MEMBLOCK_DEBUG config is enabled. > > Nit: there's no MEMBLOCK_DEBUG config option but rather memblock=debug > command line parameter ;-) > Right. Thanks. I'll reword the message in the next patchset revision. -Sergey > > Lets call it at the very end of arch_mem_init() function, when > > all memblock memory and reserved regions are defined, but before > > any serious allocation is performed. > > > > Signed-off-by: Serge Semin <fancer.lancer@gmail.com> > > --- > > arch/mips/kernel/setup.c | 2 ++ > > 1 file changed, 2 insertions(+) > > > > diff --git a/arch/mips/kernel/setup.c b/arch/mips/kernel/setup.c > > index 2a1b2e7a1bc9..ca493fdf69b0 100644 > > --- a/arch/mips/kernel/setup.c > > +++ b/arch/mips/kernel/setup.c > > @@ -824,6 +824,8 @@ static void __init arch_mem_init(char **cmdline_p) > > /* Reserve for hibernation. */ > > memblock_reserve(__pa_symbol(&__nosave_begin), > > __pa_symbol(&__nosave_end) - __pa_symbol(&__nosave_begin)); > > + > > + memblock_dump_all(); > > } > > > > static void __init resource_init(void) > > -- > > 2.21.0 > > > > -- > Sincerely yours, > Mike. >
diff --git a/arch/mips/kernel/setup.c b/arch/mips/kernel/setup.c index 2a1b2e7a1bc9..ca493fdf69b0 100644 --- a/arch/mips/kernel/setup.c +++ b/arch/mips/kernel/setup.c @@ -824,6 +824,8 @@ static void __init arch_mem_init(char **cmdline_p) /* Reserve for hibernation. */ memblock_reserve(__pa_symbol(&__nosave_begin), __pa_symbol(&__nosave_end) - __pa_symbol(&__nosave_begin)); + + memblock_dump_all(); } static void __init resource_init(void)
It is useful to have the whole memblock memory space printed to console when basic memlock initializations are done. It can be performed by ready-to-use method memblock_dump_all(), which prints the available and reserved memory spaces if MEMBLOCK_DEBUG config is enabled. Lets call it at the very end of arch_mem_init() function, when all memblock memory and reserved regions are defined, but before any serious allocation is performed. Signed-off-by: Serge Semin <fancer.lancer@gmail.com> --- arch/mips/kernel/setup.c | 2 ++ 1 file changed, 2 insertions(+)