| Message ID | 20190507193421.12260-1-paul@crapouillou.net (mailing list archive) |
|---|---|
| State | Superseded |
| Headers | show |
| Series | [1/5] clk: ingenic: Add missing header in cgu.h | expand |
Quoting Paul Cercueil (2019-05-07 12:34:17) > The cgu.h has structures that contain 'clk_onecell_data' and 'clk_hw' > structures (no pointers), so the <linux/clk-provider.h> header should be > included. > > Signed-off-by: Paul Cercueil <paul@crapouillou.net> > --- > drivers/clk/ingenic/cgu.h | 1 + > drivers/clk/ingenic/jz4725b-cgu.c | 1 - > drivers/clk/ingenic/jz4740-cgu.c | 1 - > drivers/clk/ingenic/jz4770-cgu.c | 1 - > drivers/clk/ingenic/jz4780-cgu.c | 1 - > 5 files changed, 1 insertion(+), 4 deletions(-) > > diff --git a/drivers/clk/ingenic/cgu.h b/drivers/clk/ingenic/cgu.h > index e12716d8ce3c..c18198ba2955 100644 > --- a/drivers/clk/ingenic/cgu.h > +++ b/drivers/clk/ingenic/cgu.h > @@ -19,6 +19,7 @@ > #define __DRIVERS_CLK_INGENIC_CGU_H__ > > #include <linux/bitops.h> > +#include <linux/clk-provider.h> > #include <linux/of.h> > #include <linux/spinlock.h> > > diff --git a/drivers/clk/ingenic/jz4725b-cgu.c b/drivers/clk/ingenic/jz4725b-cgu.c > index 584ff4ff81c7..044bbd271bb6 100644 > --- a/drivers/clk/ingenic/jz4725b-cgu.c > +++ b/drivers/clk/ingenic/jz4725b-cgu.c > @@ -6,7 +6,6 @@ > * Author: Paul Cercueil <paul@crapouillou.net> > */ > > -#include <linux/clk-provider.h> Please leave these here. We want to keep around explicit includes so we don't get implicit include problems like we just experienced with io.h not being included in various clk drivers because clk-provider.h did it for them.
diff --git a/drivers/clk/ingenic/cgu.h b/drivers/clk/ingenic/cgu.h index e12716d8ce3c..c18198ba2955 100644 --- a/drivers/clk/ingenic/cgu.h +++ b/drivers/clk/ingenic/cgu.h @@ -19,6 +19,7 @@ #define __DRIVERS_CLK_INGENIC_CGU_H__ #include <linux/bitops.h> +#include <linux/clk-provider.h> #include <linux/of.h> #include <linux/spinlock.h> diff --git a/drivers/clk/ingenic/jz4725b-cgu.c b/drivers/clk/ingenic/jz4725b-cgu.c index 584ff4ff81c7..044bbd271bb6 100644 --- a/drivers/clk/ingenic/jz4725b-cgu.c +++ b/drivers/clk/ingenic/jz4725b-cgu.c @@ -6,7 +6,6 @@ * Author: Paul Cercueil <paul@crapouillou.net> */ -#include <linux/clk-provider.h> #include <linux/delay.h> #include <linux/of.h> #include <dt-bindings/clock/jz4725b-cgu.h> diff --git a/drivers/clk/ingenic/jz4740-cgu.c b/drivers/clk/ingenic/jz4740-cgu.c index b86edd328249..09629c0613c1 100644 --- a/drivers/clk/ingenic/jz4740-cgu.c +++ b/drivers/clk/ingenic/jz4740-cgu.c @@ -15,7 +15,6 @@ * GNU General Public License for more details. */ -#include <linux/clk-provider.h> #include <linux/delay.h> #include <linux/of.h> #include <dt-bindings/clock/jz4740-cgu.h> diff --git a/drivers/clk/ingenic/jz4770-cgu.c b/drivers/clk/ingenic/jz4770-cgu.c index bf46a0df2004..2e6fd8b1c248 100644 --- a/drivers/clk/ingenic/jz4770-cgu.c +++ b/drivers/clk/ingenic/jz4770-cgu.c @@ -5,7 +5,6 @@ */ #include <linux/bitops.h> -#include <linux/clk-provider.h> #include <linux/delay.h> #include <linux/of.h> #include <linux/syscore_ops.h> diff --git a/drivers/clk/ingenic/jz4780-cgu.c b/drivers/clk/ingenic/jz4780-cgu.c index 6427be117ff1..ad64afb438a5 100644 --- a/drivers/clk/ingenic/jz4780-cgu.c +++ b/drivers/clk/ingenic/jz4780-cgu.c @@ -15,7 +15,6 @@ * GNU General Public License for more details. */ -#include <linux/clk-provider.h> #include <linux/delay.h> #include <linux/of.h> #include <dt-bindings/clock/jz4780-cgu.h>
The cgu.h has structures that contain 'clk_onecell_data' and 'clk_hw' structures (no pointers), so the <linux/clk-provider.h> header should be included. Signed-off-by: Paul Cercueil <paul@crapouillou.net> --- drivers/clk/ingenic/cgu.h | 1 + drivers/clk/ingenic/jz4725b-cgu.c | 1 - drivers/clk/ingenic/jz4740-cgu.c | 1 - drivers/clk/ingenic/jz4770-cgu.c | 1 - drivers/clk/ingenic/jz4780-cgu.c | 1 - 5 files changed, 1 insertion(+), 4 deletions(-)