diff mbox series

[-next] MIPS: uprobes: remove set but not used variable 'epc'

Message ID 20190525122024.4908-1-yuehaibing@huawei.com (mailing list archive)
State Mainlined
Commit f532beeeff0c0a3586cc15538bc52d249eb19e7c
Headers show
Series [-next] MIPS: uprobes: remove set but not used variable 'epc' | expand

Commit Message

Yue Haibing May 25, 2019, 12:20 p.m. UTC
Fixes gcc '-Wunused-but-set-variable' warning:

arch/mips/kernel/uprobes.c: In function 'arch_uprobe_pre_xol':
arch/mips/kernel/uprobes.c:115:17: warning: variable 'epc' set but not used [-Wunused-but-set-variable]

It's never used since introduction in
commit 40e084a506eb ("MIPS: Add uprobes support.")

Signed-off-by: YueHaibing <yuehaibing@huawei.com>
---
 arch/mips/kernel/uprobes.c | 3 ---
 1 file changed, 3 deletions(-)

Comments

Paul Burton May 29, 2019, 8:35 p.m. UTC | #1
Hello,

YueHaibing wrote:
> Fixes gcc '-Wunused-but-set-variable' warning:
> 
> arch/mips/kernel/uprobes.c: In function 'arch_uprobe_pre_xol':
> arch/mips/kernel/uprobes.c:115:17: warning: variable 'epc' set but not used [-Wunused-but-set-variable]
> 
> It's never used since introduction in
> commit 40e084a506eb ("MIPS: Add uprobes support.")
> 
> Signed-off-by: YueHaibing <yuehaibing@huawei.com>

Applied to mips-fixes.

Thanks,
    Paul

[ This message was auto-generated; if you believe anything is incorrect
  then please email paul.burton@mips.com to report it. ]
diff mbox series

Patch

diff --git a/arch/mips/kernel/uprobes.c b/arch/mips/kernel/uprobes.c
index 4aaff3b3175c..6dbe4eab0a0e 100644
--- a/arch/mips/kernel/uprobes.c
+++ b/arch/mips/kernel/uprobes.c
@@ -112,9 +112,6 @@  int arch_uprobe_pre_xol(struct arch_uprobe *aup, struct pt_regs *regs)
 	 */
 	aup->resume_epc = regs->cp0_epc + 4;
 	if (insn_has_delay_slot((union mips_instruction) aup->insn[0])) {
-		unsigned long epc;
-
-		epc = regs->cp0_epc;
 		__compute_return_epc_for_insn(regs,
 			(union mips_instruction) aup->insn[0]);
 		aup->resume_epc = regs->cp0_epc;