| Message ID | 20190827085302.5197-8-jiaxun.yang@flygoat.com (mailing list archive) |
|---|---|
| State | Superseded |
| Headers | show |
| Series | Modernize Loongson64 Machine | expand |
On Tue, Aug 27, 2019 at 3:59 AM Jiaxun Yang <jiaxun.yang@flygoat.com> wrote: > > Document Loongson-3 HyperTransport Interrupt controller. > > Signed-off-by: Jiaxun Yang <jiaxun.yang@flygoat.com> > --- > .../loongson,ls3-htintc.yaml | 53 +++++++++++++++++++ > 1 file changed, 53 insertions(+) > create mode 100644 Documentation/devicetree/bindings/interrupt-controller/loongson,ls3-htintc.yaml > > diff --git a/Documentation/devicetree/bindings/interrupt-controller/loongson,ls3-htintc.yaml b/Documentation/devicetree/bindings/interrupt-controller/loongson,ls3-htintc.yaml > new file mode 100644 > index 000000000000..c1bc0faca656 > --- /dev/null > +++ b/Documentation/devicetree/bindings/interrupt-controller/loongson,ls3-htintc.yaml > @@ -0,0 +1,53 @@ > +# SPDX-License-Identifier: GPL-2.0 > +%YAML 1.2 > +--- > +$id: "http://devicetree.org/schemas/interrupt-controller/loongson,ls3-htintc.yaml#" > +$schema: "http://devicetree.org/meta-schemas/core.yaml#" > + > +title: Loongson-3 HyperTransport Interrupt Controller > + > +maintainers: > + - Jiaxun Yang <jiaxun.yang@flygoat.com> > + > +description: | > + This interrupt controller is found in the Loongson-3 family of chips to transfer > + interrupts from PCH connected on HyperTransport bus. > + > +properties: > + compatible: > + items: > + - enum: > + - loongson,ls3-htintc Can be simplified to: compatible const: loongson,ls3-htintc > + > + reg: > + maxItems: 1 > + > + interrupts: > + maxItems: 4 Need to list out what each of the 4 are. > + > + interrupt-controller: true > + > + '#interrupt-cells': > + const: 1 > + > +required: > + - compatible > + - reg > + - interrupts > + - interrupt-controller > + - '#interrupt-cells' > + > +examples: > + - | > + htintc: interrupt-controller@0xEFDFB000080 { interrupt-controller@efdfb000080 > + compatible = "loongson,ls3-htintc"; > + reg = <0xEFD 0xFB000080 0x100>; > + interrupt-controller; > + #interrupt-cells = <1>; > + > + interrupt-parent = <&iointc>; > + interrupts = <24 IRQ_TYPE_LEVEL_HIGH>, > + <25 IRQ_TYPE_LEVEL_HIGH>, > + <26 IRQ_TYPE_LEVEL_HIGH>, > + <27 IRQ_TYPE_LEVEL_HIGH>; Run 'make dt_binding_check'. This will not build without the necessary include. > + }; > -- > 2.22.0 >
On 2019/8/27 下午8:49, Rob Herring wrote: > On Tue, Aug 27, 2019 at 3:59 AM Jiaxun Yang <jiaxun.yang@flygoat.com> wrote: >> Document Loongson-3 HyperTransport Interrupt controller. >> >> Signed-off-by: Jiaxun Yang <jiaxun.yang@flygoat.com> >> --- >> .../loongson,ls3-htintc.yaml | 53 +++++++++++++++++++ >> 1 file changed, 53 insertions(+) >> create mode 100644 Documentation/devicetree/bindings/interrupt-controller/loongson,ls3-htintc.yaml >> >> diff --git a/Documentation/devicetree/bindings/interrupt-controller/loongson,ls3-htintc.yaml b/Documentation/devicetree/bindings/interrupt-controller/loongson,ls3-htintc.yaml >> new file mode 100644 >> index 000000000000..c1bc0faca656 >> --- /dev/null >> +++ b/Documentation/devicetree/bindings/interrupt-controller/loongson,ls3-htintc.yaml >> @@ -0,0 +1,53 @@ >> +# SPDX-License-Identifier: GPL-2.0 >> +%YAML 1.2 >> +--- >> +$id: "http://devicetree.org/schemas/interrupt-controller/loongson,ls3-htintc.yaml#" >> +$schema: "http://devicetree.org/meta-schemas/core.yaml#" >> + >> +title: Loongson-3 HyperTransport Interrupt Controller >> + >> +maintainers: >> + - Jiaxun Yang <jiaxun.yang@flygoat.com> >> + >> +description: | >> + This interrupt controller is found in the Loongson-3 family of chips to transfer >> + interrupts from PCH connected on HyperTransport bus. >> + >> +properties: >> + compatible: >> + items: >> + - enum: >> + - loongson,ls3-htintc > Can be simplified to: > > compatible > const: loongson,ls3-htintc > >> + >> + reg: >> + maxItems: 1 >> + >> + interrupts: >> + maxItems: 4 > Need to list out what each of the 4 are. Hi Rob These 4 interrupts a just delivered randomly, So it's hard to give out a name. Should I add a description for this? Thanks, -- Jiaxun Yang
diff --git a/Documentation/devicetree/bindings/interrupt-controller/loongson,ls3-htintc.yaml b/Documentation/devicetree/bindings/interrupt-controller/loongson,ls3-htintc.yaml new file mode 100644 index 000000000000..c1bc0faca656 --- /dev/null +++ b/Documentation/devicetree/bindings/interrupt-controller/loongson,ls3-htintc.yaml @@ -0,0 +1,53 @@ +# SPDX-License-Identifier: GPL-2.0 +%YAML 1.2 +--- +$id: "http://devicetree.org/schemas/interrupt-controller/loongson,ls3-htintc.yaml#" +$schema: "http://devicetree.org/meta-schemas/core.yaml#" + +title: Loongson-3 HyperTransport Interrupt Controller + +maintainers: + - Jiaxun Yang <jiaxun.yang@flygoat.com> + +description: | + This interrupt controller is found in the Loongson-3 family of chips to transfer + interrupts from PCH connected on HyperTransport bus. + +properties: + compatible: + items: + - enum: + - loongson,ls3-htintc + + reg: + maxItems: 1 + + interrupts: + maxItems: 4 + + interrupt-controller: true + + '#interrupt-cells': + const: 1 + +required: + - compatible + - reg + - interrupts + - interrupt-controller + - '#interrupt-cells' + +examples: + - | + htintc: interrupt-controller@0xEFDFB000080 { + compatible = "loongson,ls3-htintc"; + reg = <0xEFD 0xFB000080 0x100>; + interrupt-controller; + #interrupt-cells = <1>; + + interrupt-parent = <&iointc>; + interrupts = <24 IRQ_TYPE_LEVEL_HIGH>, + <25 IRQ_TYPE_LEVEL_HIGH>, + <26 IRQ_TYPE_LEVEL_HIGH>, + <27 IRQ_TYPE_LEVEL_HIGH>; + };
Document Loongson-3 HyperTransport Interrupt controller. Signed-off-by: Jiaxun Yang <jiaxun.yang@flygoat.com> --- .../loongson,ls3-htintc.yaml | 53 +++++++++++++++++++ 1 file changed, 53 insertions(+) create mode 100644 Documentation/devicetree/bindings/interrupt-controller/loongson,ls3-htintc.yaml