diff mbox series

[3/4] MIPS: cmdline: Remove redundant Kconfig defaults

Message ID 20191007221951.1889661-3-paul.burton@mips.com (mailing list archive)
State Accepted
Delegated to: Paul Burton
Headers show
Series [1/4] MIPS: cmdline: Remove CONFIG_MIPS_CMDLINE_BUILTIN_EXTEND | expand

Commit Message

Paul Burton Oct. 7, 2019, 10:20 p.m. UTC
CMDLINE, CMDLINE_BOOL & CMDLINE_FORCE all explicitly specify default
values that are the same as the default value for their respective types
anyway (ie. n for booleans, and the empty string for strings).

Remove the redundant defaults.

Signed-off-by: Paul Burton <paul.burton@mips.com>
---

 arch/mips/Kconfig.debug | 3 ---
 1 file changed, 3 deletions(-)

Comments

Philippe Mathieu-Daudé Oct. 9, 2019, 12:20 p.m. UTC | #1
On 10/8/19 12:20 AM, Paul Burton wrote:
> CMDLINE, CMDLINE_BOOL & CMDLINE_FORCE all explicitly specify default
> values that are the same as the default value for their respective types
> anyway (ie. n for booleans, and the empty string for strings).
> 
> Remove the redundant defaults.
> 
> Signed-off-by: Paul Burton <paul.burton@mips.com>
> ---
> 
>   arch/mips/Kconfig.debug | 3 ---
>   1 file changed, 3 deletions(-)
> 
> diff --git a/arch/mips/Kconfig.debug b/arch/mips/Kconfig.debug
> index 0c86b2a2adfc..93a2974d2ab7 100644
> --- a/arch/mips/Kconfig.debug
> +++ b/arch/mips/Kconfig.debug
> @@ -32,7 +32,6 @@ config USE_GENERIC_EARLY_PRINTK_8250
>   
>   config CMDLINE_BOOL
>   	bool "Built-in kernel command line"
> -	default n
>   	help
>   	  For most systems, it is firmware or second stage bootloader that
>   	  by default specifies the kernel command line options.  However,
> @@ -53,7 +52,6 @@ config CMDLINE_BOOL
>   config CMDLINE
>   	string "Default kernel command string"
>   	depends on CMDLINE_BOOL
> -	default ""
>   	help
>   	  On some platforms, there is currently no way for the boot loader to
>   	  pass arguments to the kernel.  For these platforms, and for the cases
> @@ -68,7 +66,6 @@ config CMDLINE
>   
>   config CMDLINE_OVERRIDE
>   	bool "Built-in command line overrides firmware arguments"
> -	default n
>   	depends on CMDLINE_BOOL
>   	help
>   	  By setting this option to 'Y' you will have your kernel ignore
> 

Reviewed-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
Paul Burton Oct. 9, 2019, 10:53 p.m. UTC | #2
Hello,

Paul Burton wrote:
> CMDLINE, CMDLINE_BOOL & CMDLINE_FORCE all explicitly specify default
> values that are the same as the default value for their respective types
> anyway (ie. n for booleans, and the empty string for strings).
> 
> Remove the redundant defaults.

Applied to mips-next.

> commit c85ac57ce241
> https://git.kernel.org/mips/c/c85ac57ce241
> 
> Signed-off-by: Paul Burton <paul.burton@mips.com>
> Reviewed-by: Philippe Mathieu-Daudé <f4bug@amsat.org>

Thanks,
    Paul

[ This message was auto-generated; if you believe anything is incorrect
  then please email paul.burton@mips.com to report it. ]
diff mbox series

Patch

diff --git a/arch/mips/Kconfig.debug b/arch/mips/Kconfig.debug
index 0c86b2a2adfc..93a2974d2ab7 100644
--- a/arch/mips/Kconfig.debug
+++ b/arch/mips/Kconfig.debug
@@ -32,7 +32,6 @@  config USE_GENERIC_EARLY_PRINTK_8250
 
 config CMDLINE_BOOL
 	bool "Built-in kernel command line"
-	default n
 	help
 	  For most systems, it is firmware or second stage bootloader that
 	  by default specifies the kernel command line options.  However,
@@ -53,7 +52,6 @@  config CMDLINE_BOOL
 config CMDLINE
 	string "Default kernel command string"
 	depends on CMDLINE_BOOL
-	default ""
 	help
 	  On some platforms, there is currently no way for the boot loader to
 	  pass arguments to the kernel.  For these platforms, and for the cases
@@ -68,7 +66,6 @@  config CMDLINE
 
 config CMDLINE_OVERRIDE
 	bool "Built-in command line overrides firmware arguments"
-	default n
 	depends on CMDLINE_BOOL
 	help
 	  By setting this option to 'Y' you will have your kernel ignore