diff mbox series

[v2,net] net: sgi: ioc3-eth: Remove leftover free_irq()

Message ID 20200204135820.21931-1-tbogendoerfer@suse.de (mailing list archive)
State Mainlined
Commit 9784e619f0a0ada7421ffd777872a199cdcb73cd
Headers show
Series [v2,net] net: sgi: ioc3-eth: Remove leftover free_irq() | expand

Commit Message

Thomas Bogendoerfer Feb. 4, 2020, 1:58 p.m. UTC 
Commit 0ce5ebd24d25 ("mfd: ioc3: Add driver for SGI IOC3 chip") moved
request_irq() from ioc3_open into probe function, but forgot to remove
free_irq() from ioc3_close.

Fixes: 0ce5ebd24d25 ("mfd: ioc3: Add driver for SGI IOC3 chip")
Signed-off-by: Thomas Bogendoerfer <tbogendoerfer@suse.de>
---
 drivers/net/ethernet/sgi/ioc3-eth.c | 1 -
 1 file changed, 1 deletion(-)

Comments

David Miller Feb. 5, 2020, 12:54 p.m. UTC | #1 
From: Thomas Bogendoerfer <tbogendoerfer@suse.de>
Date: Tue,  4 Feb 2020 14:58:20 +0100

> Commit 0ce5ebd24d25 ("mfd: ioc3: Add driver for SGI IOC3 chip") moved
> request_irq() from ioc3_open into probe function, but forgot to remove
> free_irq() from ioc3_close.
> 
> Fixes: 0ce5ebd24d25 ("mfd: ioc3: Add driver for SGI IOC3 chip")
> Signed-off-by: Thomas Bogendoerfer <tbogendoerfer@suse.de>

Applied, thank you.
diff mbox series

Patch

diff --git a/drivers/net/ethernet/sgi/ioc3-eth.c b/drivers/net/ethernet/sgi/ioc3-eth.c
index e61eb891c0f7..db6b2988e632 100644
--- a/drivers/net/ethernet/sgi/ioc3-eth.c
+++ b/drivers/net/ethernet/sgi/ioc3-eth.c
@@ -823,7 +823,6 @@  static int ioc3_close(struct net_device *dev)
 	netif_stop_queue(dev);
 
 	ioc3_stop(ip);
-	free_irq(dev->irq, dev);
 
 	ioc3_free_rx_bufs(ip);
 	ioc3_clean_tx_ring(ip);