diff mbox series

mips: ar7: add missing iounmap() on error in ar7_gpio_init

Message ID 20201028091545.136212-1-miaoqinglang@huawei.com (mailing list archive)
State Accepted
Commit 5a5aa912f687204d50455d0db36f94dd8de601c2
Headers show
Series mips: ar7: add missing iounmap() on error in ar7_gpio_init | expand

Commit Message

Qinglang Miao Oct. 28, 2020, 9:15 a.m. UTC 
Add the missing iounmap() of gpch->regs before return from
ar7_gpio_init() in the error handling case.

Signed-off-by: Qinglang Miao <miaoqinglang@huawei.com>
---
 arch/mips/ar7/gpio.c | 1 +
 1 file changed, 1 insertion(+)

Comments

Thomas Bogendoerfer Nov. 6, 2020, 10:49 a.m. UTC | #1 
On Wed, Oct 28, 2020 at 05:15:45PM +0800, Qinglang Miao wrote:
> Add the missing iounmap() of gpch->regs before return from
> ar7_gpio_init() in the error handling case.
> 
> Signed-off-by: Qinglang Miao <miaoqinglang@huawei.com>
> ---
>  arch/mips/ar7/gpio.c | 1 +
>  1 file changed, 1 insertion(+)

applied to mips-next.

Thomas.
diff mbox series

Patch

diff --git a/arch/mips/ar7/gpio.c b/arch/mips/ar7/gpio.c
index 8b006addd..ae0e01b94 100644
--- a/arch/mips/ar7/gpio.c
+++ b/arch/mips/ar7/gpio.c
@@ -319,6 +319,7 @@  int __init ar7_gpio_init(void)
 	if (ret) {
 		printk(KERN_ERR "%s: failed to add gpiochip\n",
 					gpch->chip.label);
+		iounmap(gpch->regs);
 		return ret;
 	}
 	printk(KERN_INFO "%s: registered %d GPIOs\n",