| Message ID | 20210608160603.1535935-3-hch@lst.de (mailing list archive) |
|---|---|
| State | Not Applicable |
| Headers | show |
| Series | [01/16] mm: use kmap_local_page in memzero_page | expand |
On 6/8/21 9:05 AM, Christoph Hellwig wrote: > There is no need to include genhd.h from a random arch header, and not > doing so prevents the possibility for nasty include loops. > > Signed-off-by: Christoph Hellwig <hch@lst.de> > --- > arch/mips/include/asm/mach-rc32434/rb.h | 2 -- > 1 file changed, 2 deletions(-) > > diff --git a/arch/mips/include/asm/mach-rc32434/rb.h b/arch/mips/include/asm/mach-rc32434/rb.h > index d502673a4f6c..34d179ca020b 100644 > --- a/arch/mips/include/asm/mach-rc32434/rb.h > +++ b/arch/mips/include/asm/mach-rc32434/rb.h > @@ -7,8 +7,6 @@ > #ifndef __ASM_RC32434_RB_H > #define __ASM_RC32434_RB_H > > -#include <linux/genhd.h> > - > #define REGBASE 0x18000000 > #define IDT434_REG_BASE ((volatile void *) KSEG1ADDR(REGBASE)) > #define UART0BASE 0x58000 Reviewed-by: Bart Van Assche <bvanassche@acm.org>
diff --git a/arch/mips/include/asm/mach-rc32434/rb.h b/arch/mips/include/asm/mach-rc32434/rb.h index d502673a4f6c..34d179ca020b 100644 --- a/arch/mips/include/asm/mach-rc32434/rb.h +++ b/arch/mips/include/asm/mach-rc32434/rb.h @@ -7,8 +7,6 @@ #ifndef __ASM_RC32434_RB_H #define __ASM_RC32434_RB_H -#include <linux/genhd.h> - #define REGBASE 0x18000000 #define IDT434_REG_BASE ((volatile void *) KSEG1ADDR(REGBASE)) #define UART0BASE 0x58000
There is no need to include genhd.h from a random arch header, and not doing so prevents the possibility for nasty include loops. Signed-off-by: Christoph Hellwig <hch@lst.de> --- arch/mips/include/asm/mach-rc32434/rb.h | 2 -- 1 file changed, 2 deletions(-)