| Message ID | 20210613155623.17233-2-sergio.paracuellos@gmail.com (mailing list archive) |
|---|---|
| State | Superseded |
| Headers | show |
| Series | staging: mt7621-pci: define ralink PCI_IOBASE to avoid manually ranges parsing | expand |
Hello! On 13.06.2021 18:56, Sergio Paracuellos wrote: > PCI_IOBASE is used to create VM maps for PCI I/O ports, it is > required by generic PCI drivers to make memory mapped I/O range > work. Hence define it for ralink architectures to be able to > avoid parsing manually IO ranges in PCI generic driver code. > Function 'plat_mem_setup' for ralink is using 'set_io_port_base' > call using '0xa0000000' as address, so use the same address in > the definition to align things. > > Signed-off-by: Sergio Paracuellos <sergio.paracuellos@gmail.com> > --- > arch/mips/include/asm/mach-ralink/spaces.h | 10 ++++++++++ > 1 file changed, 10 insertions(+) > create mode 100644 arch/mips/include/asm/mach-ralink/spaces.h > > diff --git a/arch/mips/include/asm/mach-ralink/spaces.h b/arch/mips/include/asm/mach-ralink/spaces.h > new file mode 100644 > index 000000000000..ec58d4a9ed05 > --- /dev/null > +++ b/arch/mips/include/asm/mach-ralink/spaces.h > @@ -0,0 +1,10 @@ > +/* SPDX-License-Identifier: GPL-2.0 */ > +#ifndef __ASM_MACH_RALINK_SPACES_H_ > +#define __ASM_MACH_RALINK_SPACES_H_ > + > +#define PCI_IOBASE _AC(0xa0000000, UL) > +#define PCI_IOSIZE SZ_16M > +#define IO_SPACE_LIMIT (PCI_IOSIZE - 1) Why this sudden switch to spaces for indentation? Previous lines were (correctly) indented with tabs... > + > +#include <asm/mach-generic/spaces.h> > +#endif MBR, Sergei
Hi Sergei, On Mon, Jun 14, 2021 at 11:13 AM Sergei Shtylyov <sergei.shtylyov@gmail.com> wrote: > > Hello! > > On 13.06.2021 18:56, Sergio Paracuellos wrote: > > > PCI_IOBASE is used to create VM maps for PCI I/O ports, it is > > required by generic PCI drivers to make memory mapped I/O range > > work. Hence define it for ralink architectures to be able to > > avoid parsing manually IO ranges in PCI generic driver code. > > Function 'plat_mem_setup' for ralink is using 'set_io_port_base' > > call using '0xa0000000' as address, so use the same address in > > the definition to align things. > > > > Signed-off-by: Sergio Paracuellos <sergio.paracuellos@gmail.com> > > --- > > arch/mips/include/asm/mach-ralink/spaces.h | 10 ++++++++++ > > 1 file changed, 10 insertions(+) > > create mode 100644 arch/mips/include/asm/mach-ralink/spaces.h > > > > diff --git a/arch/mips/include/asm/mach-ralink/spaces.h b/arch/mips/include/asm/mach-ralink/spaces.h > > new file mode 100644 > > index 000000000000..ec58d4a9ed05 > > --- /dev/null > > +++ b/arch/mips/include/asm/mach-ralink/spaces.h > > @@ -0,0 +1,10 @@ > > +/* SPDX-License-Identifier: GPL-2.0 */ > > +#ifndef __ASM_MACH_RALINK_SPACES_H_ > > +#define __ASM_MACH_RALINK_SPACES_H_ > > + > > +#define PCI_IOBASE _AC(0xa0000000, UL) > > +#define PCI_IOSIZE SZ_16M > > +#define IO_SPACE_LIMIT (PCI_IOSIZE - 1) > > Why this sudden switch to spaces for indentation? Previous lines were > (correctly) indented with tabs... I don't really know what could have happened, honestly. I will fix spaces into tabs and send v2. > > > + > > +#include <asm/mach-generic/spaces.h> > > +#endif > > MBR, Sergei Best regards, Sergio Paracuellos
diff --git a/arch/mips/include/asm/mach-ralink/spaces.h b/arch/mips/include/asm/mach-ralink/spaces.h new file mode 100644 index 000000000000..ec58d4a9ed05 --- /dev/null +++ b/arch/mips/include/asm/mach-ralink/spaces.h @@ -0,0 +1,10 @@ +/* SPDX-License-Identifier: GPL-2.0 */ +#ifndef __ASM_MACH_RALINK_SPACES_H_ +#define __ASM_MACH_RALINK_SPACES_H_ + +#define PCI_IOBASE _AC(0xa0000000, UL) +#define PCI_IOSIZE SZ_16M +#define IO_SPACE_LIMIT (PCI_IOSIZE - 1) + +#include <asm/mach-generic/spaces.h> +#endif
PCI_IOBASE is used to create VM maps for PCI I/O ports, it is required by generic PCI drivers to make memory mapped I/O range work. Hence define it for ralink architectures to be able to avoid parsing manually IO ranges in PCI generic driver code. Function 'plat_mem_setup' for ralink is using 'set_io_port_base' call using '0xa0000000' as address, so use the same address in the definition to align things. Signed-off-by: Sergio Paracuellos <sergio.paracuellos@gmail.com> --- arch/mips/include/asm/mach-ralink/spaces.h | 10 ++++++++++ 1 file changed, 10 insertions(+) create mode 100644 arch/mips/include/asm/mach-ralink/spaces.h