| Message ID | 20210615132456.753241-12-hch@lst.de (mailing list archive) |
|---|---|
| State | Not Applicable |
| Headers | show |
| Series | [01/18] mm: add a kunmap_local_dirty helper | expand |
Hi Christoph, On 6/15/21 6:24 AM, Christoph Hellwig wrote: > Use the bvec helpers instead of open coding the copy. > > Signed-off-by: Christoph Hellwig <hch@lst.de> > --- > drivers/block/ps3disk.c | 19 +++---------------- > 1 file changed, 3 insertions(+), 16 deletions(-) I tested your patch set applied to v5.13-rc6 on PS3 and it seemed to be working OK. I did some rsync's, some dd's, some fsck's, etc. If you have anything you could suggest that you think would exercise your changes I could try that also. Tested-by: Geoff Levand <geoff@infradead.org>
diff --git a/drivers/block/ps3disk.c b/drivers/block/ps3disk.c index f374ea2c67ce..b7d4c3efd7a8 100644 --- a/drivers/block/ps3disk.c +++ b/drivers/block/ps3disk.c @@ -83,26 +83,13 @@ static void ps3disk_scatter_gather(struct ps3_storage_device *dev, unsigned int offset = 0; struct req_iterator iter; struct bio_vec bvec; - unsigned int i = 0; - size_t size; - void *buf; rq_for_each_segment(bvec, req, iter) { - unsigned long flags; - dev_dbg(&dev->sbd.core, "%s:%u: bio %u: %u sectors from %llu\n", - __func__, __LINE__, i, bio_sectors(iter.bio), - iter.bio->bi_iter.bi_sector); - - size = bvec.bv_len; - buf = bvec_kmap_irq(&bvec, &flags); if (gather) - memcpy(dev->bounce_buf+offset, buf, size); + memcpy_from_bvec(dev->bounce_buf + offset, &bvec); else - memcpy(buf, dev->bounce_buf+offset, size); - offset += size; - flush_kernel_dcache_page(bvec.bv_page); - bvec_kunmap_irq(buf, &flags); - i++; + memcpy_to_bvec(&bvec, dev->bounce_buf + offset); + offset += bvec.bv_len; } }
Use the bvec helpers instead of open coding the copy. Signed-off-by: Christoph Hellwig <hch@lst.de> --- drivers/block/ps3disk.c | 19 +++---------------- 1 file changed, 3 insertions(+), 16 deletions(-)