| Message ID | 20210712060928.4161649-3-hch@lst.de (mailing list archive) |
|---|---|
| State | Not Applicable |
| Headers | show |
| Series | [1/6] mmc: JZ4740: remove the flush_kernel_dcache_page call in jz4740_mmc_read_data | expand |
On Mon, 12 Jul 2021 at 08:11, Christoph Hellwig <hch@lst.de> wrote: > > Pages passed to block drivers can be mapped page cache pages, so we > must use flush_dcache_page here instead of the more limited > flush_kernel_dcache_page that is intended for highmem pages only. > > Signed-off-by: Christoph Hellwig <hch@lst.de> Apologies for the delay! Acked-by: Ulf Hansson <ulf.hansson@linaro.org> Kind regards Uffe > --- > drivers/mmc/host/mmc_spi.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/mmc/host/mmc_spi.c b/drivers/mmc/host/mmc_spi.c > index 65c65bb5737f..3d28a3d3001b 100644 > --- a/drivers/mmc/host/mmc_spi.c > +++ b/drivers/mmc/host/mmc_spi.c > @@ -948,7 +948,7 @@ mmc_spi_data_do(struct mmc_spi_host *host, struct mmc_command *cmd, > > /* discard mappings */ > if (direction == DMA_FROM_DEVICE) > - flush_kernel_dcache_page(sg_page(sg)); > + flush_dcache_page(sg_page(sg)); > kunmap(sg_page(sg)); > if (dma_dev) > dma_unmap_page(dma_dev, dma_addr, PAGE_SIZE, dir); > -- > 2.30.2 >
diff --git a/drivers/mmc/host/mmc_spi.c b/drivers/mmc/host/mmc_spi.c index 65c65bb5737f..3d28a3d3001b 100644 --- a/drivers/mmc/host/mmc_spi.c +++ b/drivers/mmc/host/mmc_spi.c @@ -948,7 +948,7 @@ mmc_spi_data_do(struct mmc_spi_host *host, struct mmc_command *cmd, /* discard mappings */ if (direction == DMA_FROM_DEVICE) - flush_kernel_dcache_page(sg_page(sg)); + flush_dcache_page(sg_page(sg)); kunmap(sg_page(sg)); if (dma_dev) dma_unmap_page(dma_dev, dma_addr, PAGE_SIZE, dir);
Pages passed to block drivers can be mapped page cache pages, so we must use flush_dcache_page here instead of the more limited flush_kernel_dcache_page that is intended for highmem pages only. Signed-off-by: Christoph Hellwig <hch@lst.de> --- drivers/mmc/host/mmc_spi.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)