| Message ID | 20211021170414.3341522-2-maz@kernel.org (mailing list archive) |
|---|---|
| State | Not Applicable |
| Headers | show |
| Series | genirq: Make irq_cpu_{on,off}line() an Octeon-special | expand |
On Thu, Oct 21, 2021 at 06:04:12PM +0100, Marc Zyngier wrote: > Also loongson64 calls irq_cpu_offline(), none of its interrupt > controllers implement the .irq_cpu_offline callback. > > It is thus obvious that this call only serves the dubious purpose > of wasting precious CPU cycles by iterating over all interrupts. > > Get rid of the call altogether. > > Signed-off-by: Marc Zyngier <maz@kernel.org> > --- > arch/mips/loongson64/smp.c | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/arch/mips/loongson64/smp.c b/arch/mips/loongson64/smp.c > index 09ebe84a17fe..660e1de4412a 100644 > --- a/arch/mips/loongson64/smp.c > +++ b/arch/mips/loongson64/smp.c > @@ -550,7 +550,6 @@ static int loongson3_cpu_disable(void) > set_cpu_online(cpu, false); > calculate_cpu_foreign_map(); > local_irq_save(flags); > - irq_cpu_offline(); > clear_c0_status(ST0_IM); > local_irq_restore(flags); > local_flush_tlb_all(); > -- > 2.30.2 Acked-by: Thomas Bogendoerfer <tsbogend@alpha.franken.de>
On 10/21/2021 10:04 AM, Marc Zyngier wrote: > Also loongson64 calls irq_cpu_offline(), none of its interrupt > controllers implement the .irq_cpu_offline callback. > > It is thus obvious that this call only serves the dubious purpose > of wasting precious CPU cycles by iterating over all interrupts. > > Get rid of the call altogether. > > Signed-off-by: Marc Zyngier <maz@kernel.org> Reviewed-by: Florian Fainelli <f.fainelli@gmail.com> -- Florian
diff --git a/arch/mips/loongson64/smp.c b/arch/mips/loongson64/smp.c index 09ebe84a17fe..660e1de4412a 100644 --- a/arch/mips/loongson64/smp.c +++ b/arch/mips/loongson64/smp.c @@ -550,7 +550,6 @@ static int loongson3_cpu_disable(void) set_cpu_online(cpu, false); calculate_cpu_foreign_map(); local_irq_save(flags); - irq_cpu_offline(); clear_c0_status(ST0_IM); local_irq_restore(flags); local_flush_tlb_all();
Also loongson64 calls irq_cpu_offline(), none of its interrupt controllers implement the .irq_cpu_offline callback. It is thus obvious that this call only serves the dubious purpose of wasting precious CPU cycles by iterating over all interrupts. Get rid of the call altogether. Signed-off-by: Marc Zyngier <maz@kernel.org> --- arch/mips/loongson64/smp.c | 1 - 1 file changed, 1 deletion(-)