| Message ID | 20211215200602.6546-1-sander@svanheule.net (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | 6fb8a1b3203390d88ca2dfb3d0971a6c1217739e |
| Headers | show |
| Series | MIPS: drop selected EARLY_PRINTK configs for MACH_REALTEK_RTL | expand |
On Wed, Dec 15, 2021 at 09:06:02PM +0100, Sander Vanheule wrote: > MACH_REALTEK_RTL declares that the system supports early printk , but > this is not actually implemented as intended. The system is left with a > non-functional early0 console because the setup_8250_early_printk_port() > call provided for MIPS_GENERIC is never used to set this up. Generic > ns16550a earlycon works, so devices should use that for early output. > This means that SYS_HAS_EARLY_PRINTK and USE_GENERIC_EARLY_PRINTK_8250 > do not need to be selected. > > Additionally, as reported by Lukas Bulwahn, the selected symbol > SYS_HAS_EARLY_PRINTK_8250 does not actually exist, so should also be > dropped. > > Cc: Lukas Bulwahn <lukas.bulwahn@gmail.com> > Cc: Bert Vermeulen <bert@biot.com> > Signed-off-by: Sander Vanheule <sander@svanheule.net> > --- > arch/mips/Kconfig | 3 --- > 1 file changed, 3 deletions(-) > > diff --git a/arch/mips/Kconfig b/arch/mips/Kconfig > index 63eb66a22691..9a3a2330fc69 100644 > --- a/arch/mips/Kconfig > +++ b/arch/mips/Kconfig > @@ -642,9 +642,6 @@ config MACH_REALTEK_RTL > select SYS_SUPPORTS_MIPS16 > select SYS_SUPPORTS_MULTITHREADING > select SYS_SUPPORTS_VPE_LOADER > - select SYS_HAS_EARLY_PRINTK > - select SYS_HAS_EARLY_PRINTK_8250 > - select USE_GENERIC_EARLY_PRINTK_8250 > select BOOT_RAW > select PINCTRL > select USE_OF > -- > 2.33.1 applied to mips-next. Thomas.
diff --git a/arch/mips/Kconfig b/arch/mips/Kconfig index 63eb66a22691..9a3a2330fc69 100644 --- a/arch/mips/Kconfig +++ b/arch/mips/Kconfig @@ -642,9 +642,6 @@ config MACH_REALTEK_RTL select SYS_SUPPORTS_MIPS16 select SYS_SUPPORTS_MULTITHREADING select SYS_SUPPORTS_VPE_LOADER - select SYS_HAS_EARLY_PRINTK - select SYS_HAS_EARLY_PRINTK_8250 - select USE_GENERIC_EARLY_PRINTK_8250 select BOOT_RAW select PINCTRL select USE_OF
MACH_REALTEK_RTL declares that the system supports early printk , but this is not actually implemented as intended. The system is left with a non-functional early0 console because the setup_8250_early_printk_port() call provided for MIPS_GENERIC is never used to set this up. Generic ns16550a earlycon works, so devices should use that for early output. This means that SYS_HAS_EARLY_PRINTK and USE_GENERIC_EARLY_PRINTK_8250 do not need to be selected. Additionally, as reported by Lukas Bulwahn, the selected symbol SYS_HAS_EARLY_PRINTK_8250 does not actually exist, so should also be dropped. Cc: Lukas Bulwahn <lukas.bulwahn@gmail.com> Cc: Bert Vermeulen <bert@biot.com> Signed-off-by: Sander Vanheule <sander@svanheule.net> --- arch/mips/Kconfig | 3 --- 1 file changed, 3 deletions(-)