| Message ID | 20220123174031.3109-1-rdunlap@infradead.org (mailing list archive) |
|---|---|
| State | Handled Elsewhere |
| Headers | show |
| Series | pcmcia: db1xxx_ss: restrict to MIPS_DB1XXX boards | expand |
Hello, On Sun, Jan 23, 2022 at 6:40 PM Randy Dunlap <rdunlap@infradead.org> wrote: > When the MIPS_ALCHEMY board selection is MIPS_XXS1500 instead of > MIPS_DB1XXX, the PCMCIA driver 'db1xxx_ss' has build errors due > to missing DB1XXX symbols. The PCMCIA driver should be restricted > to MIPS_DB1XXX instead of MIPS_ALCHEMY to fix this build error. > config PCMCIA_ALCHEMY_DEVBOARD > tristate "Alchemy Db/Pb1xxx PCMCIA socket services" > - depends on MIPS_ALCHEMY && PCMCIA > + depends on MIPS_DB1XXX && PCMCIA > help > Enable this driver of you want PCMCIA support on your Alchemy > Db1000, Db/Pb1100, Db/Pb1500, Db/Pb1550, Db/Pb1200, DB1300 Seems sensible. Acked-by: Manuel Lauss <manuel.lauss@gmail.com> Thank you! Manuel
Am Sun, Jan 23, 2022 at 09:40:31AM -0800 schrieb Randy Dunlap: > When the MIPS_ALCHEMY board selection is MIPS_XXS1500 instead of > MIPS_DB1XXX, the PCMCIA driver 'db1xxx_ss' has build errors due > to missing DB1XXX symbols. The PCMCIA driver should be restricted > to MIPS_DB1XXX instead of MIPS_ALCHEMY to fix this build error. > > ERROR: modpost: "bcsr_read" [drivers/pcmcia/db1xxx_ss.ko] undefined! > ERROR: modpost: "bcsr_mod" [drivers/pcmcia/db1xxx_ss.ko] undefined! > > Fixes: 42a4f17dc356 ("MIPS: Alchemy: remove SOC_AU1X00 in favor of MIPS_ALCHEMY") > Signed-off-by: Randy Dunlap <rdunlap@infradead.org> > Reported-by: kernel test robot <lkp@intel.com> > Cc: Dominik Brodowski <linux@dominikbrodowski.net> > Cc: Arnd Bergmann <arnd@arndb.de> > Cc: Daniel Vetter <daniel.vetter@ffwll.ch> > Cc: Kees Cook <keescook@chromium.org> > Cc: Manuel Lauss <manuel.lauss@gmail.com> > Cc: Thomas Bogendoerfer <tsbogend@alpha.franken.de> > Cc: linux-mips@vger.kernel.org Applied to -pcmcia, thanks! Dominik
--- linux-next-20220121.orig/drivers/pcmcia/Kconfig +++ linux-next-20220121/drivers/pcmcia/Kconfig @@ -151,7 +151,7 @@ config TCIC config PCMCIA_ALCHEMY_DEVBOARD tristate "Alchemy Db/Pb1xxx PCMCIA socket services" - depends on MIPS_ALCHEMY && PCMCIA + depends on MIPS_DB1XXX && PCMCIA help Enable this driver of you want PCMCIA support on your Alchemy Db1000, Db/Pb1100, Db/Pb1500, Db/Pb1550, Db/Pb1200, DB1300
When the MIPS_ALCHEMY board selection is MIPS_XXS1500 instead of MIPS_DB1XXX, the PCMCIA driver 'db1xxx_ss' has build errors due to missing DB1XXX symbols. The PCMCIA driver should be restricted to MIPS_DB1XXX instead of MIPS_ALCHEMY to fix this build error. ERROR: modpost: "bcsr_read" [drivers/pcmcia/db1xxx_ss.ko] undefined! ERROR: modpost: "bcsr_mod" [drivers/pcmcia/db1xxx_ss.ko] undefined! Fixes: 42a4f17dc356 ("MIPS: Alchemy: remove SOC_AU1X00 in favor of MIPS_ALCHEMY") Signed-off-by: Randy Dunlap <rdunlap@infradead.org> Reported-by: kernel test robot <lkp@intel.com> Cc: Dominik Brodowski <linux@dominikbrodowski.net> Cc: Arnd Bergmann <arnd@arndb.de> Cc: Daniel Vetter <daniel.vetter@ffwll.ch> Cc: Kees Cook <keescook@chromium.org> Cc: Manuel Lauss <manuel.lauss@gmail.com> Cc: Thomas Bogendoerfer <tsbogend@alpha.franken.de> Cc: linux-mips@vger.kernel.org --- drivers/pcmcia/Kconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)