| Message ID | 20220301011507.15494-1-ilya.lipnitskiy@gmail.com (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | 5d8965704fe5662e2e4a7e4424a2cbe53e182670 |
| Headers | show |
| Series | MIPS: ralink: mt7621: use bitwise NOT instead of logical | expand |
Hi Ilya, On Tue, Mar 1, 2022 at 2:49 AM Ilya Lipnitskiy <ilya.lipnitskiy@gmail.com> wrote: > > It was the intention to reverse the bits, not make them all zero by > using logical NOT operator. > > Fixes: cc19db8b312a ("MIPS: ralink: mt7621: do memory detection on KSEG1") > Suggested-by: Chuanhong Guo <gch981213@gmail.com> > Signed-off-by: Ilya Lipnitskiy <ilya.lipnitskiy@gmail.com> > --- > arch/mips/ralink/mt7621.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) Reviewed-by: Sergio Paracuellos <sergio.paracuellos@gmail.com> Thanks, Sergio Paracuellos
On Mon, Feb 28, 2022 at 05:15:07PM -0800, Ilya Lipnitskiy wrote: > It was the intention to reverse the bits, not make them all zero by > using logical NOT operator. > > Fixes: cc19db8b312a ("MIPS: ralink: mt7621: do memory detection on KSEG1") > Suggested-by: Chuanhong Guo <gch981213@gmail.com> > Signed-off-by: Ilya Lipnitskiy <ilya.lipnitskiy@gmail.com> > --- > arch/mips/ralink/mt7621.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/arch/mips/ralink/mt7621.c b/arch/mips/ralink/mt7621.c > index 12c8808e0dea..fb0565bc34fd 100644 > --- a/arch/mips/ralink/mt7621.c > +++ b/arch/mips/ralink/mt7621.c > @@ -69,7 +69,7 @@ static bool __init mt7621_addr_wraparound_test(phys_addr_t size) > __raw_writel(MT7621_MEM_TEST_PATTERN, dm); > if (__raw_readl(dm) != __raw_readl(dm + size)) > return false; > - __raw_writel(!MT7621_MEM_TEST_PATTERN, dm); > + __raw_writel(~MT7621_MEM_TEST_PATTERN, dm); > return __raw_readl(dm) == __raw_readl(dm + size); > } > > -- > 2.35.1 applied to mips-fixes Thomas.
diff --git a/arch/mips/ralink/mt7621.c b/arch/mips/ralink/mt7621.c index 12c8808e0dea..fb0565bc34fd 100644 --- a/arch/mips/ralink/mt7621.c +++ b/arch/mips/ralink/mt7621.c @@ -69,7 +69,7 @@ static bool __init mt7621_addr_wraparound_test(phys_addr_t size) __raw_writel(MT7621_MEM_TEST_PATTERN, dm); if (__raw_readl(dm) != __raw_readl(dm + size)) return false; - __raw_writel(!MT7621_MEM_TEST_PATTERN, dm); + __raw_writel(~MT7621_MEM_TEST_PATTERN, dm); return __raw_readl(dm) == __raw_readl(dm + size); }
It was the intention to reverse the bits, not make them all zero by using logical NOT operator. Fixes: cc19db8b312a ("MIPS: ralink: mt7621: do memory detection on KSEG1") Suggested-by: Chuanhong Guo <gch981213@gmail.com> Signed-off-by: Ilya Lipnitskiy <ilya.lipnitskiy@gmail.com> --- arch/mips/ralink/mt7621.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)