| Message ID | 20220523081625.2074527-1-zhanggenjian@kylinos.cn (mailing list archive) |
|---|---|
| State | Rejected |
| Headers | show |
| Series | irq: mips: Export irq_err_count to modules | expand |
On Mon, May 23, 2022 at 04:16:25PM +0800, Genjian Zhang wrote: > From: huhai <huhai@kylinos.cn> > > modpost complains once these drivers become modules. > ERROR: modpost: "irq_err_count" [drivers/gpio/gpio-vr41xx.ko] undefined! > > Fix it by export them when that symbol is =m. > > Fixes: 27fdd325dace ("MIPS: Update VR41xx GPIO driver to use gpiolib") > Reported-by: k2ci <kernel-bot@kylinos.cn> > Signed-off-by: huhai <huhai@kylinos.cn> > --- > arch/mips/kernel/irq.c | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/arch/mips/kernel/irq.c b/arch/mips/kernel/irq.c > index 5e11582fe308..b0038b715008 100644 > --- a/arch/mips/kernel/irq.c > +++ b/arch/mips/kernel/irq.c > @@ -38,6 +38,9 @@ void ack_bad_irq(unsigned int irq) > } > > atomic_t irq_err_count; > +#ifdef CONFIG_GPIO_VR41XX_MODULE > +EXPORT_SYMBOL_GPL(irq_err_count); > +#endif please use spurious_interrupt() in drivers/gpio/gpio-vr41xx.c. Thomas.
diff --git a/arch/mips/kernel/irq.c b/arch/mips/kernel/irq.c index 5e11582fe308..b0038b715008 100644 --- a/arch/mips/kernel/irq.c +++ b/arch/mips/kernel/irq.c @@ -38,6 +38,9 @@ void ack_bad_irq(unsigned int irq) } atomic_t irq_err_count; +#ifdef CONFIG_GPIO_VR41XX_MODULE +EXPORT_SYMBOL_GPL(irq_err_count); +#endif int arch_show_interrupts(struct seq_file *p, int prec) {