diff mbox series

MIPS: loongson32: ls1c: Fix hang during startup

Message ID 20220823111725.3134377-1-keguang.zhang@gmail.com (mailing list archive)
State Accepted
Commit 35508d2424097f9b6a1a17aac94f702767035616
Headers show
Series MIPS: loongson32: ls1c: Fix hang during startup | expand

Commit Message

Keguang Zhang Aug. 23, 2022, 11:17 a.m. UTC 
From: Yang Ling <gnaygnil@gmail.com>

The RTCCTRL reg of LS1C is obselete.
Writing this reg will cause system hang.

Fixes: 60219c563c9b6 ("MIPS: Add RTC support for Loongson1C board")
Signed-off-by: Yang Ling <gnaygnil@gmail.com>
Tested-by: Keguang Zhang <keguang.zhang@gmail.com>
Acked-by: Keguang Zhang <keguang.zhang@gmail.com>
---
 arch/mips/loongson32/ls1c/board.c | 1 -
 1 file changed, 1 deletion(-)


base-commit: 568035b01cfb107af8d2e4bd2fb9aea22cf5b868

Comments

Thomas Bogendoerfer Aug. 29, 2022, 1:14 p.m. UTC | #1 
On Tue, Aug 23, 2022 at 07:17:25PM +0800, Keguang Zhang wrote:
> From: Yang Ling <gnaygnil@gmail.com>
> 
> The RTCCTRL reg of LS1C is obselete.
> Writing this reg will cause system hang.
> 
> Fixes: 60219c563c9b6 ("MIPS: Add RTC support for Loongson1C board")
> Signed-off-by: Yang Ling <gnaygnil@gmail.com>
> Tested-by: Keguang Zhang <keguang.zhang@gmail.com>
> Acked-by: Keguang Zhang <keguang.zhang@gmail.com>
> ---
>  arch/mips/loongson32/ls1c/board.c | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/arch/mips/loongson32/ls1c/board.c b/arch/mips/loongson32/ls1c/board.c
> index e9de6da0ce51..9dcfe9de55b0 100644
> --- a/arch/mips/loongson32/ls1c/board.c
> +++ b/arch/mips/loongson32/ls1c/board.c
> @@ -15,7 +15,6 @@ static struct platform_device *ls1c_platform_devices[] __initdata = {
>  static int __init ls1c_platform_init(void)
>  {
>  	ls1x_serial_set_uartclk(&ls1x_uart_pdev);
> -	ls1x_rtc_set_extclk(&ls1x_rtc_pdev);
>  
>  	return platform_add_devices(ls1c_platform_devices,
>  				   ARRAY_SIZE(ls1c_platform_devices));
> 
> base-commit: 568035b01cfb107af8d2e4bd2fb9aea22cf5b868
> -- 
> 2.34.1

applied to mips-fixes.

Thomas.
diff mbox series

Patch

diff --git a/arch/mips/loongson32/ls1c/board.c b/arch/mips/loongson32/ls1c/board.c
index e9de6da0ce51..9dcfe9de55b0 100644
--- a/arch/mips/loongson32/ls1c/board.c
+++ b/arch/mips/loongson32/ls1c/board.c
@@ -15,7 +15,6 @@  static struct platform_device *ls1c_platform_devices[] __initdata = {
 static int __init ls1c_platform_init(void)
 {
 	ls1x_serial_set_uartclk(&ls1x_uart_pdev);
-	ls1x_rtc_set_extclk(&ls1x_rtc_pdev);
 
 	return platform_add_devices(ls1c_platform_devices,
 				   ARRAY_SIZE(ls1c_platform_devices));